Skip to content

Commit 95a67a1

Browse files
committed
Improve unit tests
1 parent 517a9f4 commit 95a67a1

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

python/tests/hypothesis/arcticdb/test_resample.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
COLUMN_DTYPE = ["float", "int", "uint"]
1212
ALL_AGGREGATIONS = ["sum", "mean", "min", "max", "first", "last", "count"]
1313
MIN_DATE = np.datetime64('1969-01-01')
14-
MAX_DATE = np.datetime64('1973-01-01')
14+
MAX_DATE = np.datetime64('1971-01-01')
1515

1616
pytestmark = pytest.mark.pipeline
1717

@@ -69,8 +69,8 @@ def origin(draw):
6969
selected_origin = draw(st.sampled_from(["start", "end", "start_day", "end_day", "epoch", "timestamp"]))
7070
# Hypothesis may generate dates for year > 2200 and some of the arithmetic operation will overflow.
7171
if selected_origin == "timestamp":
72-
min_date = MIN_DATE - np.timedelta64(365, 'D')
73-
max_date = MAX_DATE + np.timedelta64(365, 'D')
72+
min_date = MIN_DATE - np.timedelta64(5, 'D')
73+
max_date = MAX_DATE + np.timedelta64(5, 'D')
7474
return pd.Timestamp(draw(date(min_date=min_date, max_date=max_date)))
7575
else:
7676
return selected_origin
@@ -96,7 +96,7 @@ def offset(draw):
9696
unit = draw(st.sampled_from(['s', 'min', 'h', None]))
9797
if unit is None:
9898
return None
99-
count = draw(st.integers(min_value=1, max_value=10_000))
99+
count = draw(st.integers(min_value=1, max_value=100))
100100
result = f"{count}{unit}"
101101
assume(freq_fits_in_64_bits(count=count, unit=unit))
102102
return result

python/tests/unit/arcticdb/version_store/test_aggregation.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -524,14 +524,14 @@ def test_extremum_aggregation_with_missing_aggregation_column(lmdb_version_store
524524
lib = lmdb_version_store_dynamic_schema_v1
525525
sym = "sym"
526526
df1 = pd.DataFrame({"agg_column": np.array([0.0, 0.0], dtype)})
527-
df2 = pd.DataFrame({"grouping_column": ["0"]})
528-
df3 = pd.DataFrame({"grouping_column": ["00"], "agg_column": np.array([0], dtype)})
527+
df2 = pd.DataFrame({"grouping_column": [0]})
528+
df3 = pd.DataFrame({"grouping_column": [1], "agg_column": np.array([0], dtype)})
529529
for df in [df1, df2, df3]:
530530
lib.append(sym, df)
531531
q = QueryBuilder()
532532
q = q.groupby("grouping_column").agg({"agg_column": extremum})
533533
data = lib.read("sym", query_builder=q).data
534534
default_value = 0 if dtype == np.int32 else np.nan
535-
expected = pd.DataFrame({"agg_column": np.array([default_value, 0], dtype)}, index=["0", "00"])
535+
expected = pd.DataFrame({"agg_column": np.array([default_value, 0], dtype)}, index=[0, 1])
536536
expected.index.name = "grouping_column"
537537
assert_frame_equal(data, expected)

0 commit comments

Comments
 (0)