Code review comments

Author: willdealtry

cpp/arcticdb/pipeline/read_frame.cpp

@@ -244,7 +244,6 @@ void decode_index_field(
                         context.descriptor().fields(0).type(), frame_field_descriptor.type());
 
             std::optional<util::BitMagic> bv;
-            log::version().debug("{}", dump_bytes(begin, (data - begin) + encoding_sizes::field_compressed_size(field), 100u));
             data += decode_field(frame_field_descriptor.type(), field, data, sink, bv, encoding_version);
             util::check(!bv, "Unexpected sparse vector in index field");
             ARCTICDB_DEBUG(log::codec(), "Decoded index column {} to position {}", 0, data - begin);

cpp/arcticdb/storage/s3/s3_client_impl.cpp

@@ -190,7 +190,6 @@ S3Result<std::monostate> S3ClientImpl::put_object(
     ARCTICDB_RUNTIME_DEBUG(log::storage(), "Set s3 key {}", request.GetKey().c_str());
     auto [dst, write_size, buffer] = segment.serialize_header();
 
-    auto seg_header [[maybe_unused]] = reinterpret_cast<FixedHeader*>(dst);
     auto body = std::make_shared<boost::interprocess::bufferstream>(reinterpret_cast<char *>(dst), write_size);
     util::check(body->good(), "Overflow of bufferstream with size {}", write_size);
     request.SetBody(body);

cpp/arcticdb/util/buffer.hpp

@@ -248,11 +248,11 @@ struct Buffer : public BaseBuffer<Buffer, true> {
     }
 
     void check_invariants() const  {
-//#ifdef DEBUG_BUILD
+#ifdef DEBUG_BUILD
         util::check(preamble_bytes_ + body_bytes_ <= capacity_, "total_bytes exceeds capacity {} + {} > {}", preamble_bytes_, body_bytes_, capacity_);
         util::check(total_bytes() == preamble_bytes_ + body_bytes_, "Total bytes calculation is incorrect {} != {} + {}", total_bytes(), preamble_bytes_, body_bytes_);
         util::check(data_ + preamble_bytes_ == ptr_, "Buffer pointer is in the wrong place {} + {} != {}", uintptr_t(data_), preamble_bytes_, uintptr_t(ptr_));
-//#endif
+#endif
     }
 
     uint8_t *data_ = nullptr;