Skip to content

Commit c6e5894

Browse files
authored
Update test_mem_leaks.py not to fail on MacOS (#2197)
#### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> Currently mem limit on MacOs is shaky and will remove the check there will remain on Win and Linux #### What does this implement or fix? ## Change Type (Required) - [x] **Patch** (Bug fix or non-breaking improvement) - [ ] **Minor** (New feature, but backward compatible) - [ ] **Major** (Breaking changes) - [ ] **Cherry pick** #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
1 parent c79b28b commit c6e5894

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

python/tests/stress/arcticdb/version_store/test_mem_leaks.py

+2
Original file line numberDiff line numberDiff line change
@@ -671,6 +671,7 @@ def test_mem_leak_querybuilder_read_batch_memray(library_with_symbol):
671671

672672
@MEMRAY_TESTS_MARK
673673
@pytest.mark.limit_memory("490 MB")
674+
@pytest.mark.skipif(MACOS, reason="Mac OS mem usage is harder to predicts than WINDOWS")
674675
def test_mem_limit_querybuilder_read_memray(library_with_symbol):
675676
"""
676677
The fact that we do not leak memory does not mean that we
@@ -684,6 +685,7 @@ def test_mem_limit_querybuilder_read_memray(library_with_symbol):
684685

685686
@MEMRAY_TESTS_MARK
686687
@pytest.mark.limit_memory("490 MB")
688+
@pytest.mark.skipif(MACOS, reason="Mac OS mem usage is harder to predicts than WINDOWS")
687689
def test_mem_limit_querybuilder_read_batch_memray(library_with_symbol):
688690
"""
689691
The fact that we do not leak memory does not mean that we

0 commit comments

Comments
 (0)