Factor out check that a stream descriptor represents a timeseries into its own method

Author: alexowens90

cpp/arcticdb/processing/clause.cpp

@@ -110,6 +110,16 @@ void check_column_presence(OutputSchema& output_schema, const std::unordered_set
     }
 }
 
+void check_is_timeseries(const StreamDescriptor& stream_descriptor, std::string_view clause_name) {
+    schema::check<ErrorCode::E_UNSUPPORTED_INDEX_TYPE>(
+            stream_descriptor.index().type() == IndexDescriptor::Type::TIMESTAMP &&
+            stream_descriptor.index().field_count() >= 1 &&
+            stream_descriptor.field(0).type() == make_scalar_type(DataType::NANOSECONDS_UTC64),
+            "{}Clause can only be applied to timeseries",
+            clause_name
+    );
+}
+
 std::vector<EntityId> PassthroughClause::process(std::vector<EntityId>&& entity_ids) const {
     return std::move(entity_ids);
 }
@@ -520,12 +530,7 @@ void ResampleClause<closed_boundary>::set_component_manager(std::shared_ptr<Comp
 
 template<ResampleBoundary closed_boundary>
 OutputSchema ResampleClause<closed_boundary>::modify_schema(OutputSchema&& output_schema) const {
-    schema::check<ErrorCode::E_UNSUPPORTED_INDEX_TYPE>(
-            output_schema.stream_descriptor_.index().type() == IndexDescriptor::Type::TIMESTAMP &&
-            output_schema.stream_descriptor_.index().field_count() >= 1 &&
-            output_schema.stream_descriptor_.field(0).type() == make_scalar_type(DataType::NANOSECONDS_UTC64),
-            "ResampleClause can only be applied to timeseries"
-    );
+    check_is_timeseries(output_schema.stream_descriptor_, "Resample");
     check_column_presence(output_schema, *clause_info_.input_columns_, "Resample");
     StreamDescriptor stream_desc(output_schema.stream_descriptor_.id());
     stream_desc.add_field(output_schema.stream_descriptor_.field(0));
@@ -1003,12 +1008,7 @@ const ClauseInfo& MergeClause::clause_info() const {
 }
 
 OutputSchema MergeClause::modify_schema(OutputSchema&& output_schema) const {
-    schema::check<ErrorCode::E_UNSUPPORTED_INDEX_TYPE>(
-            output_schema.stream_descriptor_.index().type() == IndexDescriptor::Type::TIMESTAMP &&
-            output_schema.stream_descriptor_.index().field_count() >= 1 &&
-            output_schema.stream_descriptor_.field(0).type() == make_scalar_type(DataType::NANOSECONDS_UTC64),
-            "MergeClause can only be applied to timeseries"
-    );
+    check_is_timeseries(output_schema.stream_descriptor_, "Merge");
     return output_schema;
 }
 
@@ -1323,12 +1323,7 @@ std::vector<EntityId> DateRangeClause::process(std::vector<EntityId> &&entity_id
 }
 
 OutputSchema DateRangeClause::modify_schema(OutputSchema&& output_schema) const {
-    schema::check<ErrorCode::E_UNSUPPORTED_INDEX_TYPE>(
-            output_schema.stream_descriptor_.index().type() == IndexDescriptor::Type::TIMESTAMP &&
-            output_schema.stream_descriptor_.index().field_count() >= 1 &&
-            output_schema.stream_descriptor_.field(0).type() == make_scalar_type(DataType::NANOSECONDS_UTC64),
-            "DateRangeClause can only be applied to timeseries"
-            );
+    check_is_timeseries(output_schema.stream_descriptor_, "DateRange");
     return output_schema;
 }