Intentional errors

Author: vasil-pashov

.github/workflows/analysis_workflow.yml

@@ -1,35 +1,5 @@
 name: Build with analysis tools
-on:
-  workflow_dispatch:
-    inputs:
-      run_all_benchmarks:
-        type: boolean
-        default: false
-      dev_image_tag:
-        description: Tag of the ArcticDB development image to use for benchmark and code coverage flows
-        type: string
-        default: latest
-      suite_to_run:
-          description: Run LMDB suite or REAL storage (or both - ALL)
-          type: choice
-          options:
-            - 'LMDB'
-            - 'REAL'
-            - 'ALL'
-          default: 'LMDB'
-      suite_overwrite:
-        description: Specify regular expression for specific tests to be executed
-        type: string
-        default: ''
-  
-
-  schedule: # Schedule the job to run at 12 a.m. daily
-    - cron: '0 0 * * *'
-
-  pull_request_target:
-    paths-ignore:
-    - "**/*.md"
-
+on: workflow_call
 jobs:
 
   get_commits_to_benchmark:

.github/workflows/build.yml

@@ -1,43 +1,5 @@
 name: Build and Test
-on:
-  push:
-    # On push only local storage tests get executed
-    tags: ["v**"]
-    branches: ["master"]
-  pull_request:
-    # On pull requests only local storage tests get executed
-    branches: ["**"]
-  schedule:
-    # IMPORTANT: For scheduled job we execute AWS_S3
-    - cron: '0 6 * * 1,4' # Mon and Thu at 6 am
-  workflow_dispatch:
-    inputs:
-      persistent_storage:
-        description: Run the persistent storage tests?
-        type: choice
-        options:
-          - 'no'
-          - 'AWS_S3'
-          - 'GCPXML'
-        default: 'no'
-
-      pypi_publish:
-        type: boolean
-      publish_env:
-        description: Environment to publish to
-        type: environment
-      cmake_preset_type:
-        description: Override CMAKE preset type
-        type: choice
-        options: ["-", debug, release]
-      dev_image_tag:
-        description: Tag of the ArcticDB development image to use for the Linux C++ tests build
-        type: string
-        default: arcticdb-dev-clang:latest
-      pytest_args:
-        description: Rewrite what tests will run
-        type: string
-        default: ""
+on: workflow_call
 run-name: Building ${{github.ref_name}} on ${{github.event_name}} by ${{github.actor}}
 concurrency:
   group: ${{github.ref}}

.github/workflows/build_with_conda.yml

@@ -1,22 +1,5 @@
 name: Build with conda
-on:
-  push:
-    branches:
-      - master
-  # For Pull-Requests, this runs the CI on merge commit
-  # of HEAD with the target branch instead on HEAD, allowing
-  # testing against potential new states which might have
-  # been introduced in the target branch last commits.
-  # See: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
-  pull_request:
-
-  workflow_dispatch:
-    inputs:
-      run_on_arm_mac:
-        description: 'Run on arm macos'
-        type: boolean
-        required: false
-        default: false
+on: workflow_call
 
 jobs:
 

.github/workflows/static_analysis.yml

@@ -4,6 +4,7 @@
     workflow_dispatch:
     schedule:
       - cron: "0 3 * * *"
+    pull_request: 
 
   jobs:
     polaris-scan:

cpp/arcticdb/version/local_versioned_engine.cpp

@@ -723,6 +723,30 @@ VersionedItem LocalVersionedEngine::write_versioned_dataframe_internal(
     bool allow_sparse,
     bool validate_index
     ) {
+
+    // =======================================================
+    // INTENTIONAL ERROR
+    std::vector<int> v(1000);
+    for (int i = 0; i < 1000; i++) {
+        v[i] = i;
+    }
+    std::vector v1 = std::move(v);
+    for (size_t i = 0; i < v.size(); ++i) {
+        std::cout<<v[i];
+        v[i] = i;
+    }
+
+    std::vector v2 = std::move(v1);
+    for (auto i : v1) {
+        std::cout<<i;
+    }
+
+    volatile int* i = new int(0);
+    delete i;
+    volatile int a = *i;
+    std::cout<<a<<" "<<*i<<std::endl;
+    //========================================================
+
     ARCTICDB_SAMPLE(WriteVersionedDataFrame, 0)
     py::gil_scoped_release release_gil;
     ARCTICDB_RUNTIME_DEBUG(log::version(), "Command: write_versioned_dataframe");

cpp/arcticdb/version/version_core.cpp

@@ -1902,6 +1902,24 @@ VersionedItem compact_incomplete_impl(
         ReadOptions{},
         read_incomplete_flags
     );
+
+    // =======================================================
+    // INTENTIONAL ERROR
+    std::vector v = {1, 2, 3, 4};
+    std::vector v1 = std::move(v);
+    for (auto i : v) {
+        std::cout<<i;
+    }
+    for (auto i : v1) {
+        std::cout<<i;
+    }
+
+    int* i = new int(0);
+    delete i;
+    std::cout<<*i<<std::endl;
+    //========================================================
+
+
     user_input::check<ErrorCode::E_NO_STAGED_SEGMENTS>(
         has_incomplete_segments,
         "Finalizing staged data is not allowed with empty staging area"