Test fixes

Removed Problem.AddInvalidMessage methods added in last commit. Use the existing AddValidationError method instead which does the same thing, except safer.
All unit tests now passing again.

Author: nandos13

ManagedCode.Communication.Tests/Extensions/ProblemExtensionsTests.cs

@@ -294,8 +294,8 @@ public void AddInvalidMessage_ShouldAddValidationError()
         var problem = new Problem();
 
         // Act
-        problem.AddInvalidMessage("email", "Email is required");
-        problem.AddInvalidMessage("email", "Email format is invalid");
+        problem.AddValidationError("email", "Email is required");
+        problem.AddValidationError("email", "Email format is invalid");
 
         // Assert
         problem.InvalidField("email")
@@ -315,7 +315,7 @@ public void AddInvalidMessage_WithGeneralMessage_ShouldAddToGeneralErrors()
         var problem = new Problem();
 
         // Act
-        problem.AddInvalidMessage("General error occurred");
+        problem.AddValidationError("General error occurred");
 
         // Assert
         problem.InvalidField("_general")

ManagedCode.Communication/CollectionResultT/CollectionResult.cs

@@ -145,18 +145,18 @@ public string InvalidFieldError(string fieldName)
             : Problem.InvalidFieldError(fieldName);
     }
 
-    [Obsolete("Use Problem.AddInvalidMessage instead")]
+    [Obsolete("Use Problem.AddValidationError instead")]
     public void AddInvalidMessage(string message)
     {
         if (!IsSuccess)
-            Problem.AddInvalidMessage(message);
+            Problem.AddValidationError(message);
     }
 
-    [Obsolete("Use Problem.AddInvalidMessage instead")]
+    [Obsolete("Use Problem.AddValidationError instead")]
     public void AddInvalidMessage(string key, string value)
     {
         if (!IsSuccess)
-            Problem.AddInvalidMessage(key, value);
+            Problem.AddValidationError(key, value);
     }
 
     #endregion

ManagedCode.Communication/IResultInvalid.cs

@@ -17,14 +17,14 @@ public interface IResultInvalid
     ///     Adds an invalid message to the result.
     /// </summary>
     /// <param name="message">The invalid message to add.</param>
-    [Obsolete("Use Problem.AddInvalidMessage instead")]
+    [Obsolete("Use Problem.AddValidationError instead")]
     void AddInvalidMessage(string message);
 
     /// <summary>
     ///     Adds an invalid message to the result with a specific key.
     /// </summary>
     /// <param name="key">The key of the invalid message.</param>
     /// <param name="value">The value of the invalid message.</param>
-    [Obsolete("Use Problem.AddInvalidMessage instead")]
+    [Obsolete("Use Problem.AddValidationError instead")]
     void AddInvalidMessage(string key, string value);
 }

ManagedCode.Communication/Problem/Problem.Extensions.cs

@@ -470,7 +470,13 @@ public void AddValidationError(string field, string message)
 
         fieldErrors.Add(message);
     }
-    
+
+    public void AddValidationError(string message)
+    {
+        const string field = ProblemConstants.ValidationFields.General;
+        AddValidationError(field, message);
+    }
+
     /// <summary>
     ///     Gets or creates validation errors dictionary.
     /// </summary>
@@ -486,36 +492,6 @@ private Dictionary<string, List<string>> GetOrCreateValidationErrors()
         return errors;
     }
 
-    public void AddInvalidMessage(string message)
-    {
-        const string key = ProblemConstants.ValidationFields.General;
-
-        Extensions[ProblemConstants.ExtensionKeys.Errors] ??= new Dictionary<string, List<string>>();
-        if (Extensions[ProblemConstants.ExtensionKeys.Errors] is Dictionary<string, List<string>> errors)
-        {
-            if (!errors.TryGetValue(key, out List<string>? list))
-            {
-                errors[key] = list = new();
-            }
-
-            list.Add(message);
-        }
-    }
-
-    public void AddInvalidMessage(string key, string value)
-    {
-        Extensions[ProblemConstants.ExtensionKeys.Errors] ??= new Dictionary<string, List<string>>();
-        if (Extensions[ProblemConstants.ExtensionKeys.Errors] is Dictionary<string, List<string>> errors)
-        {
-            if (!errors.TryGetValue(key, out List<string>? list))
-            {
-                errors[key] = list = new();
-            }
-
-            list.Add(value);
-        }
-    }
-
     public bool InvalidField(string fieldName)
     {
         var errors = GetValidationErrors();

ManagedCode.Communication/Problem/Problem.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Text.Json;
 using System.Text.Json.Serialization;
-using ManagedCode.Communication.Constants;
 
 namespace ManagedCode.Communication;
 

ManagedCode.Communication/Result/Result.cs

@@ -137,18 +137,18 @@ public string InvalidFieldError(string fieldName)
             : Problem.InvalidFieldError(fieldName);
     }
 
-    [Obsolete("Use Problem.AddInvalidMessage instead")]
+    [Obsolete("Use Problem.AddValidationError instead")]
     public void AddInvalidMessage(string message)
     {
         if (!IsSuccess)
-            Problem.AddInvalidMessage(message);
+            Problem.AddValidationError(message);
     }
 
-    [Obsolete("Use Problem.AddInvalidMessage instead")]
+    [Obsolete("Use Problem.AddValidationError instead")]
     public void AddInvalidMessage(string key, string value)
     {
         if (!IsSuccess)
-            Problem.AddInvalidMessage(key, value);
+            Problem.AddValidationError(key, value);
     }
 
     #endregion

ManagedCode.Communication/ResultT/Result.cs

@@ -153,21 +153,21 @@ public Problem? Problem
     /// <summary>
     ///     Adds an invalid message to the result.
     /// </summary>
-    [Obsolete("Use Problem.AddInvalidMessage instead")]
+    [Obsolete("Use Problem.AddValidationError instead")]
     public void AddInvalidMessage(string message)
     {
         if (!IsSuccess)
-            Problem.AddInvalidMessage(message);
+            Problem.AddValidationError(message);
     }
 
     /// <summary>
     ///     Adds an invalid message with a specific key to the result.
     /// </summary>
-    [Obsolete("Use Problem.AddInvalidMessage instead")]
+    [Obsolete("Use Problem.AddValidationError instead")]
     public void AddInvalidMessage(string key, string value)
     {
         if (!IsSuccess)
-            Problem.AddInvalidMessage(key, value);
+            Problem.AddValidationError(key, value);
     }
 
     public bool InvalidField(string fieldName)