Handle disposed service provider when resolving CommunicationLogger (#68)

Author: KSemenenko

ManagedCode.Communication.Tests/Extensions/ServiceCollectionExtensionsTests.cs

@@ -54,4 +54,23 @@ public void ConfigureCommunication_WithLoggerFactory_ConfiguresLoggerAndReturns(
         var logger = CommunicationLogger.GetLogger();
         logger.ShouldNotBeNull();
     }
+
+    [Fact]
+    public void GetLogger_WithDisposedServiceProvider_ShouldFallbackGracefully()
+    {
+        // Arrange
+        var services = new ServiceCollection();
+        services.AddLogging();
+        using (var serviceProvider = services.BuildServiceProvider())
+        {
+            CommunicationLogger.Configure(serviceProvider);
+        }
+
+        // Act & Assert
+        Should.NotThrow(() =>
+        {
+            var logger = CommunicationLogger.GetLogger();
+            logger.ShouldNotBeNull();
+        });
+    }
 }

ManagedCode.Communication/Logging/CommunicationLogger.cs

@@ -34,18 +34,30 @@ public static ILogger<Result> GetLogger()
 
     private static ILogger<Result> CreateLogger()
     {
-        var logger = _serviceProvider?.GetService<ILogger<Result>>();
-        if (logger != null)
-            return logger;
+        if (_serviceProvider != null)
+        {
+            try
+            {
+                var logger = _serviceProvider.GetService<ILogger<Result>>();
+                if (logger != null)
+                {
+                    return logger;
+                }
+            }
+            catch (ObjectDisposedException)
+            {
+                _serviceProvider = null;
+            }
+        }
 
         if (_fallbackLoggerFactory != null)
         {
-            return new Logger<Result>(_fallbackLoggerFactory);
+            return _fallbackLoggerFactory.CreateLogger<Result>();
         }
 
-        _lastResortLoggerFactory ??= LoggerFactory.Create(builder => 
+        _lastResortLoggerFactory ??= LoggerFactory.Create(builder =>
             builder.SetMinimumLevel(LogLevel.Warning));
-            
-        return new Logger<Result>(_lastResortLoggerFactory);
+
+        return _lastResortLoggerFactory.CreateLogger<Result>();
     }
 }