clean code

Author: KSemenenko

Directory.Build.props

@@ -6,7 +6,7 @@
         <Nullable>enable</Nullable>
         <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
-    
+
     <!--NuGet-->
     <PropertyGroup>
         <Authors>ManagedCode</Authors>

ManagedCode.Communication.Benchmark/CreateInstanceFailBenchmark.cs

@@ -1,3 +1,4 @@
+using System.Net;
 using BenchmarkDotNet.Attributes;
 
 namespace ManagedCode.Communication.Benchmark;
@@ -57,24 +58,24 @@ public Result ActivatorCreateInstanceGenericInt()
     [Benchmark]
     public Result CreateInstanceTypeError()
     {
-        return Result.Fail("about:blank", "Error", System.Net.HttpStatusCode.BadRequest);
+        return Result.Fail("about:blank", "Error", HttpStatusCode.BadRequest);
     }
 
     [Benchmark]
     public Result<int> CreateInstanceTypeIntError()
     {
-        return Result<int>.Fail("about:blank", "Error", System.Net.HttpStatusCode.BadRequest);
+        return Result<int>.Fail("about:blank", "Error", HttpStatusCode.BadRequest);
     }
 
     [Benchmark]
     public Result CreateInstanceTypeErrorInterface()
     {
-        return Result.Fail("about:blank", "Error", System.Net.HttpStatusCode.BadRequest);
+        return Result.Fail("about:blank", "Error", HttpStatusCode.BadRequest);
     }
 
     [Benchmark]
     public Result<int> CreateInstanceTypeIntErrorInterface()
     {
-        return Result<int>.Fail("about:blank", "Error", System.Net.HttpStatusCode.BadRequest);
+        return Result<int>.Fail("about:blank", "Error", HttpStatusCode.BadRequest);
     }
 }

ManagedCode.Communication.Benchmark/ManagedCode.Communication.Benchmark.csproj

@@ -9,11 +9,11 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="BenchmarkDotNet" Version="0.15.2" />
+        <PackageReference Include="BenchmarkDotNet" Version="0.15.2"/>
     </ItemGroup>
 
     <ItemGroup>
-        <ProjectReference Include="..\ManagedCode.Communication\ManagedCode.Communication.csproj" />
+        <ProjectReference Include="..\ManagedCode.Communication\ManagedCode.Communication.csproj"/>
     </ItemGroup>
 
 </Project>

ManagedCode.Communication.Benchmark/Program.cs

@@ -7,11 +7,12 @@ public class Program
 {
     public static void Main(string[] args)
     {
-        BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args
+        BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly)
+            .Run(args
 
 #if DEBUG
-            , new DebugInProcessConfig()
+                , new DebugInProcessConfig()
 #endif
-        );
+            );
     }
 }

ManagedCode.Communication.Benchmark/ResultCreationBenchmark.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Concurrent;
 using System.Globalization;
 using System.Net;
@@ -14,11 +13,11 @@ public class ResultCreationBenchmark
     private static readonly Exception TestException = new InvalidOperationException("Benchmark test");
     private static readonly Type ResultIntType = typeof(Result<int>);
     private static readonly ConcurrentDictionary<Type, MethodInfo> MethodCache = new();
-    
-    private MethodInfo _cachedMethod = null!;
-    private readonly object[] _exceptionArray = new object[1];
     private readonly Exception _exception = TestException;
-    
+    private readonly object[] _exceptionArray = new object[1];
+
+    private MethodInfo _cachedMethod = null!;
+
     [GlobalSetup]
     public void Setup()
     {
@@ -56,8 +55,7 @@ public object Reflection_CachedMethod_ReuseArray()
     [Benchmark]
     public object Reflection_ConcurrentDictionary()
     {
-        var method = MethodCache.GetOrAdd(ResultIntType, type => 
-            type.GetMethod(nameof(Result.Fail), [typeof(Exception), typeof(HttpStatusCode)])!);
+        var method = MethodCache.GetOrAdd(ResultIntType, type => type.GetMethod(nameof(Result.Fail), [typeof(Exception), typeof(HttpStatusCode)])!);
         return method.Invoke(null, [TestException, HttpStatusCode.InternalServerError])!;
     }
 
@@ -67,15 +65,13 @@ public object Activator_TryCreateInstance()
         var result = Activator.CreateInstance(ResultIntType);
         return result!;
     }
-    
+
     [Benchmark]
     public object Activator_WithPropertySet()
     {
-        var resultType = Activator.CreateInstance(ResultIntType, 
-            BindingFlags.NonPublic | BindingFlags.Instance, 
-            null, [TestException], 
+        var resultType = Activator.CreateInstance(ResultIntType, BindingFlags.NonPublic | BindingFlags.Instance, null, [TestException],
             CultureInfo.CurrentCulture);
-        
+
         return resultType!;
     }
 }

ManagedCode.Communication.Extensions/Constants/ProblemConstants.cs

@@ -1,74 +1,74 @@
 namespace ManagedCode.Communication.Extensions.Constants;
 
 /// <summary>
-/// Constants for Problem details to avoid string literals throughout the codebase.
+///     Constants for Problem details to avoid string literals throughout the codebase.
 /// </summary>
 public static class ProblemConstants
 {
     /// <summary>
-    /// Problem titles
+    ///     Problem titles
     /// </summary>
     public static class Titles
     {
         /// <summary>
-        /// Title for validation failure problems
+        ///     Title for validation failure problems
         /// </summary>
         public const string ValidationFailed = "Validation failed";
-        
+
         /// <summary>
-        /// Title for unexpected error problems
+        ///     Title for unexpected error problems
         /// </summary>
         public const string UnexpectedError = "An unexpected error occurred";
     }
-    
+
     /// <summary>
-    /// Problem extension keys
+    ///     Problem extension keys
     /// </summary>
     public static class ExtensionKeys
     {
         /// <summary>
-        /// Key for validation errors in problem extensions
+        ///     Key for validation errors in problem extensions
         /// </summary>
         public const string ValidationErrors = "validationErrors";
-        
+
         /// <summary>
-        /// Key for trace ID in problem extensions
+        ///     Key for trace ID in problem extensions
         /// </summary>
         public const string TraceId = "traceId";
-        
+
         /// <summary>
-        /// Key for hub method name in problem extensions
+        ///     Key for hub method name in problem extensions
         /// </summary>
         public const string HubMethod = "hubMethod";
-        
+
         /// <summary>
-        /// Key for hub type name in problem extensions
+        ///     Key for hub type name in problem extensions
         /// </summary>
         public const string HubType = "hubType";
-        
+
         /// <summary>
-        /// Key for inner exception in problem extensions
+        ///     Key for inner exception in problem extensions
         /// </summary>
         public const string InnerException = "innerException";
-        
+
         /// <summary>
-        /// Key for stack trace in problem extensions
+        ///     Key for stack trace in problem extensions
         /// </summary>
         public const string StackTrace = "stackTrace";
-        
+
         /// <summary>
-        /// Key for error type (enum type name) in problem extensions
+        ///     Key for error type (enum type name) in problem extensions
         /// </summary>
         public const string ErrorType = "errorType";
-        
+
         /// <summary>
-        /// Key for error code name (enum value name) in problem extensions
+        ///     Key for error code name (enum value name) in problem extensions
         /// </summary>
         public const string ErrorCodeName = "errorCodeName";
-        
+
         /// <summary>
-        /// Key for error code value (enum numeric value) in problem extensions
+        ///     Key for error code value (enum numeric value) in problem extensions
         /// </summary>
         public const string ErrorCodeValue = "errorCodeValue";
     }
-} 
+}

ManagedCode.Communication.Extensions/Extensions/CommunicationAppBuilderExtensions.cs

@@ -1,9 +1,5 @@
 using System;
 using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Mvc;
-using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Options;
-using ManagedCode.Communication.Extensions;
 
 namespace ManagedCode.Communication.Extensions.Extensions;
 
@@ -12,7 +8,9 @@ public static class CommunicationAppBuilderExtensions
     public static IApplicationBuilder UseCommunication(this IApplicationBuilder app)
     {
         if (app == null)
+        {
             throw new ArgumentNullException(nameof(app));
+        }
 
         return app;
     }

ManagedCode.Communication.Extensions/Extensions/ControllerExtensions.cs

@@ -5,14 +5,12 @@ namespace ManagedCode.Communication.Extensions.Extensions;
 
 public static class ControllerExtensions
 {
-    public static IActionResult ToActionResult<T>(this ManagedCode.Communication.Result<T> result)
+    public static IActionResult ToActionResult<T>(this Result<T> result)
     {
-        return result.IsSuccess
-            ? new OkObjectResult(result.Value)
-            : new BadRequestObjectResult(result.Problem?.Detail ?? "Operation failed");
+        return result.IsSuccess ? new OkObjectResult(result.Value) : new BadRequestObjectResult(result.Problem?.Detail ?? "Operation failed");
     }
 
-    public static Microsoft.AspNetCore.Http.IResult ToHttpResult<T>(this ManagedCode.Communication.Result<T> result)
+    public static Microsoft.AspNetCore.Http.IResult ToHttpResult<T>(this Result<T> result)
     {
         return result.IsSuccess ? Results.Ok(result.Value) : Results.BadRequest(result.Problem?.Detail ?? "Operation failed");
     }

ManagedCode.Communication.Extensions/Extensions/HubOptionsExtensions.cs

@@ -1,8 +1,7 @@
 using System;
+using ManagedCode.Communication.Extensions.Filters;
 using Microsoft.AspNetCore.SignalR;
 using Microsoft.Extensions.DependencyInjection;
-using ManagedCode.Communication.Extensions;
-using ManagedCode.Communication.Extensions.Filters;
 
 namespace ManagedCode.Communication.Extensions.Extensions;
 

ManagedCode.Communication.Extensions/Extensions/ServiceCollectionExtensions.cs

@@ -12,15 +12,14 @@
 
 namespace ManagedCode.Communication.Extensions.Extensions;
 
-
 public static class HostApplicationBuilderExtensions
 {
     public static IHostApplicationBuilder AddCommunication(this IHostApplicationBuilder builder)
     {
         builder.Services.AddCommunication(options => options.ShowErrorDetails = builder.Environment.IsDevelopment());
         return builder;
     }
-    
+
     public static IHostApplicationBuilder AddCommunication(this IHostApplicationBuilder builder, Action<CommunicationOptions> config)
     {
         builder.Services.AddCommunication(config);
@@ -30,16 +29,16 @@ public static IHostApplicationBuilder AddCommunication(this IHostApplicationBuil
 
 public static class ServiceCollectionExtensions
 {
-    
     public static IServiceCollection AddCommunication(this IServiceCollection services, Action<CommunicationOptions>? configure = null)
     {
         if (configure != null)
+        {
             services.Configure(configure);
+        }
 
         return services;
     }
-    
-   
+
 
     public static IServiceCollection AddDefaultProblemDetails(this IServiceCollection services)
     {
@@ -68,20 +67,20 @@ public static IServiceCollection AddCommunicationFilters(this IServiceCollection
 
         return services;
     }
-    
+
     public static MvcOptions AddCommunicationFilters(this MvcOptions options)
     {
         options.Filters.Add<CommunicationExceptionFilter>();
         options.Filters.Add<CommunicationModelValidationFilter>();
         options.Filters.Add<ResultToActionResultFilter>();
-        
+
         return options;
     }
-    
+
     public static HubOptions AddCommunicationFilters(this HubOptions options)
     {
         options.AddFilter<CommunicationHubExceptionFilter>();
-        
+
         return options;
     }
 }