vfs

Author: KSemenenko

AGENTS.md

@@ -23,7 +23,7 @@ Run `dotnet restore ManagedCode.Storage.slnx` before compiling. Use `dotnet buil
 Follow standard C# conventions: 4-space indentation, PascalCase types, camelCase locals, and suffix async APIs with `Async`. Nullability is enabled repository-wide, so annotate optional members and avoid the suppression operator unless justified. Match method names to existing patterns such as `DownloadFile_WhenFileExists_ReturnsSuccess`. Remove unused usings and let analyzers guide layout.
 
 ## Testing Guidelines
-Tests use xUnit and FluentAssertions; choose `[Fact]` for atomic cases and `[Theory]` for data-driven permutations. Place provider suites under `Tests/ManagedCode.Storage.Tests/Storages/` and reuse `.../Common/` helpers to spin up Testcontainers (Azurite, LocalStack, FakeGcsServer). Add fakes or harnesses mirroring `ManagedCode.Storage.TestFakes/` when introducing new providers. Always run `dotnet test` locally and exercise critical upload/download paths.
+Tests use xUnit and Shouldly; choose `[Fact]` for atomic cases and `[Theory]` for data-driven permutations. Place provider suites under `Tests/ManagedCode.Storage.Tests/Storages/` and reuse `.../Common/` helpers to spin up Testcontainers (Azurite, LocalStack, FakeGcsServer). Add fakes or harnesses mirroring `ManagedCode.Storage.TestFakes/` when introducing new providers. Always run `dotnet test` locally and exercise critical upload/download paths.
 
 ## Commit & Pull Request Guidelines
 Write commit subjects in the imperative mood (`add ftp retry policy`) and keep them provider-scoped. Group related edits in one commit and avoid WIP spam. Pull requests should summarize impact, list touched projects, reference issues, and note new configuration or secrets. Include the `dotnet` commands you ran and add logs when CI needs context.

CLAUDE.md

@@ -57,7 +57,7 @@ The library supports two connection modes:
 - Extension methods for DI registration (e.g., `AddAzureStorage`, `AddAWSStorageAsDefault`)
 
 ## Testing
-- Uses xUnit with FluentAssertions
+- Uses xUnit with Shouldly
 - Testcontainers for integration testing (Azurite, LocalStack, FakeGcsServer)
 - Test projects follow pattern: `Tests/ManagedCode.Storage.Tests/`
 - Includes test fakes in `ManagedCode.Storage.TestFakes`

…rage.VirtualFileSystem/Core/IVfsEntry.cs …orage.VirtualFileSystem/Core/IVfsNode.csManagedCode.Storage.VirtualFileSystem/Core/IVfsEntry.cs renamed to ManagedCode.Storage.VirtualFileSystem/Core/IVfsNode.cs ManagedCode.Storage.VirtualFileSystem/Core/IVfsEntry.cs renamed to ManagedCode.Storage.VirtualFileSystem/Core/IVfsNode.cs

@@ -7,51 +7,51 @@
 namespace ManagedCode.Storage.VirtualFileSystem.Core;
 
 /// <summary>
-/// Base interface for virtual file system entries
+/// Base interface for virtual file system nodes
 /// </summary>
-public interface IVfsEntry
+public interface IVfsNode
 {
     /// <summary>
-    /// Gets the path of this entry
+    /// Gets the path of this node
     /// </summary>
     VfsPath Path { get; }
 
     /// <summary>
-    /// Gets the name of this entry
+    /// Gets the name of this node
     /// </summary>
     string Name { get; }
 
     /// <summary>
-    /// Gets the type of this entry
+    /// Gets the type of this node
     /// </summary>
     VfsEntryType Type { get; }
 
     /// <summary>
-    /// Gets when this entry was created
+    /// Gets when this node was created
     /// </summary>
     DateTimeOffset CreatedOn { get; }
 
     /// <summary>
-    /// Gets when this entry was last modified
+    /// Gets when this node was last modified
     /// </summary>
     DateTimeOffset LastModified { get; }
 
     /// <summary>
-    /// Checks if this entry exists
+    /// Checks if this node exists
     /// </summary>
     /// <param name="cancellationToken">Cancellation token</param>
     /// <returns>True if the entry exists</returns>
     ValueTask<bool> ExistsAsync(CancellationToken cancellationToken = default);
 
     /// <summary>
-    /// Refreshes the entry information from storage
+    /// Refreshes the node information from storage
     /// </summary>
     /// <param name="cancellationToken">Cancellation token</param>
     /// <returns>Task representing the async operation</returns>
     Task RefreshAsync(CancellationToken cancellationToken = default);
 
     /// <summary>
-    /// Gets the parent directory of this entry
+    /// Gets the parent directory of this node
     /// </summary>
     /// <param name="cancellationToken">Cancellation token</param>
     /// <returns>The parent directory</returns>
@@ -134,4 +134,4 @@ public class DeleteDirectoryResult
     /// List of errors encountered during deletion
     /// </summary>
     public List<string> Errors { get; set; } = new();
-}
+}

ManagedCode.Storage.VirtualFileSystem/Core/IVirtualDirectory.cs

@@ -9,7 +9,7 @@ namespace ManagedCode.Storage.VirtualFileSystem.Core;
 /// <summary>
 /// Represents a directory in the virtual filesystem
 /// </summary>
-public interface IVirtualDirectory : IVfsEntry
+public interface IVirtualDirectory : IVfsNode
 {
     /// <summary>
     /// Lists files in this directory with pagination and pattern matching
@@ -47,7 +47,7 @@ IAsyncEnumerable<IVirtualDirectory> GetDirectoriesAsync(
     /// <param name="pageSize">Page size for pagination</param>
     /// <param name="cancellationToken">Cancellation token</param>
     /// <returns>Async enumerable of entries</returns>
-    IAsyncEnumerable<IVfsEntry> GetEntriesAsync(
+    IAsyncEnumerable<IVfsNode> GetEntriesAsync(
         SearchPattern? pattern = null,
         bool recursive = false,
         int pageSize = 100,

ManagedCode.Storage.VirtualFileSystem/Core/IVirtualFile.cs

@@ -11,7 +11,7 @@ namespace ManagedCode.Storage.VirtualFileSystem.Core;
 /// <summary>
 /// Represents a file in the virtual filesystem
 /// </summary>
-public interface IVirtualFile : IVfsEntry
+public interface IVirtualFile : IVfsNode
 {
     /// <summary>
     /// Gets the file size in bytes

ManagedCode.Storage.VirtualFileSystem/Core/IVirtualFileSystem.cs

@@ -121,7 +121,7 @@ Task CopyAsync(
     /// <param name="path">Entry path</param>
     /// <param name="cancellationToken">Cancellation token</param>
     /// <returns>Entry information or null if not found</returns>
-    ValueTask<IVfsEntry?> GetEntryAsync(VfsPath path, CancellationToken cancellationToken = default);
+    ValueTask<IVfsNode?> GetEntryAsync(VfsPath path, CancellationToken cancellationToken = default);
 
     /// <summary>
     /// Lists directory contents with pagination
@@ -130,7 +130,7 @@ Task CopyAsync(
     /// <param name="options">Listing options</param>
     /// <param name="cancellationToken">Cancellation token</param>
     /// <returns>Async enumerable of entries</returns>
-    IAsyncEnumerable<IVfsEntry> ListAsync(
+    IAsyncEnumerable<IVfsNode> ListAsync(
         VfsPath path,
         ListOptions? options = null,
         CancellationToken cancellationToken = default);

ManagedCode.Storage.VirtualFileSystem/Implementations/VirtualDirectory.cs

@@ -126,7 +126,7 @@ public async IAsyncEnumerable<IVirtualDirectory> GetDirectoriesAsync(
     }
 
     /// <inheritdoc />
-    public async IAsyncEnumerable<IVfsEntry> GetEntriesAsync(
+    public async IAsyncEnumerable<IVfsNode> GetEntriesAsync(
         SearchPattern? pattern = null,
         bool recursive = false,
         int pageSize = 100,
@@ -140,7 +140,7 @@ public async IAsyncEnumerable<IVfsEntry> GetEntriesAsync(
         }
     }
 
-    private async IAsyncEnumerable<IVfsEntry> GetEntriesInternalAsync(
+    private async IAsyncEnumerable<IVfsNode> GetEntriesInternalAsync(
         SearchPattern? pattern,
         bool recursive,
         int pageSize,

ManagedCode.Storage.VirtualFileSystem/Implementations/VirtualFileSystem.cs

@@ -469,7 +469,7 @@ private async Task CopyDirectoryAsync(
     }
 
     /// <inheritdoc />
-    public async ValueTask<IVfsEntry?> GetEntryAsync(VfsPath path, CancellationToken cancellationToken = default)
+    public async ValueTask<IVfsNode?> GetEntryAsync(VfsPath path, CancellationToken cancellationToken = default)
     {
         ThrowIfDisposed();
 
@@ -487,7 +487,7 @@ private async Task CopyDirectoryAsync(
     }
 
     /// <inheritdoc />
-    public async IAsyncEnumerable<IVfsEntry> ListAsync(
+    public async IAsyncEnumerable<IVfsNode> ListAsync(
         VfsPath path, 
         ListOptions? options = null, 
         [EnumeratorCancellation] CancellationToken cancellationToken = default)

Tests/ManagedCode.Storage.Tests/AspNetTests/Abstracts/BaseDownloadControllerTests.cs

@@ -1,7 +1,7 @@
 using System;
 using System.Net;
 using System.Threading.Tasks;
-using FluentAssertions;
+using Shouldly;
 using ManagedCode.Storage.Core.Helpers;
 using ManagedCode.Storage.Core.Models;
 using ManagedCode.Storage.Tests.Common;
@@ -35,20 +35,18 @@ public async Task DownloadFile_WhenFileExists_SaveToTempStorage_ReturnSuccess()
         var fileCRC = Crc32Helper.CalculateFileCrc(localFile.FilePath); // Calculate CRC from file path
         await using var uploadStream = localFile.FileStream; // Get stream once
         var uploadFileBlob = await storageClient.UploadFile(uploadStream, _uploadEndpoint, contentName);
-        uploadFileBlob.IsSuccess.Should().BeTrue();
+        uploadFileBlob.IsSuccess.ShouldBeTrue();
         var uploadedMetadata = uploadFileBlob.Value ?? throw new InvalidOperationException("Upload did not return metadata");
 
         // Act
         var downloadedFileResult = await storageClient.DownloadFile(uploadedMetadata.FullName, _downloadEndpoint);
 
         // Assert
         downloadedFileResult.IsSuccess
-            .Should()
-            .BeTrue();
+            .ShouldBeTrue();
         var downloadedLocal = downloadedFileResult.Value ?? throw new InvalidOperationException("Download result does not contain a file");
         var downloadedFileCRC = Crc32Helper.CalculateFileCrc(downloadedLocal.FilePath);
-        downloadedFileCRC.Should()
-            .Be(fileCRC);
+        downloadedFileCRC.ShouldBe(fileCRC);
     }
 
     [Fact]
@@ -63,17 +61,17 @@ public async Task DownloadFileAsBytes_WhenFileExists_ReturnSuccess()
         var fileCRC = Crc32Helper.CalculateFileCrc(localFile.FilePath); // Calculate CRC from file path
         await using var uploadStream = localFile.FileStream; // Get stream once
         var uploadFileBlob = await storageClient.UploadFile(uploadStream, _uploadEndpoint, contentName);
-        uploadFileBlob.IsSuccess.Should().BeTrue();
+        uploadFileBlob.IsSuccess.ShouldBeTrue();
         var uploadedMetadata = uploadFileBlob.Value ?? throw new InvalidOperationException("Upload did not return metadata");
 
         // Act
         var downloadedFileResult = await storageClient.DownloadFile(uploadedMetadata.FullName, _downloadBytesEndpoint);
 
         // Assert
-        downloadedFileResult.IsSuccess.Should().BeTrue();
+        downloadedFileResult.IsSuccess.ShouldBeTrue();
         var downloadedLocal = downloadedFileResult.Value ?? throw new InvalidOperationException("Download result does not contain a file");
         var downloadedFileCRC = Crc32Helper.CalculateFileCrc(downloadedLocal.FilePath);
-        downloadedFileCRC.Should().Be(fileCRC);
+        downloadedFileCRC.ShouldBe(fileCRC);
     }
 
     [Fact]
@@ -88,11 +86,9 @@ public async Task DownloadFile_WhenFileDoNotExist_ReturnFail()
 
         // Assert
         downloadedFileResult.IsFailed
-            .Should()
-            .BeTrue();
+            .ShouldBeTrue();
         downloadedFileResult.Problem
             ?.StatusCode
-            .Should()
-            .Be((int)HttpStatusCode.InternalServerError);
+            .ShouldBe((int)HttpStatusCode.InternalServerError);
     }
 }

Tests/ManagedCode.Storage.Tests/AspNetTests/Abstracts/BaseStreamControllerTests.cs

@@ -2,7 +2,7 @@
 using System.IO;
 using System.Net;
 using System.Threading.Tasks;
-using FluentAssertions;
+using Shouldly;
 using ManagedCode.Storage.Core.Helpers;
 using ManagedCode.Storage.Core.Models;
 using ManagedCode.Storage.Tests.Common;
@@ -34,25 +34,23 @@ public async Task StreamFile_WhenFileExists_SaveToTempStorage_ReturnSuccess()
         var fileCRC = Crc32Helper.CalculateFileCrc(localFile.FilePath); // Calculate CRC from file path
         await using var uploadStream = localFile.FileStream; // Get stream once
         var uploadFileBlob = await storageClient.UploadFile(uploadStream, _uploadEndpoint, contentName);
-        uploadFileBlob.IsSuccess.Should().BeTrue();
+        uploadFileBlob.IsSuccess.ShouldBeTrue();
         var uploadedMetadata = uploadFileBlob.Value ?? throw new InvalidOperationException("Upload did not return metadata");
 
         // Act
         var streamFileResult = await storageClient.GetFileStream(uploadedMetadata.FullName, _streamEndpoint);
 
         // Assert
         streamFileResult.IsSuccess
-            .Should()
-            .BeTrue();
+            .ShouldBeTrue();
         var streamedValue = streamFileResult.Value ?? throw new InvalidOperationException("Stream result does not contain a stream");
 
         await using var stream = streamedValue;
         await using var newLocalFile = await LocalFile.FromStreamAsync(stream, Path.GetTempPath(), Guid.NewGuid()
             .ToString("N") + extension);
 
         var streamedFileCRC = Crc32Helper.CalculateFileCrc(newLocalFile.FilePath);
-        streamedFileCRC.Should()
-            .Be(fileCRC);
+        streamedFileCRC.ShouldBe(fileCRC);
     }
 
     [Fact]
@@ -67,11 +65,9 @@ public async Task StreamFile_WhenFileDoNotExist_ReturnFail()
 
         // Assert
         streamFileResult.IsFailed
-            .Should()
-            .BeTrue();
+            .ShouldBeTrue();
         streamFileResult.Problem
             ?.StatusCode
-            .Should()
-            .Be((int)HttpStatusCode.InternalServerError);
+            .ShouldBe((int)HttpStatusCode.InternalServerError);
     }
 }