Skip to content

Commit 23ac278

Browse files
committed
Minimum Python 3.8, jupyter-server 2, jupyterlab 4
1 parent 4b0b44b commit 23ac278

File tree

4 files changed

+8
-20
lines changed

4 files changed

+8
-20
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,9 @@ jobs:
7474
fail-fast: false
7575
matrix:
7676
include:
77-
- python-version: '3.7'
78-
jupyterlab-major: '3'
79-
- python-version: '3.10'
77+
- python-version: '3.8'
8078
jupyterlab-major: '4'
81-
- python-version: '3.12'
79+
- python-version: '3.13'
8280
jupyterlab-major: '4'
8381
runs-on: ubuntu-24.04
8482
# Includes geckdriver and firefox

dev-requirements-jl3.old

Lines changed: 0 additions & 4 deletions
This file was deleted.

jupyter_offlinenotebook/__init__.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ class OfflineNotebookConfig(Configurable):
102102
).tag(config=True)
103103

104104

105-
def _jupyter_server_extension_paths():
105+
def _jupyter_server_extension_points():
106106
"""
107107
Jupyter server extension
108108
"""
@@ -123,7 +123,7 @@ def _jupyter_nbextension_paths():
123123
]
124124

125125

126-
def load_jupyter_server_extension(nbapp):
126+
def _load_jupyter_server_extension(nbapp):
127127
"""
128128
Called during notebook start
129129
"""
@@ -134,9 +134,3 @@ def load_jupyter_server_extension(nbapp):
134134
nbapp.web_app.settings["base_url"], "/offlinenotebook/config"
135135
)
136136
nbapp.web_app.add_handlers(".*", [(route_pattern, OfflineNotebookHandler)])
137-
138-
139-
# Add compatibility with jupyter-server
140-
# https://jupyter-server.readthedocs.io/en/latest/developers/extensions.html#migrating-an-extension-to-use-jupyter-serverjupyter_server
141-
_load_jupyter_server_extension = load_jupyter_server_extension
142-
_jupyter_server_extension_points = _jupyter_server_extension_paths

setup.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def get_version():
2929
jstargets = [
3030
# notebook
3131
os.path.join(HERE, name, "static", "jslib", "offlinenotebook.js"),
32-
# jupyterlab 3 bundled extension
32+
# jupyterlab 4 bundled extension
3333
os.path.join(HERE, name, "static", "lab", "package.json"),
3434
]
3535

@@ -91,8 +91,8 @@ def get_version():
9191
long_description=open("README.md").read(),
9292
long_description_content_type="text/markdown",
9393
cmdclass=cmdclass,
94-
install_requires=["jupyter-server"],
95-
python_requires=">=3.7",
94+
install_requires=["jupyter-server>=2"],
95+
python_requires=">=3.8",
9696
zip_safe=False,
9797
include_package_data=True,
9898
platforms="Linux, Mac OS X, Windows",
@@ -101,12 +101,12 @@ def get_version():
101101
"License :: OSI Approved :: BSD License",
102102
"Programming Language :: Python",
103103
"Programming Language :: Python :: 3",
104-
"Programming Language :: Python :: 3.7",
105104
"Programming Language :: Python :: 3.8",
106105
"Programming Language :: Python :: 3.9",
107106
"Programming Language :: Python :: 3.10",
108107
"Programming Language :: Python :: 3.11",
109108
"Programming Language :: Python :: 3.12",
109+
"Programming Language :: Python :: 3.13",
110110
"Framework :: Jupyter",
111111
],
112112
)

0 commit comments

Comments
 (0)