Skip to content

Commit bb0ee98

Browse files
committed
Replace nbclassic with notebook 7
1 parent ccd5faf commit bb0ee98

File tree

4 files changed

+1
-29
lines changed

4 files changed

+1
-29
lines changed

dev-requirements-jl4.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
-r dev-requirements.txt
22
jupyterlab==4.3.8
33
jupyter_server==2.14.2
4+
notebook==7.3.3

dev-requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
build==1.2.2.post1
22
jupyter_packaging==0.12.3
33
flaky==3.8.1
4-
nbclassic==1.2.0
54
pre-commit==3.5.0
65
pytest==8.3.5
76
selenium==4.11.2

jupyter_offlinenotebook/__init__.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -109,20 +109,6 @@ def _jupyter_server_extension_points():
109109
return [{"module": "jupyter_offlinenotebook"}]
110110

111111

112-
def _jupyter_nbextension_paths():
113-
"""
114-
Jupyter notebook extension
115-
"""
116-
return [
117-
dict(
118-
section="notebook",
119-
src="./static",
120-
dest="jupyter-offlinenotebook",
121-
require="jupyter-offlinenotebook/main",
122-
)
123-
]
124-
125-
126112
def _load_jupyter_server_extension(nbapp):
127113
"""
128114
Called during notebook start

setup.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ def get_version():
2727

2828
# Representative files that should exist after a successful build
2929
jstargets = [
30-
# notebook
31-
os.path.join(HERE, name, "static", "jslib", "offlinenotebook.js"),
3230
# jupyterlab 4 bundled extension
3331
os.path.join(HERE, name, "static", "lab", "package.json"),
3432
]
@@ -40,23 +38,11 @@ def get_version():
4038
# }
4139

4240
data_files_spec = [
43-
(f"share/jupyter/nbextensions/{jsname}", f"{name}/static", "*.*"),
44-
(f"share/jupyter/nbextensions/{jsname}/jslib", f"{name}/static/jslib", "*.*"),
45-
(
46-
"etc/jupyter/jupyter_notebook_config.d",
47-
f"{name}/etc",
48-
"offlinenotebook_nbserverextension.json",
49-
),
5041
(
5142
"etc/jupyter/jupyter_server_config.d",
5243
f"{name}/etc",
5344
"offlinenotebook_jpserverextension.json",
5445
),
55-
(
56-
"etc/jupyter/nbconfig/notebook.d",
57-
f"{name}/etc",
58-
"offlinenotebook_nbextension.json",
59-
),
6046
# TODO: Why is 'jupyter labextension build' putting the files under
6147
# static/lab/static instead of static/lab ?
6248
(f"share/jupyter/labextensions/{jsname}", f"{name}/static/lab", "*.*"),

0 commit comments

Comments
 (0)