Skip to content

Commit d97470c

Browse files
authored
Merge pull request #662 from manics/update
Switch to NPM trusted publisher
2 parents ff6dabd + 6780d22 commit d97470c

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

.github/workflows/build.yml

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
cache: pip
3232
cache-dependency-path: 'dev-requirements*'
3333

34-
- uses: actions/setup-node@v5
34+
- uses: actions/setup-node@v6
3535
with:
3636
node-version: '24.x'
3737
cache: yarn
@@ -54,13 +54,13 @@ jobs:
5454
mkdir jsdist
5555
jlpm pack --filename jsdist/jupyter-offlinenotebook-jlpmpack.tgz
5656
57-
- uses: actions/upload-artifact@v4
57+
- uses: actions/upload-artifact@v5
5858
with:
5959
name: dist
6060
path: dist
6161
if-no-files-found: error
6262

63-
- uses: actions/upload-artifact@v4
63+
- uses: actions/upload-artifact@v5
6464
with:
6565
name: jsdist
6666
path: jsdist
@@ -91,13 +91,13 @@ jobs:
9191
cache: pip
9292
cache-dependency-path: 'dev-requirements*'
9393

94-
- uses: actions/setup-node@v5
94+
- uses: actions/setup-node@v6
9595
with:
9696
node-version: '24.x'
9797
cache: yarn
9898

9999
- name: Download artifacts from build
100-
uses: actions/download-artifact@v4
100+
uses: actions/download-artifact@v6
101101

102102
- name: Install dependencies
103103
run: python -mpip install -r dev-requirements-jl${{ matrix.jupyterlab-major }}.*
@@ -123,7 +123,7 @@ jobs:
123123
id-token: write
124124
steps:
125125
- name: Download artifacts from build
126-
uses: actions/download-artifact@v5
126+
uses: actions/download-artifact@v6
127127
with:
128128
name: dist
129129
path: dist
@@ -139,9 +139,11 @@ jobs:
139139
- pre-commit
140140
- test
141141
runs-on: ubuntu-24.04
142+
permissions:
143+
id-token: write
142144
steps:
143145
# Setup .npmrc file to publish to npm
144-
- uses: actions/setup-node@v5
146+
- uses: actions/setup-node@v6
145147
with:
146148
node-version: '24.x'
147149
registry-url: https://registry.npmjs.org
@@ -156,14 +158,13 @@ jobs:
156158
echo "NPM_TAG=$NPM_TAG" >> "$GITHUB_ENV"
157159
158160
- name: Download artifacts from build
159-
uses: actions/download-artifact@v5
161+
uses: actions/download-artifact@v6
160162
with:
161163
name: jsdist
162164
path: jsdist
163165

164166
- run: npm publish --tag "$NPM_TAG" --dry-run ./jsdist/jupyter-offlinenotebook-jlpmpack.tgz
165167

168+
# Uses trusted publisher
166169
- run: npm publish --tag "$NPM_TAG" ./jsdist/jupyter-offlinenotebook-jlpmpack.tgz
167170
if: startsWith(github.ref, 'refs/tags')
168-
env:
169-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

dev-requirements-jl4.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
-r dev-requirements.txt
2-
jupyterlab==4.4.9
2+
jupyterlab==4.4.10
33
jupyter_server==2.17.0
44
notebook==7.4.7

dev-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ flaky==3.8.1
44
pre-commit==4.3.0
55
pytest==8.4.2
66
# selenium==4.11.2
7-
selenium==4.36.0
7+
selenium==4.38.0
88
traitlets==5.14.3
99
wheel==0.45.1
1010
# jupyterlab and jupyter_server are installed separately so we can test multiple versions

0 commit comments

Comments
 (0)