fix(op-revm): reset BVM_ETH to cold after deposit mint to match op-geth

Deposit minting writes BVM_ETH via the journal (load_account/sload/sstore), which warms the BVM_ETH account + storage slots for the subsequent EVM execution. op-geth mints via StateDB.SetState(), which never touches the EVM access list, so it stays cold. This warm/cold divergence was patched over with a static BVM_ETH_MINT_GAS_COMPENSATION (4500) gated on `!tx.input().is_empty()`.

That heuristic mis-fired for non-empty-calldata deposits to EOAs (hoodi-qa2 block 59294: reth 25628 vs geth 21320 -> receiptsRoot/blockHash fork), and over/under-compensated other access paths since the real cold-access cost is dynamic.

Root-cause fix: after process_eth_deposit, reset BVM_ETH (account + touched storage slots) back to EIP-2929 cold via a new JournalColdExt, so the EVM observes it exactly like op-geth (cold then falls back to the tx access list / to / precompiles). The static compensation constant and the refund-stage hack are removed entirely.

Scope: op-revm only, no core revm changes. The JournalColdExt bound is carried by OpContextTr so no per-call-site threading is needed.

Tests: process_eth_deposit_leaves_bvm_eth_cold (mechanism); deposit_to_eoa_with_calldata_no_compensation_matches_geth (block 59294 replay asserts 21320, not 25628); existing mainnet fixture 89718944 (L2StandardBridge) still passes. cargo test -p op-revm: all green.

Author: asdv23

crates/op-revm/src/api/exec.rs

@@ -1,7 +1,7 @@
 //! Implementation of the [`ExecuteEvm`] trait for the [`OpEvm`].
 use crate::{
-    evm::OpEvm, handler::OpHandler, transaction::OpTxTr, L1BlockInfo, OpHaltReason, OpSpecId,
-    OpTransactionError,
+    evm::OpEvm, handler::OpHandler, transaction::bvm_eth::JournalColdExt, transaction::OpTxTr,
+    L1BlockInfo, OpHaltReason, OpSpecId, OpTransactionError,
 };
 use revm::{
     context::{result::ExecResultAndState, ContextSetters},
@@ -25,7 +25,7 @@ use revm::{
 /// Type alias for Optimism context
 pub trait OpContextTr:
     ContextTr<
-    Journal: JournalTr<State = EvmState>,
+    Journal: JournalTr<State = EvmState> + JournalColdExt,
     Tx: OpTxTr,
     Cfg: Cfg<Spec = OpSpecId>,
     Chain = L1BlockInfo,
@@ -35,7 +35,7 @@ pub trait OpContextTr:
 
 impl<T> OpContextTr for T where
     T: ContextTr<
-        Journal: JournalTr<State = EvmState>,
+        Journal: JournalTr<State = EvmState> + JournalColdExt,
         Tx: OpTxTr,
         Cfg: Cfg<Spec = OpSpecId>,
         Chain = L1BlockInfo,

crates/op-revm/src/constants.rs

@@ -74,16 +74,3 @@ pub const GAS_ORACLE_CONTRACT: Address = address!("42000000000000000000000000000
 
 /// The address of the sequencer fee wallet, which is block coinbase.
 pub const SEQUENCER_FEE_VAULT_ADDRESS: Address = address!("4200000000000000000000000000000000000011");
-
-/// Gas compensation for BVM_ETH mint operations to align with go-ethereum behavior.
-///
-/// This constant compensates for the gas calculation difference between REVM and go-ethereum
-/// when handling BVM_ETH state operations. The value of 4500 is derived from EIP-2929 access
-/// list gas costs:
-/// - Account access difference: 2500 (cold: 2600, warm: 100)
-/// - Storage slot access difference: 2000 (cold: 2100, warm: 100)
-///
-/// REVM marks BVM_ETH account and storage slots as warm during mint/transfer operations,
-/// while go-ethereum keeps them cold. When subsequent EVM execution accesses BVM_ETH,
-/// this compensation ensures consistent gas consumption.
-pub const BVM_ETH_MINT_GAS_COMPENSATION: u64 = 4500;