Merge pull request #27 from mantle-xyz/fix/op-revm-bvm-eth-deposit-cold-reset

fix(op-revm): reset BVM_ETH to cold after deposit mint to match op-geth

Author: asdv23

crates/op-revm/src/api/exec.rs

@@ -1,7 +1,7 @@
 //! Implementation of the [`ExecuteEvm`] trait for the [`OpEvm`].
 use crate::{
-    evm::OpEvm, handler::OpHandler, transaction::OpTxTr, L1BlockInfo, OpHaltReason, OpSpecId,
-    OpTransactionError,
+    evm::OpEvm, handler::OpHandler, transaction::bvm_eth::JournalColdExt, transaction::OpTxTr,
+    L1BlockInfo, OpHaltReason, OpSpecId, OpTransactionError,
 };
 use revm::{
     context::{result::ExecResultAndState, ContextSetters},
@@ -25,7 +25,7 @@ use revm::{
 /// Type alias for Optimism context
 pub trait OpContextTr:
     ContextTr<
-    Journal: JournalTr<State = EvmState>,
+    Journal: JournalTr<State = EvmState> + JournalColdExt,
     Tx: OpTxTr,
     Cfg: Cfg<Spec = OpSpecId>,
     Chain = L1BlockInfo,
@@ -35,7 +35,7 @@ pub trait OpContextTr:
 
 impl<T> OpContextTr for T where
     T: ContextTr<
-        Journal: JournalTr<State = EvmState>,
+        Journal: JournalTr<State = EvmState> + JournalColdExt,
         Tx: OpTxTr,
         Cfg: Cfg<Spec = OpSpecId>,
         Chain = L1BlockInfo,

crates/op-revm/src/constants.rs

@@ -74,16 +74,3 @@ pub const GAS_ORACLE_CONTRACT: Address = address!("42000000000000000000000000000
 
 /// The address of the sequencer fee wallet, which is block coinbase.
 pub const SEQUENCER_FEE_VAULT_ADDRESS: Address = address!("4200000000000000000000000000000000000011");
-
-/// Gas compensation for BVM_ETH mint operations to align with go-ethereum behavior.
-///
-/// This constant compensates for the gas calculation difference between REVM and go-ethereum
-/// when handling BVM_ETH state operations. The value of 4500 is derived from EIP-2929 access
-/// list gas costs:
-/// - Account access difference: 2500 (cold: 2600, warm: 100)
-/// - Storage slot access difference: 2000 (cold: 2100, warm: 100)
-///
-/// REVM marks BVM_ETH account and storage slots as warm during mint/transfer operations,
-/// while go-ethereum keeps them cold. When subsequent EVM execution accesses BVM_ETH,
-/// this compensation ensures consistent gas consumption.
-pub const BVM_ETH_MINT_GAS_COMPENSATION: u64 = 4500;