refactor: Remove dependency built #153
mantonoAnnotations
6 warnings
|
called `map(..).flatten()` on `Iterator`:
src/main.rs#L72
warning: called `map(..).flatten()` on `Iterator`
--> src/main.rs:72:10
|
72 | .map(|path: &PathBuf| create_walker(cfg, path))
| __________^
73 | | .flatten()
| |__________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|path: &PathBuf| create_walker(cfg, path))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#map_flatten
|
|
useless conversion to the same type: `std::iter::Map<std::slice::Iter<'_, std::path::PathBuf>, {closure@src/main.rs:52:14: 52:30}>`:
src/main.rs#L49
warning: useless conversion to the same type: `std::iter::Map<std::slice::Iter<'_, std::path::PathBuf>, {closure@src/main.rs:52:14: 52:30}>`
--> src/main.rs:49:32
|
49 | let files: Vec<DirEntry> = cfg
| ________________________________^
50 | | .paths()
51 | | .iter()
52 | | .map(|path: &PathBuf| create_walker(cfg, path))
53 | | .into_iter()
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
|
49 ~ let files: Vec<DirEntry> = cfg
50 + .paths()
51 + .iter()
52 + .map(|path: &PathBuf| create_walker(cfg, path))
|
|
|
called `map(..).flatten()` on `Option`:
src/parse.rs#L11
warning: called `map(..).flatten()` on `Option`
--> src/parse.rs:11:45
|
11 | let chr: Option<char> = CHR.find(input).map(|i| i.as_str().chars().next()).flatten();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|i| i.as_str().chars().next())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#map_flatten
= note: `#[warn(clippy::map_flatten)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/cfg.rs#L154
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/cfg.rs:154:40
|
154 | .filter(|p| Config::filter(&p))
| ^^ help: change this to: `p`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
methods `with_path` and `with_limit` are never used:
src/cfg.rs#L123
warning: methods `with_path` and `with_limit` are never used
--> src/cfg.rs:123:12
|
122 | impl Config {
| ----------- methods in this implementation
123 | pub fn with_path<T: Into<PathBuf>>(mut self, path: T) -> Self {
| ^^^^^^^^^
...
128 | pub fn with_limit(mut self, limit: Option<usize>) -> Self {
| ^^^^^^^^^^
|
|
struct `Verbosity` is never constructed:
src/cfg.rs#L106
warning: struct `Verbosity` is never constructed
--> src/cfg.rs:106:8
|
106 | struct Verbosity(u8);
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
|