Drop Intl.NumberFormat support check in the ScaleControl

GitOrigin-RevId: f950badf241d8937390a3b6f9b5d24790c4df86f

Author: stepankuzmin

src/ui/control/scale_control.ts

@@ -44,16 +44,11 @@ class ScaleControl implements IControl {
     _map: Map;
     _container: HTMLElement;
     _language?: string | string[];
-    _isNumberFormatSupported: boolean;
     options: ScaleControlOptions;
 
     constructor(options: ScaleControlOptions = {}) {
         this.options = Object.assign({}, defaultOptions, options);
 
-        // Some old browsers (e.g., Safari < 14.1) don't support the "unit" style in NumberFormat.
-        // This is a workaround to display the scale without proper internationalization support.
-        this._isNumberFormatSupported = isNumberFormatSupported();
-
         bindAll([
             '_update',
             '_setScale',
@@ -104,7 +99,7 @@ class ScaleControl implements IControl {
             const distance = getRoundNum(maxDistance);
             const ratio = distance / maxDistance;
 
-            if (this._isNumberFormatSupported && unit !== 'nautical-mile') {
+            if (unit !== 'nautical-mile') {
                 this._container.innerHTML = new Intl.NumberFormat(this._language, {style: 'unit', unitDisplay: 'short', unit}).format(distance);
             } else {
                 this._container.innerHTML = `${distance}&nbsp;${unitAbbr[unit]}`;
@@ -150,15 +145,6 @@ class ScaleControl implements IControl {
 
 export default ScaleControl;
 
-function isNumberFormatSupported() {
-    try {
-        new Intl.NumberFormat('en', {style: 'unit', unitDisplay: 'short', unit: 'meter'});
-        return true;
-    } catch (_: unknown) {
-        return false;
-    }
-}
-
 function getDecimalRoundNum(d: number) {
     const multiplier = Math.pow(10, Math.ceil(-Math.log(d) / Math.LN10));
     return Math.round(d * multiplier) / multiplier;

test/unit/ui/control/scale.test.ts

@@ -102,26 +102,3 @@ test('ScaleControl should support different projections', () => {
         expect(contents).not.toMatch(/NaN|undefined/);
     }
 });
-
-test('ScaleControl should work in legacy safari', () => {
-    const realNumberFormat = Intl.NumberFormat;
-    Intl.NumberFormat = function (arg, options) {
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-        if (options && options.style === 'unit') {
-            throw new Error('not supported');
-        }
-        return realNumberFormat.call(Intl, arg, options);
-    };
-    try {
-        const map = createMap();
-        const scale = new ScaleControl();
-        const selector = '.mapboxgl-ctrl-bottom-left .mapboxgl-ctrl-scale';
-        map.addControl(scale);
-        map._domRenderTaskQueue.run();
-
-        const contents = map.getContainer().querySelector(selector).innerHTML;
-        expect(contents).toMatch(/km/);
-    } finally {
-        Intl.NumberFormat = realNumberFormat;
-    }
-});