Skip to content

Commit ace57f4

Browse files
underootgithub-actions[bot]
authored andcommitted
Follow-ups after Vitest 4 upgrade (internal-7845)
GitOrigin-RevId: 1a7b11bf6e75d6b00557f541cdb59aa95e74aaaa
1 parent a7d9e66 commit ace57f4

7 files changed

Lines changed: 5 additions & 24 deletions

File tree

package-lock.json

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@
6565
"@types/offscreencanvas": "^2019.7.3",
6666
"@typescript-eslint/eslint-plugin": "^8.48.1",
6767
"@typescript-eslint/parser": "^8.48.1",
68-
"@vitest/browser": "^4.0.6",
6968
"@vitest/browser-playwright": "^4.0.6",
7069
"@vitest/ui": "^4.0.6",
7170
"address": "^2.0.3",

test/integration/query-tests/index.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// eslint-disable-next-line import-x/extensions
2-
import {server} from '@vitest/browser/context';
2+
import {server} from 'vitest/browser';
33
import ignoresAll from '../../ignores/all.js';
44
import ignoreWindowsChrome from '../../ignores/windows-chrome.js';
55
import ignoreMacChrome from '../../ignores/mac-chrome.js';

test/integration/render-tests/index.test.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// eslint-disable-next-line import-x/extensions
2-
import {server} from '@vitest/browser/context';
1+
import {server} from 'vitest/browser';
32
import {test, assert, afterEach, afterAll} from 'vitest';
43
import ignoresAll from '../../ignores/all.js';
54
import ignoreWindowsChrome from '../../ignores/windows-chrome.js';
@@ -14,8 +13,6 @@ import {getStatsHTML, updateHTML} from '../../util/html_generator';
1413
import {mapboxgl} from '../lib/mapboxgl.js';
1514
import {sendFragment} from '../lib/utils';
1615

17-
const errors = [];
18-
1916
function getEnvironmentParams() {
2017
let timeout = 30000;
2118
if (import.meta.env.VITE_CI === 'true') {
@@ -100,7 +97,6 @@ type TestMetadata = {
10097
name: string;
10198
minDiff: number;
10299
status: string;
103-
errors: Error[];
104100
actual?: string;
105101
expected?: string;
106102
expectedPath?: string;
@@ -109,7 +105,7 @@ type TestMetadata = {
109105

110106
let reportFragment: string | undefined;
111107

112-
const getTest = (renderTestName) => async () => {
108+
const getTest = (renderTestName: string) => async () => {
113109
let errorMessage: string | undefined;
114110
try {
115111
const renderTest = integrationTests[renderTestName];
@@ -136,7 +132,6 @@ const getTest = (renderTestName) => async () => {
136132
name: renderTestName,
137133
minDiff: Math.round(100000 * minDiff) / 100000,
138134
status: pass ? 'passed' : 'failed',
139-
errors
140135
};
141136

142137
if (minDiffImage && expectedIndex !== -1 && (import.meta.env.VITE_CI === 'false' || !pass)) {
@@ -169,7 +164,6 @@ const getTest = (renderTestName) => async () => {
169164
name: renderTestName,
170165
status: 'failed',
171166
error,
172-
errors: []
173167
});
174168

175169
errorMessage = `Render test ${renderTestName} failed with error: ${error}`;

test/usvg/usvg.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import Pbf from 'pbf';
2-
import {server, page} from '@vitest/browser/context';
2+
import {server, page} from 'vitest/browser';
33
import pixelmatch from 'pixelmatch';
44
import {describe, test, expect, afterEach, afterAll, onTestFailed, onTestFinished} from 'vitest';
55
import {readIconSet} from '../../src/data/usvg/usvg_pb_decoder';

test/util/html_generator.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,6 @@ const generateResultHTML = template(`
3434
<pre><%- r.error.stack %></pre>
3535
</p>
3636
<% } %>
37-
<% if (r.errors && r.errors.length !== 0) { %>
38-
<p style="color: red">
39-
<strong>Errors:</strong>
40-
<dl>
41-
<% r.errors.forEach(function(error) { %>
42-
<dt><%- error.message %></dt>
43-
<dd><pre><%- error.stack %></pre></dd>
44-
<% }); %>
45-
</dl>
46-
</p>
47-
<% } %>
4837
</div>
4938
</div>
5039
`);

test/util/read_array_buffer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {server} from '@vitest/browser/context';
1+
import {server} from 'vitest/browser';
22

33
export async function readArrayBuffer(path: string) {
44
const data = await server.commands.readFile(path, 'binary');

0 commit comments

Comments
 (0)