Symbol UBO uniforms update with 0-duration transition

GitOrigin-RevId: 3157370ab0a2c027ebbfbeab99fedd43b091a520

Author: underoot

src/data/bucket/symbol_property_binder_ubo.ts

@@ -170,6 +170,11 @@ export class SymbolPropertyBinderUBO {
     cachedConstantUniforms: ConstantUniformValues | null;
     cachedConstantRenderZoom: number | null;
     cachedConstantBrightness: number | null | undefined;
+    // Identity of the layer.paint object the cache was computed from. layer.recalculate() produces a
+    // fresh paint object on every Style.update() a paint/config change triggers, so an identity change
+    // means constant paint values may have changed. Guards against a stale cached color when a paint
+    // update does not come with a live transition (e.g. root transition {duration: 0}); see #13702.
+    cachedConstantPaint: object | null;
 
     // Tracks current active appearance per vtFeatureIndex (main-thread only, excluded from serialization).
     activeAppearanceByVtIndex?: Map<number, SymbolAppearance | null>;
@@ -214,6 +219,7 @@ export class SymbolPropertyBinderUBO {
         this.cachedConstantUniforms = null;
         this.cachedConstantRenderZoom = null;
         this.cachedConstantBrightness = undefined;
+        this.cachedConstantPaint = null;
 
         this.activeAppearanceByVtIndex = null;
 
@@ -1016,9 +1022,13 @@ export class SymbolPropertyBinderUBO {
 
         // Cache hit: zoom factors depend on renderZoom too, so we must also invalidate on
         // renderZoom change when any property is zoom-dependent.
+        // cachedConstantPaint guards against stale constant colors when a paint update arrives without
+        // a live transition (e.g. root transition {duration: 0}); layer.recalculate() produces a fresh
+        // layer.paint object whenever a paint/config change is applied.
         // Truthy check (not !== null) because the field may be undefined after worker→main
         // transfer (constructor is not called during deserialization, omitted fields stay undefined).
         if (this.cachedConstantUniforms &&
+                this.cachedConstantPaint === this.layer.paint &&
                 this.cachedConstantBrightness === brightness &&
                 ((!hasCameraExpr && !hasZoomDep) || this.cachedConstantRenderZoom === renderZoom)) {
             return this.cachedConstantUniforms;
@@ -1092,6 +1102,7 @@ export class SymbolPropertyBinderUBO {
         this.cachedConstantUniforms = result;
         this.cachedConstantRenderZoom = renderZoom;
         this.cachedConstantBrightness = brightness;
+        this.cachedConstantPaint = this.layer.paint;
         return result;
     }
 
@@ -1144,4 +1155,4 @@ export class SymbolPropertyBinderUBO {
 // 'layer' is omitted because SymbolStyleLayer is not serializable. It must be re-assigned on
 // the main thread before any main-thread method (getConstantUniformValues, bind, etc.) is called.
 // See draw_symbol.ts: `buffers.uboBinder.layer = layer` before drawSymbolElements().
-register(SymbolPropertyBinderUBO, 'SymbolPropertyBinderUBO', {omit: ['layer', 'cachedConstantUniforms', 'cachedConstantRenderZoom', 'cachedConstantBrightness', 'activeAppearanceByVtIndex', 'featureVertexRangesFromId', 'featureVertexRangesFromVtIndex']});
+register(SymbolPropertyBinderUBO, 'SymbolPropertyBinderUBO', {omit: ['layer', 'cachedConstantUniforms', 'cachedConstantRenderZoom', 'cachedConstantBrightness', 'cachedConstantPaint', 'activeAppearanceByVtIndex', 'featureVertexRangesFromId', 'featureVertexRangesFromVtIndex']});

test/integration/render-tests/text-halo-color/setpaint-zero-transition/expected.png

@@ -0,0 +1,35 @@
+{
+    "network": [
+        [
+            "probeNetwork - default - end",
+            1,
+            84942
+        ],
+        [
+            "probeNetwork - default - start",
+            0,
+            0
+        ]
+    ],
+    "gfx": [
+        [
+            "probeGFX - default - end",
+            1,
+            3,
+            5,
+            1,
+            [
+                18667,
+                18667
+            ],
+            [
+                196716,
+                196716
+            ],
+            [
+                768,
+                768
+            ]
+        ]
+    ]
+}

test/integration/render-tests/text-halo-color/setpaint-zero-transition/metrics-native-android-gl-adreno.json

@@ -0,0 +1,35 @@
+{
+    "network": [
+        [
+            "probeNetwork - default - end",
+            1,
+            84942
+        ],
+        [
+            "probeNetwork - default - start",
+            0,
+            0
+        ]
+    ],
+    "gfx": [
+        [
+            "probeGFX - default - end",
+            1,
+            3,
+            5,
+            1,
+            [
+                18667,
+                18667
+            ],
+            [
+                196716,
+                196716
+            ],
+            [
+                768,
+                768
+            ]
+        ]
+    ]
+}

test/integration/render-tests/text-halo-color/setpaint-zero-transition/metrics-native-linux-gl.json

@@ -0,0 +1,35 @@
+{
+    "network": [
+        [
+            "probeNetwork - default - end",
+            1,
+            84942
+        ],
+        [
+            "probeNetwork - default - start",
+            0,
+            0
+        ]
+    ],
+    "gfx": [
+        [
+            "probeGFX - default - end",
+            1,
+            0,
+            0,
+            0,
+            [
+                0,
+                0
+            ],
+            [
+                0,
+                0
+            ],
+            [
+                0,
+                0
+            ]
+        ]
+    ]
+}

test/integration/render-tests/text-halo-color/setpaint-zero-transition/metrics-native-macos-metal.json

@@ -0,0 +1,61 @@
+{
+  "version": 8,
+  "metadata": {
+    "test": {
+      "description": "Regression test for public-13702: setPaintProperty on symbol text-halo-color must render even when the style has a root-level zero-duration transition. Without the fix the halo stays white (cached constant symbol paint is never invalidated when no transition is live); with the fix it renders red.",
+      "width": 64,
+      "height": 64,
+      "operations": [
+        [
+          "setPaintProperty",
+          "symbol",
+          "text-halo-color",
+          "red"
+        ]
+      ]
+    }
+  },
+  "transition": {
+    "duration": 0,
+    "delay": 0
+  },
+  "sources": {
+    "geojson": {
+      "type": "geojson",
+      "data": {
+        "type": "Point",
+        "coordinates": [
+          0,
+          0
+        ]
+      }
+    }
+  },
+  "glyphs": "local://glyphs/{fontstack}/{range}.pbf",
+  "layers": [
+    {
+      "id": "background",
+      "type": "background",
+      "paint": {
+        "background-color": "black"
+      }
+    },
+    {
+      "id": "symbol",
+      "type": "symbol",
+      "source": "geojson",
+      "layout": {
+        "text-field": "ABC",
+        "text-font": [
+          "Open Sans Semibold",
+          "Arial Unicode MS Bold"
+        ]
+      },
+      "paint": {
+        "text-color": "black",
+        "text-halo-width": 2,
+        "text-halo-color": "white"
+      }
+    }
+  ]
+}