Use platform-tags in test framework to configure image

GitOrigin-RevId: e1999bf89bc0a4db1b68294d20439ff7e7c0b1a7

Author: jakra-mb

test/integration/lib/utils.ts

@@ -106,6 +106,11 @@ function ruleMatchesPlatformTag(rule: string, platformTag: string): boolean {
     return rule.length === 0 || platformTag.includes(rule);
 }
 
+export type ImageThresholdRuleMatch = {
+    rule: string;
+    value: number;
+};
+
 function isValidPlatformTagRule(rule: string): boolean {
     return rule.length === 0 || KNOWN_PLATFORM_TAGS.some((platformTag) => platformTag.includes(rule));
 }
@@ -142,8 +147,7 @@ export function matchSkipTestRule(skipTestValue: unknown, platformTag: string |
         if (!ruleValue || typeof ruleValue !== 'object' || Array.isArray(ruleValue)) {
             return {
                 validationError:
-                    `Invalid skip-test rule at index ${index}. Expected an object with ` +
-                    '"platform-tag-contains" and "reason" keys.'
+                    `Invalid skip-test rule at index ${index}. Expected an object with "platform-tag-contains" and "reason" keys.`
             };
         }
 
@@ -152,17 +156,15 @@ export function matchSkipTestRule(skipTestValue: unknown, platformTag: string |
             if (!allowedSkipRuleKeys.has(key)) {
                 return {
                     validationError:
-                        `Unknown key "${key}" in skip-test rule at index ${index}. ` +
-                        'Allowed keys: platform-tag-contains, reason.'
+                        `Unknown key "${key}" in skip-test rule at index ${index}. Allowed keys: platform-tag-contains, reason.`
                 };
             }
         }
 
         if (!('platform-tag-contains' in skipRule) || !('reason' in skipRule)) {
             return {
                 validationError:
-                    `Invalid skip-test rule at index ${index}. Missing required keys ` +
-                    '"platform-tag-contains" and/or "reason".'
+                    `Invalid skip-test rule at index ${index}. Missing required keys "platform-tag-contains" and/or "reason".`
             };
         }
 
@@ -178,9 +180,7 @@ export function matchSkipTestRule(skipTestValue: unknown, platformTag: string |
         if (!isValidPlatformTagRule(rule)) {
             return {
                 validationError:
-                    `Invalid platform-tag rule "${rule}" in skip-test. ` +
-                    `Rule must match at least one known platform-tag by substring. ` +
-                    `Known tags: ${KNOWN_PLATFORM_TAGS.join(', ')}`
+                    `Invalid platform-tag rule "${rule}" in skip-test. Rule must match at least one known platform-tag by substring. Known tags: ${KNOWN_PLATFORM_TAGS.join(', ')}`
             };
         }
         rawRules.push(rule);
@@ -200,6 +200,79 @@ export function matchSkipTestRule(skipTestValue: unknown, platformTag: string |
     return {match: {rules: matchedRules, reasons: matchedReasons}};
 }
 
+type ImageThresholdRule = {
+    'platform-tag-contains': string;
+    threshold: number;
+};
+
+export type ImageThresholdEvaluation = {
+    match?: ImageThresholdRuleMatch;
+    validationError?: string;
+};
+
+/** Evaluates `image-threshold` rules against the platform tag. Last matching rule wins. */
+export function matchImageThresholdRule(imageThresholdValue: unknown, platformTag: string | undefined): ImageThresholdEvaluation {
+    if (!platformTag) return {};
+    if (!imageThresholdValue) return {};
+    if (!Array.isArray(imageThresholdValue)) {
+        return {
+            validationError:
+                'image-threshold must be an array of objects with "platform-tag-contains" and "threshold" keys'
+        };
+    }
+
+    const allowedKeys = new Set(['platform-tag-contains', 'threshold']);
+    let lastMatch: ImageThresholdRuleMatch | undefined;
+
+    for (const [index, ruleValue] of imageThresholdValue.entries()) {
+        if (!ruleValue || typeof ruleValue !== 'object' || Array.isArray(ruleValue)) {
+            return {
+                validationError:
+                    `Invalid image-threshold rule at index ${index}. Expected an object with "platform-tag-contains" and "threshold" keys.`
+            };
+        }
+
+        const ruleObj = ruleValue as Record<string, unknown>;
+        for (const key of Object.keys(ruleObj)) {
+            if (!allowedKeys.has(key)) {
+                return {
+                    validationError:
+                        `Unknown key "${key}" in image-threshold rule at index ${index}. Allowed keys: platform-tag-contains, threshold.`
+                };
+            }
+        }
+
+        if (!('platform-tag-contains' in ruleObj) || !('threshold' in ruleObj)) {
+            return {
+                validationError:
+                    `Invalid image-threshold rule at index ${index}. Missing required keys "platform-tag-contains" and/or "threshold".`
+            };
+        }
+
+        if (typeof ruleObj['platform-tag-contains'] !== 'string' || typeof ruleObj.threshold !== 'number') {
+            return {
+                validationError:
+                    `Invalid image-threshold rule at index ${index}. "platform-tag-contains" must be a string and "threshold" must be a number.`
+            };
+        }
+
+        const typedRule = ruleObj as ImageThresholdRule;
+        const rule = typedRule['platform-tag-contains'];
+        if (!isValidPlatformTagRule(rule)) {
+            return {
+                validationError:
+                    `Invalid platform-tag rule "${rule}" in image-threshold. Rule must match at least one known platform-tag by substring. Known tags: ${KNOWN_PLATFORM_TAGS.join(', ')}`
+            };
+        }
+
+        if (ruleMatchesPlatformTag(rule, platformTag)) {
+            lastMatch = {rule, value: typedRule.threshold};
+        }
+    }
+
+    return lastMatch ? {match: lastMatch} : {};
+}
+
 const suiteStartTime = Date.now();
 
 export function sendBrowserDiagnostics() {

test/integration/query-tests/line-offset/property-function/style.json

@@ -7,6 +7,9 @@
       "queryGeometry": [
         17,
         32
+      ],
+      "image-threshold": [
+        {"platform-tag-contains": "native", "threshold": 0.003}
       ]
     }
   },

test/integration/query-tests/model/basemap/style.json

@@ -3,7 +3,6 @@
   "metadata": {
     "test": {
       "height": 512,
-      "allowed": 0.0015,
       "operations": [
         ["addSource", 
         "trees", 
@@ -30,6 +29,9 @@
       "queryGeometry": [
         165,
         279
+      ],
+      "image-threshold": [
+        {"platform-tag-contains": "", "threshold": 0.0015}
       ]
     }
   },

test/integration/render-tests/3d-intersections/bridge-to-tunnel-transition/style.json

@@ -3,8 +3,10 @@
     "metadata": {
         "test": {
             "mapMode": "static",
-            "allowed": 0.00035,
-            "spriteFormat": "raster"
+            "spriteFormat": "raster",
+            "image-threshold": [
+                {"platform-tag-contains": "", "threshold": 0.00035}
+            ]
         }
     },
     "center": [

test/integration/render-tests/3d-intersections/debug-elevation-ids/style.json

@@ -3,11 +3,13 @@
     "metadata": {
         "test": {
             "mapMode": "static",
-            "allowed": 0.00035,
             "spriteFormat": "raster",
             "showElevationIdDebug": true,
             "skip-test": [
                 {"platform-tag-contains": "native", "reason": "skip - Tested separately in internal tests with different data"}
+            ],
+            "image-threshold": [
+                {"platform-tag-contains": "", "threshold": 0.00035}
             ]
         }
     },

test/integration/render-tests/3d-intersections/depth-segments-undefined-crash-geometry-pass/style.json

@@ -3,7 +3,9 @@
     "metadata": {
         "test": {
             "mapMode": "static",
-            "allowed": 0.001
+            "image-threshold": [
+                {"platform-tag-contains": "", "threshold": 0.001}
+            ]
         }
     },
     "center": [0, 0],

test/integration/render-tests/3d-intersections/elevated-circles-mixed-terrain-enabled/style.json

@@ -3,8 +3,10 @@
     "metadata": {
         "test": {
             "mapMode": "static",
-            "allowed": 0.00025,
-            "spriteFormat": "raster"
+            "spriteFormat": "raster",
+            "image-threshold": [
+                {"platform-tag-contains": "", "threshold": 0.00025}
+            ]
         }
     },
     "center": [

test/integration/render-tests/3d-intersections/elevated-circles-mixed/style.json

@@ -3,8 +3,10 @@
     "metadata": {
         "test": {
             "mapMode": "static",
-            "allowed": 0.00025,
-            "spriteFormat": "raster"
+            "spriteFormat": "raster",
+            "image-threshold": [
+                {"platform-tag-contains": "", "threshold": 0.00025}
+            ]
         }
     },
     "center": [

test/integration/render-tests/3d-intersections/elevated-circles-nonelevated/style.json

@@ -3,8 +3,10 @@
     "metadata": {
         "test": {
             "mapMode": "static",
-            "allowed": 0.00025,
-            "spriteFormat": "raster"
+            "spriteFormat": "raster",
+            "image-threshold": [
+                {"platform-tag-contains": "", "threshold": 0.00025}
+            ]
         }
     },
     "center": [

test/integration/render-tests/3d-intersections/elevated-circles-tiled/style.json

@@ -3,8 +3,10 @@
     "metadata": {
         "test": {
             "mapMode": "static",
-            "allowed": 0.00025,
-            "spriteFormat": "raster"
+            "spriteFormat": "raster",
+            "image-threshold": [
+                {"platform-tag-contains": "", "threshold": 0.00025}
+            ]
         }
     },
     "center": [