Migrate more files to strict TypeScript (internal-16412)

GitOrigin-RevId: 9c1ebf25556bef251fdb8f394e3ceba5850089e6

Author: stepankuzmin

src/style-spec/error/parsing_error.ts

@@ -11,6 +11,6 @@ export default class ParsingError {
         this.error = error;
         this.message = error.message;
         const match = error.message.match(LINE_NUMBER_RE);
-        this.line = match ? parseInt(match[1], 10) : 0;
+        this.line = match && match[1] ? parseInt(match[1], 10) : 0;
     }
 }

src/style-spec/expression/types/resolved_image.ts

@@ -1,3 +1,4 @@
+import assert from '../../util/assert';
 import {ImageId} from './image_id';
 import {ImageVariant} from './image_variant';
 
@@ -56,7 +57,10 @@ export default class ResolvedImage {
     }
 
     static from(image: string | ResolvedImage): ResolvedImage {
-        return typeof image === 'string' ? ResolvedImage.build({name: image}) : image;
+        if (typeof image !== 'string') return image;
+        const resolved = ResolvedImage.build({name: image});
+        assert(resolved);
+        return resolved;
     }
 
     static build(

src/util/url.ts

@@ -8,21 +8,14 @@ export function getURLExtension(url: string): string {
     }
 }
 
-export function setQueryParameters(
-    url: string,
-    params: {
-        [key: string]: string;
-    },
-): string {
+export function setQueryParameters(url: string, params: Record<string, string>): string {
     const paramStart = url.indexOf('?');
-    if (paramStart < 0) return `${url}?${new URLSearchParams(params).toString()}`;
-
-    const searchParams = new URLSearchParams(url.slice(paramStart));
-    for (const key in params) {
-        searchParams.set(key, params[key]);
+    const base = paramStart < 0 ? url : url.slice(0, paramStart);
+    const searchParams = new URLSearchParams(paramStart < 0 ? '' : url.slice(paramStart));
+    for (const [key, value] of Object.entries(params)) {
+        searchParams.set(key, value);
     }
-
-    return `${url.slice(0, paramStart)}?${searchParams.toString()}`;
+    return `${base}?${searchParams}`;
 }
 
 type StripQueryParameters = {

src/util/worker_pool.ts

@@ -10,7 +10,7 @@ export default class WorkerPool {
     static workerCount: number;
 
     active: Partial<Record<number | string, boolean>>;
-    workers: Array<Worker>;
+    workers: Array<Worker> | null;
     name?: string;
     constructor(name?: string) {
         this.active = {};

tsconfig.strict.json

@@ -105,6 +105,10 @@
     "./3d-style/style/indoor_active_floor_strategy.ts",
     "./src/placement/global_placement_priority.ts",
     "./src/placement/placement_rules.ts",
-    "./src/placement/symbol_source.ts"
+    "./src/placement/symbol_source.ts",
+    "./src/style-spec/error/parsing_error.ts",
+    "./src/util/url.ts",
+    "./src/util/worker_pool.ts",
+    "./src/style-spec/expression/types/resolved_image.ts"
   ]
 }