Fix broken fbcode//mapillary/opensfm/opensfm/test:tests-library-type-checking - unmanaged

Reviewed By: ahojnnes

Differential Revision: D104788134

fbshipit-source-id: 41bb0361083125314f568ee587bdd1f2c4a3e3ae

Author: generatedunixname2012458493028417

opensfm/test/test_datastructures.py

@@ -79,7 +79,7 @@ def _create_reconstruction(
                         # create a new observation
                         obs = pymap.Observation(100, 200, 0.5, 255, 0, 0, int(pt.id))
                         shot = rec.shots[str(ch)]
-                        rec.add_observation(shot, pt, obs)
+                        rec.add_observation(shot.id, pt.id, obs)
         # TODO: If required, we have to do the same for pano shots
     return rec
 
@@ -900,7 +900,8 @@ def test_point_reproj_errors_assign() -> None:
     pt = rec.points["0"]
 
     # When assigning reprojections errors
-    reproj_errors = dict({"shot1": np.random.rand(2), "shot2": np.random.rand(2)})
+    reproj_errors = {"shot1": np.random.rand(2), "shot2": np.random.rand(2)}
+    # pyrefly: ignore [bad-argument-type]
     pt.reprojection_errors = reproj_errors
 
     # They should be correct

opensfm/test/test_matching.py

@@ -119,8 +119,7 @@ def test_match_images(scene_synthetic: synthetic_scene.SyntheticInputData) -> No
         pair = images[i], images[i + 1]
         matches = pairs.get(pair)
         if matches is None or len(matches) == 1:
-            # pyrefly: ignore [no-matching-overload]
-            matches = pairs.get(pair[::-1])
+            matches = pairs.get((pair[1], pair[0]))
         assert matches is not None
         assert len(matches) > 25
 

opensfm/test/test_reconstruction_resect.py

@@ -72,8 +72,8 @@ def split_synthetic_reconstruction(
 ) -> Tuple[types.Reconstruction, types.Reconstruction]:
     cluster1 = types.Reconstruction()
     cluster2 = types.Reconstruction()
-    cluster1.cameras = scene.cameras
-    cluster2.cameras = scene.cameras
+    cluster1.cameras = dict(scene.cameras)
+    cluster2.cameras = dict(scene.cameras)
     for i, shot in zip(range(len(scene.shots)), scene.shots.values()):
         if i >= cluster_size:
             cluster2.add_shot(shot)

opensfm/test/test_reconstruction_shot_neighborhood.py

@@ -1,5 +1,5 @@
 # pyre-strict
-from typing import List
+from collections.abc import Iterable
 
 from opensfm import pygeometry, pymap, pysfm, reconstruction, types
 
@@ -9,7 +9,7 @@ def _add_shot(rec: types.Reconstruction, shot_id: str, cam: pygeometry.Camera) -
 
 
 def _add_point(
-    rec: types.Reconstruction, point_id: str, observations: List[str]
+    rec: types.Reconstruction, point_id: str, observations: Iterable[str]
 ) -> None:
     rec.create_point(point_id)
     for shot_id in observations: