refactor: streamline Dart file formatting by using the command line tool instead of the Dart API, removing unnecessary imports and improving CI compatibility

Author: gabbopalma

maplibre_gl/lib/src/layer_properties.dart

@@ -1913,16 +1913,12 @@ class FillExtrusionLayerProperties implements LayerProperties {
     addIfPresent('fill-extrusion-color', fillExtrusionColor);
     addIfPresent('fill-extrusion-translate', fillExtrusionTranslate);
     addIfPresent(
-      'fill-extrusion-translate-anchor',
-      fillExtrusionTranslateAnchor,
-    );
+        'fill-extrusion-translate-anchor', fillExtrusionTranslateAnchor);
     addIfPresent('fill-extrusion-pattern', fillExtrusionPattern);
     addIfPresent('fill-extrusion-height', fillExtrusionHeight);
     addIfPresent('fill-extrusion-base', fillExtrusionBase);
     addIfPresent(
-      'fill-extrusion-vertical-gradient',
-      fillExtrusionVerticalGradient,
-    );
+        'fill-extrusion-vertical-gradient', fillExtrusionVerticalGradient);
     addIfPresent('visibility', visibility);
     return json;
   }
@@ -2241,9 +2237,7 @@ class HillshadeLayerProperties implements LayerProperties {
     }
 
     addIfPresent(
-      'hillshade-illumination-direction',
-      hillshadeIlluminationDirection,
-    );
+        'hillshade-illumination-direction', hillshadeIlluminationDirection);
     addIfPresent('hillshade-illumination-anchor', hillshadeIlluminationAnchor);
     addIfPresent('hillshade-exaggeration', hillshadeExaggeration);
     addIfPresent('hillshade-shadow-color', hillshadeShadowColor);

maplibre_gl_platform_interface/lib/src/source_properties.dart

@@ -607,9 +607,15 @@ class VideoSourceProperties implements SourceProperties {
   /// Type: array
   final List<List>? coordinates;
 
-  const VideoSourceProperties({this.urls, this.coordinates});
+  const VideoSourceProperties({
+    this.urls,
+    this.coordinates,
+  });
 
-  VideoSourceProperties copyWith(List<String>? urls, List<List>? coordinates) {
+  VideoSourceProperties copyWith(
+    List<String>? urls,
+    List<List>? coordinates,
+  ) {
     return VideoSourceProperties(
       urls: urls ?? this.urls,
       coordinates: coordinates ?? this.coordinates,
@@ -651,9 +657,15 @@ class ImageSourceProperties implements SourceProperties {
   /// Type: array
   final List<List>? coordinates;
 
-  const ImageSourceProperties({this.url, this.coordinates});
+  const ImageSourceProperties({
+    this.url,
+    this.coordinates,
+  });
 
-  ImageSourceProperties copyWith(String? url, List<List>? coordinates) {
+  ImageSourceProperties copyWith(
+    String? url,
+    List<List>? coordinates,
+  ) {
     return ImageSourceProperties(
       url: url ?? this.url,
       coordinates: coordinates ?? this.coordinates,

scripts/lib/generate.dart

@@ -23,8 +23,6 @@ import 'dart:convert';
 
 import 'package:mustache_template/mustache_template.dart';
 import 'package:recase/recase.dart';
-import 'package:dart_style/dart_style.dart';
-import 'package:pub_semver/pub_semver.dart';
 
 import 'conversions.dart';
 
@@ -129,28 +127,29 @@ Future<void> render(
   final template = Template(templateFile);
   final outputFile = File('$outputPath/$filename');
 
-  var rendered = template.renderString(renderContext);
+  final rendered = template.renderString(renderContext);
 
-  // Format Dart files so that subsequent `dart format --set-exit-if-changed` doesn't fail (in CI).
+  await outputFile.writeAsString(rendered);
+
+  // For Dart targets, run the official formatter to ensure perfect parity
+  // with `dart format` (used by melos format-all in CI). Doing this instead
+  // of using the dart_style API avoids subtle version / option drift.
   if (filename.endsWith('.dart')) {
     try {
-      // Determine language version from current Dart SDK (major.minor)
-      final sdkVersion = Platform.version.split(' ').first; // e.g. 3.5.2
-      final versionParts = sdkVersion.split('.');
-      final languageVersion =
-          '${versionParts.elementAt(0)}.${versionParts.elementAt(1)}';
-
-      // Pass the version to the formatter so it can format accordingly
-      final versionObj = Version.parse('$languageVersion.0');
-      final formatter = DartFormatter(languageVersion: versionObj);
-      rendered = formatter.format(rendered);
+      final result = await Process.run(
+        'dart',
+        ['format', outputFile.path],
+        runInShell: true,
+      );
+      if (result.exitCode != 0) {
+        stderr.writeln(
+          'Warning: dart format failed for ${outputFile.path}: ${result.stderr}',
+        );
+      }
     } catch (e) {
-      // If formatting fails, keep the unformatted content but log a warning.
-      stderr.writeln('Warning: dart_style failed for $filename: $e');
+      stderr.writeln('Warning: spawning dart format failed for $filename: $e');
     }
   }
-
-  await outputFile.writeAsString(rendered);
 }
 
 /// Build the (paint/layout) style properties list for a given style.json key.

scripts/pubspec.yaml

@@ -9,9 +9,7 @@ environment:
   sdk: ">=3.5.0 <4.0.0"
 
 dependencies:
-  dart_style: ^3.1.2
   mustache_template: ^2.0.1
-  pub_semver: ^2.2.0
   recase: ^4.1.0
 
 dev_dependencies: