Release 0.24.0 (#647)

Co-authored-by: andynewman10 <[email protected]>

Author: gabbopalma

CHANGELOG.md

@@ -1,8 +1,49 @@
-# Change Log
+# CHANGELOG
 
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.24.0](https://github.com/maplibre/flutter-maplibre-gl/compare/v0.23.0...v0.24.0)
+> **Note**: This release has breaking changes.\
+> We apologize for the quick change in 0.24.0: this version definitively stabilizes the signatures of feature interaction callbacks.
+
+This release restores the  **feature id** and makes the `Annotation` parameter **nullable** for all feature interaction callbacks (`tap` / `drag` / `hover`).\
+This unblocks interaction with style-layer features not managed by annotation managers (i.e. added via `addLayer*` / style APIs).
+
+### Breaking Changes
+ * **Tap**: `OnFeatureInteractionCallback` → `(Point<double> point, LatLng coordinates, String id, String layerId, Annotation? annotation)`.
+
+* **Drag**: `OnFeatureDragCallback` → `(Point<double> point, LatLng origin, LatLng current, LatLng delta, String id, Annotation? annotation, DragEventType eventType)`.
+
+* **Hover**: `OnFeatureHoverCallback` → `Point<double> point, LatLng coordinates, String id, Annotation? annotation, HoverEventType eventType)`.
+
+* **Update existing listeners**: The short‑lived 0.23.0-only signatures (without `id`) are removed.
+  * For unmanaged style layer features `annotation` is `null` (`unmanaged` means sources/layers you add via style APIs like `addGeoJsonSource` + `addSymbolLayer`).
+  * For managed annotations it is the `Annotation` object.
+
+### Reasoning
+In 0.23.0 the move to annotation objects inadvertently dropped interaction for unmanaged style features. Reintroducing `id` (and making `annotation` nullable) normalizes all three interaction paths without creating phantom annotation wrappers.
+
+### Migration Example
+Before (0.23.0):
+```
+controller.onFeatureTapped.add((p, latLng, annotation, layerId) {
+  print(annotation.id);
+});
+```
+After (>=0.24.0):
+```
+controller.onFeatureTapped.add((p, latLng, id, layerId, annotation) {
+  print('feature id=$id managed=${annotation != null}');
+});
+```
+
+### Refactor / Quality
+* (web) Refactored `onMapClick` (degenerate bbox + interactive layer filter) to surface features inserted via style APIs (unmanaged style-layer features) in `onFeatureTapped` (previously skipped; returned now with `id`, `layerId` and `annotation = null`) (#646).
+* (web) Ensure map container stretches vertically by adding `style.height = '100%'` to the registered div (prevents occasional zero-height layout issues in flexible parents) (#641)
+
+**Full Changelog**: [v0.23.0...v0.24.0](https://github.com/maplibre/flutter-maplibre-gl/compare/v0.23.0...v0.24.0)
+
 ## [0.23.0](https://github.com/maplibre/flutter-maplibre-gl/compare/v0.22.0...v0.23.0)
 > **Note**: This release has breaking changes.
 

maplibre_gl/CHANGELOG.md

@@ -1,3 +1,44 @@
+## [0.24.0](https://github.com/maplibre/flutter-maplibre-gl/compare/v0.23.0...v0.24.0)
+> **Note**: This release has breaking changes.\
+> We apologize for the quick change in 0.24.0: this version definitively stabilizes the signatures of feature interaction callbacks.
+
+This release restores the  **feature id** and makes the `Annotation` parameter **nullable** for all feature interaction callbacks (`tap` / `drag` / `hover`).\
+This unblocks interaction with style-layer features not managed by annotation managers (i.e. added via `addLayer*` / style APIs).
+
+### Breaking Changes
+ * **Tap**: `OnFeatureInteractionCallback` → `(Point<double> point, LatLng coordinates, String id, String layerId, Annotation? annotation)`.
+
+* **Drag**: `OnFeatureDragCallback` → `(Point<double> point, LatLng origin, LatLng current, LatLng delta, String id, Annotation? annotation, DragEventType eventType)`.
+
+* **Hover**: `OnFeatureHoverCallback` → `Point<double> point, LatLng coordinates, String id, Annotation? annotation, HoverEventType eventType)`.
+
+* **Update existing listeners**: The short‑lived 0.23.0-only signatures (without `id`) are removed.
+  * For unmanaged style layer features `annotation` is `null` (`unmanaged` means sources/layers you add via style APIs like `addGeoJsonSource` + `addSymbolLayer`).
+  * For managed annotations it is the `Annotation` object.
+
+### Reasoning
+In 0.23.0 the move to annotation objects inadvertently dropped interaction for unmanaged style features. Reintroducing `id` (and making `annotation` nullable) normalizes all three interaction paths without creating phantom annotation wrappers.
+
+### Migration Example
+Before (0.23.0):
+```
+controller.onFeatureTapped.add((p, latLng, annotation, layerId) {
+  print(annotation.id);
+});
+```
+After (>=0.24.0):
+```
+controller.onFeatureTapped.add((p, latLng, id, layerId, annotation) {
+  print('feature id=$id managed=${annotation != null}');
+});
+```
+
+### Refactor / Quality
+* (web) Refactored `onMapClick` (degenerate bbox + interactive layer filter) to surface features inserted via style APIs (unmanaged style-layer features) in `onFeatureTapped` (previously skipped; returned now with `id`, `layerId` and `annotation = null`) (#646).
+* (web) Ensure map container stretches vertically by adding `style.height = '100%'` to the registered div (prevents occasional zero-height layout issues in flexible parents) (#641)
+
+**Full Changelog**: [v0.23.0...v0.24.0](https://github.com/maplibre/flutter-maplibre-gl/compare/v0.23.0...v0.24.0)
+
 ## [0.23.0](https://github.com/maplibre/flutter-maplibre-gl/compare/v0.22.0...v0.23.0)
 > **Note**: This release has breaking changes.
 

maplibre_gl/ios/maplibre_gl.podspec

@@ -3,7 +3,7 @@
 #
 Pod::Spec.new do |s|
   s.name             = 'maplibre_gl'
-  s.version          = '0.23.0'
+  s.version          = '0.24.0'
   s.summary          = 'MapLibre GL Flutter plugin'
   s.description      = <<-DESC
 MapLibre GL Flutter plugin.

maplibre_gl/lib/src/annotation_manager.dart

@@ -146,7 +146,8 @@ abstract class AnnotationManager<T extends Annotation> {
     LatLng origin,
     LatLng current,
     LatLng delta,
-    Annotation annotation,
+    String id,
+    Annotation? annotation,
     DragEventType eventType,
   ) async {
     if (annotation is T) {
@@ -157,18 +158,18 @@ abstract class AnnotationManager<T extends Annotation> {
 
   /// Updates (re-sets) an existing annotation quickly by only replacing its
   /// underlying GeoJSON feature if it remains on the same logical layer.
-  Future<void> set(T anntotation) async {
-    assert(_idToAnnotation.containsKey(anntotation.id),
+  Future<void> set(T annotation) async {
+    assert(_idToAnnotation.containsKey(annotation.id),
         "you can only set existing annotations");
-    _idToAnnotation[anntotation.id] = anntotation;
-    final oldLayerIndex = _idToLayerIndex[anntotation.id];
-    final layerIndex = selectLayer != null ? selectLayer!(anntotation) : 0;
+    _idToAnnotation[annotation.id] = annotation;
+    final oldLayerIndex = _idToLayerIndex[annotation.id];
+    final layerIndex = selectLayer != null ? selectLayer!(annotation) : 0;
     if (oldLayerIndex != layerIndex) {
       // Layer changed; must rewrite all sources.
       await _setAll();
     } else {
       await controller.setGeoJsonFeature(
-          _makeLayerId(layerIndex), anntotation.toGeoJson());
+          _makeLayerId(layerIndex), annotation.toGeoJson());
     }
   }
 }

maplibre_gl/lib/src/controller.dart

@@ -7,20 +7,34 @@ part of '../maplibre_gl.dart';
 typedef OnMapClickCallback = void Function(
     Point<double> point, LatLng coordinates);
 
-typedef OnFeatureInteractionCallback = void Function(Point<double> point,
-    LatLng coordinates, Annotation annotation, String layerId);
+// New generalized feature interaction callback that always provides a raw feature id.
+// If the feature also corresponds to a managed annotation, the annotation parameter
+// is non-null; otherwise it is null (e.g. raw style layer feature not managed by an AnnotationManager).
+typedef OnFeatureInteractionCallback = void Function(
+  Point<double> point,
+  LatLng coordinates,
+  String id,
+  String layerId,
+  Annotation? annotation,
+);
 
 typedef OnFeatureDragCallback = void Function(
   Point<double> point,
   LatLng origin,
   LatLng current,
   LatLng delta,
-  Annotation annotation,
+  String id,
+  Annotation? annotation,
   DragEventType eventType,
 );
 
-typedef OnFeatureHoverCallback = void Function(Point<double> point,
-    LatLng latLng, Annotation annotation, HoverEventType eventType);
+typedef OnFeatureHoverCallback = void Function(
+  Point<double> point,
+  LatLng coordinates,
+  String id,
+  Annotation? annotation,
+  HoverEventType eventType,
+);
 
 typedef OnMapLongClickCallback = void Function(
     Point<double> point, LatLng coordinates);
@@ -95,19 +109,19 @@ class MapLibreMapController extends ChangeNotifier {
     _cameraPosition = initialCameraPosition;
 
     _maplibrePlatform.onFeatureTappedPlatform.add((payload) {
-      final id = payload["id"];
+      final id = payload["id"].toString();
+      final layerId = payload["layerId"];
+      final point = payload["point"];
+      final latLng = payload["latLng"];
       final annotation = getAnnotationById(id);
-      if (annotation == null) return;
-      // Call onFeatureTapped callbacks
+
+      // Call all generic feature tapped callbacks
       for (final fun in List.of(onFeatureTapped)) {
-        fun(
-          payload["point"],
-          payload["latLng"],
-          annotation,
-          payload["layerId"],
-        );
+        // New signature supplies id and (possibly null) annotation
+        fun(point, latLng, id, layerId, annotation);
       }
-      // Call specific annotation callbacks (onSymbolTapped, onLineTapped...)
+
+      // If we have a managed annotation, call specific annotation callbacks (onSymbolTapped, onLineTapped...)
       ArgumentCallbacks? annotationTappedCallbacks;
       if (annotation is Line) {
         annotationTappedCallbacks = onLineTapped;
@@ -119,33 +133,53 @@ class MapLibreMapController extends ChangeNotifier {
         annotationTappedCallbacks = onCircleTapped;
       }
       annotationTappedCallbacks?.call(annotation);
+
+      if (annotation != null) {
+        ArgumentCallbacks? annotationTappedCallbacks;
+        if (annotation is Line) {
+          annotationTappedCallbacks = onLineTapped;
+        } else if (annotation is Symbol) {
+          annotationTappedCallbacks = onSymbolTapped;
+        } else if (annotation is Fill) {
+          annotationTappedCallbacks = onFillTapped;
+        } else if (annotation is Circle) {
+          annotationTappedCallbacks = onCircleTapped;
+        }
+        annotationTappedCallbacks?.call(annotation);
+      }
     });
 
     _maplibrePlatform.onFeatureDraggedPlatform.add((payload) {
+      final id = payload["id"];
+      final annotation = getAnnotationById(id);
+      final enmDragEventType = DragEventType.values
+          .firstWhere((element) => element.name == payload["eventType"]);
       for (final fun in List.of(onFeatureDrag)) {
-        final enmDragEventType = DragEventType.values
-            .firstWhere((element) => element.name == payload["eventType"]);
-        final id = payload["id"];
-        final annotation = getAnnotationById(id);
-        if (annotation == null) return;
         fun(
           payload["point"],
           payload["origin"],
           payload["current"],
           payload["delta"],
+          id,
           annotation,
           enmDragEventType,
         );
       }
     });
 
     _maplibrePlatform.onFeatureHoverPlatform.add((payload) {
-      final annotation = getAnnotationById(payload["id"]);
-      if (annotation == null) return;
+      final id = payload["id"];
+      final annotation = getAnnotationById(id);
       final hoverEventType = HoverEventType.values
           .firstWhere((e) => e.name == payload["eventType"]);
       for (final fun in List.of(onFeatureHover)) {
-        fun(payload["point"], payload["latLng"], annotation, hoverEventType);
+        fun(
+          payload["point"],
+          payload["latLng"],
+          id,
+          annotation,
+          hoverEventType,
+        );
       }
     });
 
@@ -222,12 +256,15 @@ class MapLibreMapController extends ChangeNotifier {
     });
   }
 
-  Annotation? getAnnotationById(dynamic id) => id == null
-      ? null
-      : fillManager?.byId(id) ??
-          lineManager?.byId(id) ??
-          symbolManager?.byId(id) ??
-          circleManager?.byId(id);
+  Annotation? getAnnotationById(dynamic id) {
+    if (id == null) return null;
+
+    final formattedId = id.toString();
+    return fillManager?.byId(formattedId) ??
+        lineManager?.byId(formattedId) ??
+        symbolManager?.byId(formattedId) ??
+        circleManager?.byId(formattedId);
+  }
 
   FillManager? fillManager;
   LineManager? lineManager;

maplibre_gl/pubspec.yaml

@@ -1,6 +1,6 @@
 name: maplibre_gl
 description: A Flutter plugin for integrating MapLibre Maps inside a Flutter application on Android, iOS and web platforms.
-version: 0.23.0
+version: 0.24.0
 repository: https://github.com/maplibre/flutter-maplibre-gl
 issue_tracker: https://github.com/maplibre/flutter-maplibre-gl/issues
 resolution: workspace
@@ -12,8 +12,8 @@ environment:
 dependencies:
   flutter:
     sdk: flutter
-  maplibre_gl_platform_interface: ^0.23.0
-  maplibre_gl_web: ^0.23.0
+  maplibre_gl_platform_interface: ^0.24.0
+  maplibre_gl_web: ^0.24.0
 
 dev_dependencies:
   very_good_analysis: ^10.0.0