Merge branch 'main' into docs-overview

Author: CommanderStorm

.github/workflows/test-all.yml

@@ -23,7 +23,7 @@ jobs:
         with:
           node-version-file: '.nvmrc'
       - run: npm ci
-      - run: npm run lint
+      - run: npm run lint -- --max-warnings 0
         if: '!cancelled()'
       - run: npm run lint-css
         if: '!cancelled()'
@@ -215,7 +215,7 @@ jobs:
           COVERAGE_FORMAT: "lcov"
 
       - name: Upload coverage reports to Codecov
-        uses: codecov/codecov-action@1af58845a975a7985b0beb0cbe6fbbb71a41dbad # v5.5.3
+        uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
         with:
           files: ${{ github.workspace }}/coverage-merged/coverage-final.json
           verbose: true

.stylelintrc.json

@@ -13,7 +13,8 @@
     "function-no-unknown": [true, {
       "ignoreFunctions": ["svg-load", "svg-inline"]
     }],
-    "function-disallowed-list": ["/^rgb\\((?!\\d+,\\s*\\d+,\\s*\\d+\\))/"]
+    "function-disallowed-list": ["/^rgb\\((?!\\d+,\\s*\\d+,\\s*\\d+\\))/"],
+    "alpha-value-notation": "number"
   },
   "ignoreFiles": [
       "dist/**/*.css"

CHANGELOG.md

@@ -1,11 +1,26 @@
 ## main
 ### ✨ Features and improvements
 - _...Add new stuff here..._
+
+### 🐞 Bug fixes
+- _...Add new stuff here..._
+
+## 5.23.0
+
+### ✨ Features and improvements
+
 - Add `touchZoomRotate.setZoomRate()` and `touchZoomRotate.setZoomThreshold()` to customize touch zoom speed and pinch sensitivity ([#7271](https://github.com/maplibre/maplibre-gl-js/issues/7271))
+- Improve ability to communicate with imported scripts in workers and use `makeRequest` in workres as well ([#7451](https://github.com/maplibre/maplibre-gl-js/issues/7451)) (by [@HarelM](https://github.com/HarelM))
+- Allow `opacity` and `opacityWhenCovered` in `Marker` and `MarkerOptions` to accept `number` in addition to `string`, and add `maplibregl-marker-covered` CSS class to `Marker` element when covered by 3D terrain or a globe ([#7433](https://github.com/maplibre/maplibre-gl-js/issues/7433)) (by [@YuChunTsao](https://github.com/YuChunTsao))
+- perf: add a bench for terrain rendering and fix `_demMatrixCache` lookup being wasted cycles by actually using the cache ([#7400](https://github.com/maplibre/maplibre-gl-js/pull/7400)) (by [@CommanderStorm](https://github.com/CommanderStorm))
 
 ### 🐞 Bug fixes
+
 - Fix polygon text label placement drifting far from center for convex polygons at high zoom due to coordinate rounding in geojson-vt ([#7380](https://github.com/maplibre/maplibre-gl-js/pull/7380)) (by [@CommanderStorm](https://github.com/CommanderStorm))
-- _...Add new stuff here..._
+- Ensure that a successful ArrayBuffer response from a custom protocol that is null/undefined is set to an empty ArrayBuffer ([#7427](https://github.com/maplibre/maplibre-gl-js/pull/7427)) (by [@neodescis](https://github.com/neodescis))
+- Fix error in `_contextRestored` when map was initialized without a style ([#7432](https://github.com/maplibre/maplibre-gl-js/issues/7432)) (by [@mvanhorn](https://github.com/mvanhorn))
+- Fix issue with the cache used for zoomLevelsToOverscale feature ([#7450](https://github.com/maplibre/maplibre-gl-js/issues/7450)) (by [@HarelM](https://github.com/HarelM))
+- Update stylelint and fix old issues with the CSS (mainly change rgb to use spaces) ([#7365](https://github.com/maplibre/maplibre-gl-js/issues/7365)) (by [@HarelM](https://github.com/HarelM))
 
 ## 5.22.0
 

build/eslint-rules/prefer-type-for-data-shapes.js

@@ -0,0 +1,38 @@
+export default {
+    meta: {
+        type: 'suggestion',
+        docs: {
+            description: 'Prefer type aliases over interfaces for plain data shapes (no methods, no inheritance)',
+        },
+        messages: {
+            preferType: 'Use a type alias instead of an interface for plain data shapes.',
+        },
+        schema: [],
+    },
+    create(context) {
+        return {
+            TSInterfaceDeclaration(node) {
+                if (node.extends && node.extends.length > 0) {
+                    return;
+                }
+
+                const hasBehavior = node.body.body.some(
+                    (member) =>
+                        member.type === 'TSMethodSignature' ||
+                        member.type === 'TSCallSignatureDeclaration' ||
+                        member.type === 'TSConstructSignatureDeclaration' ||
+                        (member.type === 'TSPropertySignature' &&
+                            (member.typeAnnotation?.typeAnnotation?.type === 'TSFunctionType' ||
+                             member.typeAnnotation?.typeAnnotation?.type === 'TSTypeQuery'))
+                );
+
+                if (!hasBehavior) {
+                    context.report({
+                        node: node.id,
+                        messageId: 'preferType',
+                    });
+                }
+            },
+        };
+    },
+};

eslint.config.js

@@ -6,10 +6,11 @@ import globals from 'globals';
 import tsParser from '@typescript-eslint/parser';
 import react from 'eslint-plugin-react';
 import html from 'eslint-plugin-html';
+import preferTypeForDataShapes from './build/eslint-rules/prefer-type-for-data-shapes.js';
 
 export default [
     {
-        ignores: ['build/*.js', 'build/rollup/**', 'staging/**', 'coverage/**', 'node_modules/**', 'docs/**', 'dist/**', 'site/**']
+        ignores: ['build/*.js', 'build/rollup/**', 'staging/**', 'coverage/**', 'node_modules/**', 'docs/**', 'dist/**', 'site/**', '**/*_generated.js']
     },
     {
         ignores: ['test/bench/**'],
@@ -19,6 +20,7 @@ export default [
             '@stylistic': stylisticTs,
             tsdoc,
             vitest,
+            'local': {rules: {'prefer-type-for-data-shapes': preferTypeForDataShapes}},
         },
 
         linterOptions: {
@@ -40,6 +42,7 @@ export default [
                 projectService: {
                     allowDefaultProject: [
                         'build/generate-*.ts',
+                        'build/eslint-rules/*.js',
                         'test/build/*.ts',
                         'eslint.config.js',
                         'postcss.config.js',
@@ -66,6 +69,7 @@ export default [
             '@typescript-eslint/prefer-includes': 'error',
             '@typescript-eslint/prefer-string-starts-ends-with': 'error',
             '@typescript-eslint/array-type': ['error', {default: 'array-simple'}],
+            'local/prefer-type-for-data-shapes': 'error',
 
             'prefer-object-spread': 'error',
             'prefer-object-has-own': 'error',