Skip to content

Commit 7938cc3

Browse files
authored
Try close and open the page when retrying. (#2603)
* Try close and open the page when retying. * Try improve collision tests failures * Improve collision test results * Another attempt to fix test...
1 parent 0f8d790 commit 7938cc3

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

test/integration/render/run_render_tests.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -815,15 +815,19 @@ async function executeRenderTests() {
815815
testStyles = testStyles.splice(+process.env.CURRENT_SPLIT_INDEX * numberOfTestsForThisPart, numberOfTestsForThisPart);
816816
}
817817

818-
const page = await browser.newPage();
818+
let page = await browser.newPage();
819819
applyDebugParameter(options, page);
820820
await page.addScriptTag({path: 'dist/maplibre-gl.js'});
821821

822822
await runTests(page, testStyles, directory);
823823

824824
const failedTests = testStyles.filter(t => t.metadata.test.error || !t.metadata.test.ok);
825825
if (failedTests.length > 0 && failedTests.length < testStyles.length) {
826-
console.log(`Rerunning failed tests: ${failedTests.length}`);
826+
console.log(`Re-running failed tests: ${failedTests.length}`);
827+
page.close();
828+
page = await browser.newPage();
829+
applyDebugParameter(options, page);
830+
await page.addScriptTag({path: 'dist/maplibre-gl.js'});
827831
await runTests(page, failedTests, directory);
828832
}
829833

test/integration/render/tests/debug/collision/style.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
"metadata": {
44
"test": {
55
"collisionDebug": true,
6-
"height": 256
6+
"height": 256,
7+
"operations": [
8+
["sleep", "1000"]
9+
]
710
}
811
},
912
"center": [

0 commit comments

Comments
 (0)