Skip to content

Commit bf6d06d

Browse files
authored
Revert release.yml to original version (#3338)
* Revert release to original version * Update readme.
1 parent ab0ad19 commit bf6d06d

2 files changed

Lines changed: 5 additions & 32 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,17 @@
11
name: Release
22

33
on:
4-
push:
5-
branches: [main]
6-
workflow_dispatch:
4+
workflow_dispatch
75

86
jobs:
9-
release-check:
10-
name: Check if version changed
7+
release:
8+
name: Release
119
runs-on: ubuntu-latest
1210
defaults:
1311
run:
1412
shell: bash
1513
steps:
16-
- uses: actions/checkout@v4
17-
with:
18-
fetch-depth: 0
19-
ref: main
20-
21-
- name: Use Node.js from nvmrc
22-
uses: actions/setup-node@v4
23-
with:
24-
node-version-file: '.nvmrc'
2514

26-
- name: Check if version changed
27-
id: check
28-
uses: EndBug/version-check@v2
29-
30-
outputs:
31-
publish: ${{ steps.check.outputs.changed }}
32-
33-
release-publish:
34-
name: Publish to NPM and GitHub
35-
needs: release-check
36-
if: ${{ needs.release-check.outputs.publish == 'true' }}
37-
runs-on: ubuntu-latest
38-
defaults:
39-
run:
40-
shell: bash
41-
steps:
4215
- uses: actions/checkout@v4
4316
with:
4417
fetch-depth: 0
@@ -174,4 +147,4 @@ jobs:
174147
run: |
175148
npm publish --tag next
176149
env:
177-
NODE_AUTH_TOKEN: ${{ secrets.NPM_ORG_TOKEN }}
150+
NODE_AUTH_TOKEN: ${{ secrets.NPM_ORG_TOKEN }}

developer-guides/release-process.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
- To-be-released changes should be under the "main" header.
66
- Commit any final changes to the changelog.
77
2. Run [Create bump version PR](https://github.com/maplibre/maplibre-gl-js/actions/workflows/create-bump-version-pr.yml) by manual workflow dispatch and set the version number in the input. This will create a PR that changes the changelog and `package.json` file to review and merge.
8-
3. Once merged the release action will automatically see that the version was changed and creates a GitHub release, uploads release assets, and publishes the build output to NPM.
8+
3. Once merged the you'll need to manually start the Release workflow, this action will creates a GitHub release, uploads release assets, and publishes the build output to NPM.
99

1010
The workflow expects `${{ secrets.NPM_ORG_TOKEN }}` organization secret in order to push to NPM registry.

0 commit comments

Comments
 (0)