Fix incorrect shader selection for text labels with inline images

Author: ciscorn

metrics/integration/render-tests/text-field/formatted-images-mixed/expected.png

@@ -0,0 +1,59 @@
+{
+  "version": 8,
+  "metadata": {
+    "test": {
+      "height": 128,
+      "width": 128
+    }
+  },
+  "center": [ 0, 0 ],
+  "zoom": 0,
+  "sources": {
+    "point": {
+      "type": "geojson",
+      "data": {
+        "type": "FeatureCollection",
+        "features": [
+          {
+            "type": "Feature",
+            "geometry": {
+              "type": "Point",
+              "coordinates": [ 0, 20 ]
+            },
+            "properties": {
+              "iconsInText": "yes"
+            }
+          },
+          {
+            "type": "Feature",
+            "geometry": {
+              "type": "Point",
+              "coordinates": [ 0, -20 ]
+            }
+          }
+        ]
+      }
+    }
+  },
+  "glyphs": "local://glyphs/{fontstack}/{range}.pbf",
+  "sprite": "local://sprites/emerald@2x",
+  "layers": [
+    {
+      "id": "text",
+      "type": "symbol",
+      "source": "point",
+      "layout": {
+        "text-field": [
+          "case",
+          ["==", ["get", "iconsInText"], "yes"],
+          ["format", "IconsInText", ["image", "london-underground"]],
+          ["format", "TextOnly"]
+        ],
+        "text-font": [
+          "Open Sans Semibold",
+          "Arial Unicode MS Bold"
+        ]
+      }
+    }
+  ]
+}

metrics/integration/render-tests/text-field/formatted-images-mixed/style.json

@@ -744,7 +744,7 @@ void SymbolLayout::prepareSymbols(const GlyphMap& glyphMap,
 
         // if either shapedText or icon position is present, add the feature
         const Shaping& defaultShaping = getDefaultHorizontalShaping(shapedTextOrientations);
-        iconsInText = defaultShaping && defaultShaping.iconsInText;
+        iconsInText |= defaultShaping && defaultShaping.iconsInText;
         if (defaultShaping || shapedIcon) {
             addFeature(std::distance(features.begin(), it),
                        feature,