Skip to content

Commit 52b3306

Browse files
committed
use taiki-e/install-action to install armerge
1 parent 68a2717 commit 52b3306

4 files changed

Lines changed: 33 additions & 15 deletions

File tree

.github/scripts/install-linux-deps

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,3 @@ DEBIAN_FRONTEND=noninteractive sudo apt-get install -y \
1313
llvm \
1414
glslang-dev \
1515
libbz2-dev
16-
cargo install armerge@2.2.0

.github/workflows/core-release.yml

Lines changed: 28 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,19 +51,21 @@ jobs:
5151

5252
- run: brew install webp libuv
5353

54-
- run: cargo install armerge@2.2.0
54+
- uses: taiki-e/install-action@020705266844b275b711684191e11281be48860c # v2
55+
with:
56+
tool: armerge@2
5557

5658
- name: Build mbgl-core for macOS
5759
run: |
5860
cmake --preset macos-core -DCMAKE_CXX_COMPILER_LAUNCHER=""
59-
cmake --build --preset macos-core
61+
cmake --build build-macos --target mbgl-core
6062
6163
- name: Rename artifact
6264
run: |
6365
cp build-macos/libmbgl-core.a libmaplibre-native-core-macos-arm64-metal.a
6466
cp build-macos/libmbgl-core-amalgam.a libmaplibre-native-core-amalgam-macos-arm64-metal.a
6567
66-
- name: Upload macos-metal-build artifact
68+
- name: Upload macOS artifacts
6769
if: github.event_name == 'pull_request'
6870
uses: actions/upload-artifact@v4
6971
with:
@@ -72,7 +74,7 @@ jobs:
7274
libmaplibre-native-core-macos-arm64-metal.a
7375
libmaplibre-native-core-amalgam-macos-arm64-metal.a
7476
75-
- name: Upload macOS artifact
77+
- name: Upload macOS artifacts (release)
7678
if: github.event_name == 'workflow_dispatch'
7779
run: |
7880
gh release upload core-${{ github.sha }} libmaplibre-native-core-macos-arm64-metal.a
@@ -102,6 +104,10 @@ jobs:
102104
- name: Install dependencies
103105
run: .github/scripts/install-linux-deps
104106

107+
- uses: taiki-e/install-action@020705266844b275b711684191e11281be48860c # v2
108+
with:
109+
tool: armerge@2
110+
105111
- name: Build mbgl-core for Linux
106112
run: |
107113
cmake --preset linux-${{ matrix.renderer }} -DCMAKE_CXX_COMPILER_LAUNCHER=""
@@ -112,7 +118,16 @@ jobs:
112118
cp build-linux-${{ matrix.renderer }}/libmbgl-core.a libmaplibre-native-core-linux-${{ matrix.runner.arch }}-${{ matrix.renderer }}.a
113119
cp build-linux-${{ matrix.renderer }}/libmbgl-core-amalgam.a libmaplibre-native-core-amalgam-linux-${{ matrix.runner.arch }}-${{ matrix.renderer }}.a
114120
115-
- name: Upload Linux artifact
121+
- name: Upload Linux artifacts
122+
if: github.event_name == 'pull_request'
123+
uses: actions/upload-artifact@v4
124+
with:
125+
name: linux-${{ matrix.runner.arch }}-${{ matrix.renderer }}-build
126+
path: |
127+
libmaplibre-native-core-linux-${{ matrix.runner.arch }}-${{ matrix.renderer }}.a
128+
libmaplibre-native-core-amalgam-linux-${{ matrix.runner.arch }}-${{ matrix.renderer }}.a
129+
130+
- name: Upload Linux artifacts (release)
116131
if: github.event_name == 'workflow_dispatch'
117132
run: |
118133
gh release upload core-${{ github.sha }} libmaplibre-native-core-linux-${{ matrix.runner.arch }}-${{ matrix.renderer }}.a
@@ -145,6 +160,14 @@ jobs:
145160
run: Copy-Item build-windows-${{ matrix.renderer }}/mbgl-core.lib maplibre-native-core-windows-x64-${{ matrix.renderer }}.lib
146161

147162
- name: Upload Windows artifact
163+
if: github.event_name == 'pull_request'
164+
uses: actions/upload-artifact@v4
165+
with:
166+
name: windows-${{ matrix.renderer }}-build
167+
path: |
168+
maplibre-native-core-windows-x64-${{ matrix.renderer }}.lib
169+
170+
- name: Upload Windows artifact (release)
148171
if: github.event_name == 'workflow_dispatch'
149172
run: gh release upload core-${{ github.sha }} maplibre-native-core-windows-x64-${{ matrix.renderer }}.lib
150173
env:

.github/workflows/linux-ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,10 @@ jobs:
7878
- name: Install dependencies
7979
run: .github/scripts/install-linux-deps
8080

81+
- uses: taiki-e/install-action@020705266844b275b711684191e11281be48860c # v2
82+
with:
83+
tool: armerge@2
84+
8185
- if: matrix.variant.rust
8286
run: cargo install cxxbridge-cmd --version 1.0.157 --locked
8387

CMakePresets.json

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,6 @@
7070
"MLN_DARWIN_USE_LIBUV": "OFF"
7171
}
7272
},
73-
{
74-
"name": "macos-core",
75-
"inherits": "macos",
76-
"cacheVariables": {
77-
"MLN_CORE_INCLUDE_DEPS": "ON",
78-
"MLN_WITH_GLFW": "OFF"
79-
}
80-
},
8173
{
8274
"name": "linux",
8375
"hidden": true,
@@ -185,7 +177,7 @@
185177
"buildPresets": [
186178
{
187179
"name": "macos-core",
188-
"configurePreset": "macos-core",
180+
"configurePreset": "macos",
189181
"targets": ["mbgl-core"]
190182
},
191183
{

0 commit comments

Comments
 (0)