Bump quickselect from 2.0.0 to 3.0.0 (#734)

dependabot[bot] · HarelM · web-flow · commit 5851810044a0 · 2024-10-22T12:36:44.000Z
* Bump quickselect from 2.0.0 to 3.0.0 Bumps [quickselect](https://github.com/mourner/quickselect) from 2.0.0 to 3.0.0. - [Release notes](https://github.com/mourner/quickselect/releases) - [Commits](mourner/quickselect@v2.0.0...v3.0.0) --- updated-dependencies: - dependency-name: quickselect dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Fix types --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: HarelM <harel.mazor@gmail.com>
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -53,7 +53,7 @@
     "@mapbox/unitbezier": "^0.0.1",
     "json-stringify-pretty-compact": "^4.0.0",
     "minimist": "^1.2.8",
-    "quickselect": "^2.0.0",
+    "quickselect": "^3.0.0",
     "rw": "^1.3.3",
     "tinyqueue": "^3.0.0"
   },
diff --git a/src/util/classify_rings.ts b/src/util/classify_rings.ts
@@ -14,8 +14,8 @@ export function classifyRings<T extends Point2D>(rings: RingWithArea<T>[], maxRi
 
     if (len <= 1) return [rings];
 
-    const polygons: T[][][] = [];
-    let polygon: T[][];
+    const polygons: RingWithArea<T>[][] = [];
+    let polygon: RingWithArea<T>[];
     let ccw: boolean | undefined;
 
     for (const ring of rings) {
@@ -48,7 +48,7 @@ export function classifyRings<T extends Point2D>(rings: RingWithArea<T>[], maxRi
     return polygons;
 }
 
-function compareAreas(a: {area: number}, b: {area: number}) {
+function compareAreas<T extends Point2D>(a: RingWithArea<T>, b: RingWithArea<T>): number {
     return b.area - a.area;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,8 @@ export function classifyRings<T extends Point2D>(rings: RingWithArea<T>[], maxRi`
`14`	`14`
`15`	`15`	`if (len <= 1) return [rings];`
`16`	`16`
`17`		`- const polygons: T[][][] = [];`
`18`		`- let polygon: T[][];`
	`17`	`+ const polygons: RingWithArea<T>[][] = [];`
	`18`	`+ let polygon: RingWithArea<T>[];`
`19`	`19`	`let ccw: boolean \| undefined;`
`20`	`20`
`21`	`21`	`for (const ring of rings) {`
`@@ -48,7 +48,7 @@ export function classifyRings<T extends Point2D>(rings: RingWithArea<T>[], maxRi`
`48`	`48`	`return polygons;`
`49`	`49`	`}`
`50`	`50`
`51`		`-function compareAreas(a: {area: number}, b: {area: number}) {`
	`51`	`+function compareAreas<T extends Point2D>(a: RingWithArea<T>, b: RingWithArea<T>): number {`
`52`	`52`	`return b.area - a.area;`
`53`	`53`	`}`
`54`	`54`