Commit 7138c40
authored
Enforce TypeScript formatting with Biome (#1456)
This builds on the existing Biome setup for the TypeScript code.
I found that 'just ts::fmt' was calling 'npm run format', but that
script did not exist yet. Also, formatting was only handled through
pre-commit, so it was still possible for unformatted TypeScript code to
get merged if pre-commit was not installed locally.
This PR adds Biome as a TypeScript dev dependency, adds format scripts,
and makes the TypeScript lint step check formatting too.
Closes #842.
**Testing I did**
Ran locally:
- 'npm ci'
- 'npm run format:check'
- 'npm run format'
- 'npm run lint'
- 'npm run test'
- 'npm run build'
I also temporarily added badly formatted TypeScript and confirmed 'npm
run format:check' failed, then restored the file.1 parent d9e0f71 commit 7138c40
4 files changed
Lines changed: 191 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
11 | 33 | | |
12 | 34 | | |
13 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| |||
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
| 31 | + | |
29 | 32 | | |
30 | 33 | | |
31 | 34 | | |
| |||
0 commit comments