Skip to content

Commit d58e9d3

Browse files
yutannihilationautofix-ci[bot]CommanderStorm
authored
ci(rust): Build on aarch64 platforms (#974)
I believe fast-pack/FastPFOR-rs#62 and fast-pack/FastPFOR-rs#63 fixed the compilation problem on aarch64 platforms. Now that FastPFOR is updated to v0.7, I think we can enable build on Arm Linux and Arm macOS again (At least, I have no difficulty to build this on my macOS). (But, I don't know what issues "Currently, seems flaky" comment refers to, so it's possible I miss some problems...) --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Frank Elsinga <frank@elsinga.de>
1 parent d9d61ec commit d58e9d3

2 files changed

Lines changed: 22 additions & 17 deletions

File tree

.github/workflows/python-release.yml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,16 @@ jobs:
3333
# FIXME: FSST does not seem to support 32bit targets
3434
#- runner: ubuntu-22.04
3535
# target: x86
36-
# FIXME: Weird portability-cmake issues with fastpfor
36+
# FIXME: Python::initialize not avaliable for linking
3737
#- runner: ubuntu-22.04
3838
# target: aarch64
39+
# FIXME: error: unknown type name '__m128i' and related
3940
#- runner: ubuntu-22.04
4041
# target: armv7
42+
# FIXME: cpp standard mismatch
4143
#- runner: ubuntu-22.04
4244
# target: s390x
45+
# FIXME: error: unknown type name '__m128i' and related
4346
#- runner: ubuntu-22.04
4447
# target: ppc64le
4548
steps:
@@ -69,12 +72,18 @@ jobs:
6972
# platform:
7073
# - runner: ubuntu-22.04
7174
# target: x86_64
75+
# - runner: ubuntu-22.04
76+
# target: x86
77+
# - runner: ubuntu-22.04
78+
# target: aarch64
79+
# - runner: ubuntu-22.04
7280
# # FIXME: FSST does not seem to support 32bit targets
7381
# #- runner: ubuntu-22.04
7482
# # target: x86
75-
# # FIXME: Weird portability-cmake issues with fastpfor
83+
# # FIXME: Python::initialize not avaliable for linking
7684
# #- runner: ubuntu-22.04
77-
# # target: aarch64
85+
# # target: aarch64
86+
# # FIXME: error: unknown type name '__m128i' and related
7887
# #- runner: ubuntu-22.04
7988
# # target: armv7
8089
# steps:
@@ -95,7 +104,7 @@ jobs:
95104
# name: wheels-musllinux-${{ matrix.platform.target }}
96105
# path: dist
97106

98-
# FIXME: Weird portability-cmake issues with fastpfor
107+
# FIXME: Failed to run `zig cc -v` with status exit code: 1: error: unable to create compilation: LibCStdLibHeaderNotFound
99108
#windows:
100109
# runs-on: ${{ matrix.platform.runner }}
101110
# strategy:
@@ -138,9 +147,8 @@ jobs:
138147
platform:
139148
- runner: macos-15-intel
140149
target: x86_64
141-
# FIXME: Weird portability-cmake issues with fastpfor
142-
#- runner: macos-latest
143-
# target: aarch64
150+
- runner: macos-latest
151+
target: aarch64
144152
steps:
145153
- uses: actions/checkout@v6
146154
- uses: ./.github/actions/mlt-setup-rust
@@ -179,7 +187,7 @@ jobs:
179187
- linux
180188
# FIXME: does seem to require dev-only dependencys
181189
#- musllinux
182-
# FIXME: Weird portability-cmake issues with fastpfor
190+
# FIXME: Failed to run `zig cc -v` with status exit code: 1: error: unable to create compilation: LibCStdLibHeaderNotFound
183191
#- windows
184192
- macos
185193
- sdist

.github/workflows/rust.yml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,12 @@ jobs:
9898
- os: ubuntu-latest
9999
target: x86_64-unknown-linux-gnu
100100
artifact_name: mlt-x86_64-unknown-linux-gnu.tar.gz
101-
# Requires mlt > fastpfor to support arm via the existing simde code
102-
# Currently, seems flaky
103-
#- os: ubuntu-22.04-arm
104-
# target: aarch64-unknown-linux-gnu
105-
# artifact_name: mlt-linux-aarch64.tar.gz
106-
# Requires mlt > fastpfor to support apple arm.
107-
#- os: macos-latest
108-
# target: aarch64-apple-darwin
109-
# artifact_name: mlt-macos-aarch64.tar.gz
101+
- os: ubuntu-24.04-arm
102+
target: aarch64-unknown-linux-gnu
103+
artifact_name: mlt-aarch64-unknown-linux-gnu.tar.gz
104+
- os: macos-latest
105+
target: aarch64-apple-darwin
106+
artifact_name: mlt-aarch64-apple-darwin.tar.gz
110107
- os: windows-latest
111108
target: x86_64-pc-windows-msvc
112109
artifact_name: mlt-x86_64-pc-windows-msvc.zip

0 commit comments

Comments
 (0)