FreeBSD port

[ianthetechie]

I think all the prerequisites for this are now taken care of. And I should have some time in the next week to give this a shot. So making an issue for myself.

[CommanderStorm]

you are the best ^^

[ianthetechie]

Ok, actually working on this now... I'm curious what you guys think about the packaging strategy. Right now it's a little bit confusing, since TIL Martin actually has a small set of additional CLI utilities 😂 Here's what I think I'm seeing:

• The workspace has up to 3 binary outputs: martin, martin-cp, and mbtiles.
• martin and martin-cp are built by default, are within the same crate as different bin targets, and have a shared crate version number. i.e. releases of martin and martin-cp are guaranteed to be synchronized.
• mbtiles lives in the workspace, but it does not share a version with martin or mbtiles.
• All 3 binaries are included in martin- tagged releases. But mbtiles- tagged releases don't include any binaries.

So my roundabout question is what you guys think a typical user would expect. All 3 are mentioned throughout Martin docs, and you've taken the step of bundling all 3 in martin- tagged releases. Since martin-cp effectively is tied to the martin release cycle, bundling that in the port seems OK. Bundling these two together is odd, but seems fine.

But mbtiles has its own version and seems like it might have a separate release cadence from the others, which initially makes me think I should create a separate port for it.

Thoughts? cc @nyurik?

[ianthetechie]

Another interesting gotcha: the default Martin build configuration looks like it will bring in the webui crate, which invokes npm via the build script 🤔 Accessing the internet is disallowed during builds except for the phase where you're fetching distfiles from the manifest. There are a few thousand good reasons for that at the time of this writing 😂

Would it be possible to run the npm build and capture the artifacts as a static artifact in the GitHub release action? I haven't gone deep into it, but it LOOKs like it's a vite build that just generates a static site with a JavaScript bundle which you can host however you want (nginx container, python dev server, etc.). If my understanding is correct, generating this in CI would be positive for everyone.

Lemme know if my understanding is correct. I'd be happy to take a whack at it but want to sanity check the direction with you guys first.

[CommanderStorm]

That mbtiles is included with martin* is a bug.
I also somewhat think that we should not have two binaries and instead make the second martin cp 😉
Less cruft and things ^^

webui feature

Lets for now disable the webui and rendering feature.
This saves us a bunch of trouble in packaging things.

[ianthetechie]

That mbtiles is included with martin* is a bug.

😂

I also somewhat think that we should not have two binaries and instead make the second martin cp 😉

I wholeheartedly agree :) Feels like a clap subcommand to me!

Lets for now disable the webui and rendering feature.

Sounds good on the web UI. I didn't think about the rendering part... I'll take a look at that and see how hard it is I guess :)