Limiting cacheSize for hillshadingTileSource, TileCache or ITileCache

[jhotadhari]

Hi,

Is it possible to limit the size of the tile cache for the hillshadingTileSource?

That's the code I'm using https://github.com/jhotadhari/react-native-mapsforge-vtm/blob/fbcf75df543bb3a61fa629300288bb3dede3c866/android/src/main/java/com/jhotadhari/reactnative/mapsforge/vtm/react/modules/MapLayerHillshadingModule.java#L251:

ITileCache mCache = new TileCache(
	getCurrentActivity(),
	cacheDirectory.toString(),
	dbname
);
mCache.setCacheSize( (long) cacheSize * ( 1 << 10 ) );
hillshadingTileSource.setCache( mCache );

I think cacheSize is in MB? Maybe i'm just confused with the units?

I copied the cache implementation from here

vtm/vtm-app/src/org/oscim/app/MapLayers.java

Line 112 in 459e08f

mCache.setCacheSize(512 * (1 << 10));

:

if (tileSource instanceof UrlTileSource) {
    mCache = new TileCache(App.activity, context.getExternalCacheDir().getAbsolutePath(), dbname);
    mCache.setCacheSize(512 * (1 << 10));
    tileSource.setCache(mCache);
} else {
    mCache = null;
}

It feels that the cache is growing unlimited.

And the method TileCache.setCacheSize seems to just clear the cache if 0 == size https://github.com/mapsforge/vtm/blob/459e08f1bdd179c5dfe892009b0cb91c7f764269/vtm-android/src/org/oscim/android/cache/TileCache.java#L279C1-L283C6:

@Override
public void setCacheSize(long size) {
if (size == 0)
    mDatabase.execSQL("DELETE FROM " + TABLE_NAME);
}

What I am doing wrong? Is limiting the cacheSize implemented in vtm?

Thanks for your help

... and thousand thanks for implementing hillshading into vtm and these wonderful ClasyHillShading algorithms!

[devemux86]

This is not a OkHttp Cache on file system like in BitmapTileActivity where its size can be handled by OkHttp.

On Android this is a SQLite cache. There is no implementation for fixed size. Only clear cache is currently supported.