chore(detector): move up ast parser

Author: marabesi

detector/src/languages/JavascriptSmells.ts

@@ -1,15 +1,15 @@
-import { Syntax, parseScript } from "esprima";
-import { Smell, SmellsFinder } from "../types";
-import { SmellsBuilder } from "../smells-builder";
+import { Program, Syntax } from 'esprima';
+import { Smell, SmellsFinder } from '../types';
+import { SmellsBuilder } from '../smells-builder';
 
 export class JavascriptSmells implements SmellsFinder {
 
-  constructor(private code: string) {}
+  constructor(private readonly ast: Program) {}
 
   searchSmells(): Smell[] {
     const smells: Smell[] = [];
 
-    const ast = parseScript(this.code, { loc: true });
+    const ast = this.ast;
 
     const ifs: any[] = [];
     const forOfs: any[] = [];

detector/src/languages/TypescriptSmells.ts

@@ -5,11 +5,10 @@ import { SmellsBuilder } from '../smells-builder';
 
 export class TypescriptSmells implements SmellsFinder {
 
-  constructor(private code: string) { }
+  constructor(private readonly ast: ts.SourceFile) { }
 
   searchSmells(): Smell[] {
-    // wondering why createSource? https://stackoverflow.com/a/60462133/2258921
-    const ast = ts.createSourceFile('temp.ts', this.code, ts.ScriptTarget.ES2020, true);
+    const ast = this.ast;
     const nodes = this.findIfStatements(ast);
 
     const forOfs = this.findForOfStatements(ast).map(forStmt => {

detector/src/smells-detector.ts

@@ -1,17 +1,23 @@
+import { parseScript } from 'esprima';
+import { createSourceFile, ScriptTarget } from 'typescript';
 import { JavascriptSmells } from './languages/JavascriptSmells';
 import { TypescriptSmells } from './languages/TypescriptSmells';
 import { SmellDetectorRunnerResult, SupportedLanguages } from './types';
 
 export class SmellDetector {
 
-  constructor(private code: string, private language: string) { }
+  constructor(private readonly code: string, private readonly language: string) { }
 
   findAll(): SmellDetectorRunnerResult {
     if (this.language === SupportedLanguages.javascript) {
-      const finder = new JavascriptSmells(this.code);
+      const ast = parseScript(this.code, { loc: true });
+
+      const finder = new JavascriptSmells(ast);
       return { smells: finder.searchSmells(), testCases: [] };
     }
 
-    return { smells: new TypescriptSmells(this.code).searchSmells(), testCases: [] };
+    // wondering why createSource? https://stackoverflow.com/a/60462133/2258921
+    const ast = createSourceFile('temp.ts', this.code, ScriptTarget.ES2020, true);
+    return { smells: new TypescriptSmells(ast).searchSmells(), testCases: [] };
   }
 }