Disable inline issue parsing when prefix empty #47

Author: marc0l92

src/rendering/inlineIssueViewPlugin.ts

@@ -72,24 +72,28 @@ let jiraTagMatchDecorator: IMatchDecoratorRef = { ref: null }
 let jiraUrlMatchDecorator: IMatchDecoratorRef = { ref: null }
 
 function buildMatchDecorators() {
-    jiraTagMatchDecorator.ref = new MatchDecorator({
-        regexp: new RegExp(`${SettingsData.inlineIssuePrefix}(${COMPACT_SYMBOL}?)([A-Z0-9]+-[0-9]+)`, 'g'),
-        decoration: (match: RegExpExecArray, view: EditorView, pos: number) => {
-            const compact = !!match[1]
-            const key = match[2]
-            const tagLength = match[0].length
-            if (!isEditorInLivePreviewMode(view) || isCursorInsideTag(view, pos, tagLength) || isSelectionContainsTag(view, pos, tagLength)) {
-                return Decoration.mark({
-                    tagName: 'div',
-                    class: 'HyperMD-codeblock HyperMD-codeblock-bg jira-issue-inline-mark',
-                })
-            } else {
-                return Decoration.replace({
-                    widget: new InlineIssueWidget(key, compact),
-                })
+    if (SettingsData.inlineIssuePrefix !== '') {
+        jiraTagMatchDecorator.ref = new MatchDecorator({
+            regexp: new RegExp(`${SettingsData.inlineIssuePrefix}(${COMPACT_SYMBOL}?)([A-Z0-9]+-[0-9]+)`, 'g'),
+            decoration: (match: RegExpExecArray, view: EditorView, pos: number) => {
+                const compact = !!match[1]
+                const key = match[2]
+                const tagLength = match[0].length
+                if (!isEditorInLivePreviewMode(view) || isCursorInsideTag(view, pos, tagLength) || isSelectionContainsTag(view, pos, tagLength)) {
+                    return Decoration.mark({
+                        tagName: 'div',
+                        class: 'HyperMD-codeblock HyperMD-codeblock-bg jira-issue-inline-mark',
+                    })
+                } else {
+                    return Decoration.replace({
+                        widget: new InlineIssueWidget(key, compact),
+                    })
+                }
             }
-        }
-    })
+        })
+    } else {
+        jiraTagMatchDecorator.ref = null
+    }
 
     if (SettingsData.inlineIssueUrlToTag) {
         const urls: string[] = []

src/settings.ts

@@ -1,6 +1,6 @@
 import { App, Notice, PluginSettingTab, Setting, TextComponent } from 'obsidian'
 import { JiraClient } from './client/jiraClient'
-import { IJiraAutocompleteDataField, IJiraFieldSchema, IJiraIssueAccountSettings } from './client/jiraInterfaces'
+import { IJiraIssueAccountSettings } from './client/jiraInterfaces'
 import JiraIssuePlugin from './main'
 import { ESearchColumnsTypes, ISearchColumn, SEARCH_COLUMNS_DESCRIPTION } from './searchView'
 
@@ -456,13 +456,16 @@ export class JiraIssueSettingTab extends PluginSettingTab {
                     await this.saveSettings()
                 }))
 
-        new Setting(containerEl)
+        const inlineIssuePrefixDesc = (prefix: string) => 'Prefix to use when rendering inline issues. Keep this field empty to disable this feature. '
+            + (prefix ? `Example: ${prefix}AAA-123` : 'Feature disabled.')
+        const inlineIssuePrefixSetting = new Setting(containerEl)
             .setName('Inline issue prefix')
-            .setDesc(`Prefix to use when rendering inline issues. Keep this field empty to disable this feature. Example: ${SettingsData.inlineIssuePrefix}AAA-123`)
+            .setDesc(inlineIssuePrefixDesc(SettingsData.inlineIssuePrefix))
             .addText(text => text
                 .setValue(SettingsData.inlineIssuePrefix)
                 .onChange(async value => {
                     SettingsData.inlineIssuePrefix = value
+                    inlineIssuePrefixSetting.setDesc(inlineIssuePrefixDesc(SettingsData.inlineIssuePrefix))
                     await this.saveSettings()
                 }))
         new Setting(containerEl)