Hide access token in settings #41

Author: marc0l92

esbuild.config.mjs

@@ -1,20 +1,10 @@
-import esbuild from "esbuild";
-import process from "process";
+import esbuild from "esbuild"
+import process from "process"
 import builtins from 'builtin-modules'
 
-const banner =
-    `/*
-THIS IS A GENERATED/BUNDLED FILE BY ESBUILD
-if you want to view the source, please visit the github repository of this plugin
-*/
-`;
-
-const prod = (process.argv[2] === 'production');
+const prod = (process.argv[2] === 'production')
 
 esbuild.build({
-    banner: {
-        js: banner,
-    },
     entryPoints: ['src/main.ts'],
     bundle: true,
     external: [
@@ -49,4 +39,4 @@ esbuild.build({
     sourcemap: prod ? false : 'inline',
     treeShaking: true,
     outfile: 'main.js',
-}).catch(() => process.exit(1));
+}).catch(() => process.exit(1))

manifest.json

@@ -1,7 +1,7 @@
 {
 	"id": "obsidian-jira-issue",
 	"name": "Jira Issue",
-	"version": "1.31.0",
+	"version": "1.32.0",
 	"minAppVersion": "0.12.0",
 	"description": "This plugin allows you to track the progress of Atlassian Jira issues from your Obsidian notes.",
 	"author": "marc0l92",

package.json

@@ -1,6 +1,6 @@
 {
     "name": "obsidian-jira-issue",
-    "version": "1.31.0",
+    "version": "1.32.0",
     "description": "This plugin allows you to track the progress of [Atlassian Jira](https://www.atlassian.com/software/jira) issues from your [Obsidian](https://obsidian.md/) notes.",
     "main": "src/main.js",
     "scripts": {

src/settings.ts

@@ -19,6 +19,7 @@ const AUTHENTICATION_TYPE_DESCRIPTION = {
 
 export const COMPACT_SYMBOL = '-'
 export const COMMENT_REGEX = /^\s*#/
+const HIDDEN_PASSWORD_PLACEHOLDER = '********'
 
 export interface IJiraIssueSettings {
     accounts: IJiraIssueAccountSettings[]
@@ -58,7 +59,7 @@ const DEFAULT_SETTINGS: IJiraIssueSettings = {
             alias: 'Default',
             host: 'https://mycompany.atlassian.net',
             authenticationType: EAuthenticationTypes.OPEN,
-            password: '********',
+            password: HIDDEN_PASSWORD_PLACEHOLDER,
             priority: 1,
             color: '#000000',
         }
@@ -301,7 +302,7 @@ export class JiraIssueSettingsTab extends PluginSettingTab {
                 .setDesc('Password to access your Jira Server account using HTTP basic authentication.')
                 .addText(text => text
                     // .setPlaceholder('')
-                    .setValue(DEFAULT_SETTINGS.accounts.first().password)
+                    .setValue(HIDDEN_PASSWORD_PLACEHOLDER)
                     .onChange(async value => {
                         newAccount.password = value
                     }))
@@ -319,7 +320,7 @@ export class JiraIssueSettingsTab extends PluginSettingTab {
                 .setName('API Token')
                 .addText(text => text
                     // .setPlaceholder('')
-                    .setValue(DEFAULT_SETTINGS.accounts.first().password)
+                    .setValue(HIDDEN_PASSWORD_PLACEHOLDER)
                     .onChange(async value => {
                         newAccount.password = value
                     }))
@@ -337,7 +338,7 @@ export class JiraIssueSettingsTab extends PluginSettingTab {
                 .setDesc('Token to access your Jira account using OAuth3 Bearer token authentication.')
                 .addText(text => text
                     // .setPlaceholder('')
-                    .setValue(newAccount.bareToken)
+                    .setValue(HIDDEN_PASSWORD_PLACEHOLDER)
                     .onChange(async value => {
                         newAccount.bareToken = value
                     }))

versions.json

@@ -31,5 +31,6 @@
 	"1.28.0": "0.12.0",
 	"1.29.0": "0.12.0",
 	"1.30.0": "0.12.0",
-	"1.31.0": "0.12.0"
+	"1.31.0": "0.12.0",
+	"1.32.0": "0.12.0"
 }