Merge pull request #117 from marc101101/feature/registration_duplicate_email

check if email exists before creating a user

Author: marc101101

server/service/UserService.js

@@ -68,18 +68,29 @@ exports.userMeCoursesGET = function (user_id) {
  **/
 exports.userPOST = function (data) {
   return new Promise(function (resolve, reject) {
-    new User(data)
-      .save()
-      .then((user) => {
-        let token = jwt.sign({
-          id: user.attributes.id
-        }, config.secret, {
-          expiresIn: 86400 // expires in 24 hours
-        });
-        resolve({
-          user: user,
-          token: token
-        });
+    User.where({teil_email: data.teil_email})
+      .fetch()
+      .then((model) => {
+          if (!model) {
+            new User(data)
+            .save()
+            .then((user) => {
+              let token = jwt.sign({
+                id: user.attributes.id
+              }, config.secret, {
+                expiresIn: 86400 // expires in 24 hours
+              });
+              resolve({
+                user: user,
+                token: token
+              });
+            })
+            .catch((error) => {
+              reject(error);
+            })
+          } else {
+            reject(Errors.conflict("POST USER EMAIL"))
+          }
       })
       .catch((error) => {
         reject(error);

server/test/user.js

@@ -110,4 +110,25 @@ describe('User', () => {
       })
     })
   })
+  it("it should try to create a user with an already used emai and fail", (done) => {
+    let user =  {
+      teil_vorname: "Peter",
+      teil_nachname: "Lustig",
+      teil_email: "johndoe@vhslq.de",
+      teil_notizen: "Peter's notes",
+      teil_passwort: "hunter22",
+      eingegeben_von_user: 0,
+      eingegeben_am_datum: "2018-01-01",
+      eingegeben_am_zeit: "00:00:00",
+      datenhistory: "Peters's data history"
+    }
+    chai.request(server)
+      .post('/v1/user')
+      .set("Content-Type", "application/json")
+      .send(user)
+      .end((err, res) => {
+        res.should.have.status(409);
+        done();
+      })
+  });
 });