Skip to content

Commit e104d8b

Browse files
cleanup access to volume control of the ES8388
1 parent e459ced commit e104d8b

File tree

3 files changed

+27
-6
lines changed

3 files changed

+27
-6
lines changed

library.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ML_SynthTools",
3-
"version": "2.0.8",
3+
"version": "2.0.9",
44
"keywords": "ML_SynthTools, Synthesizer, Filter, Audio, ESP32, ESP32S2, ESP32S3, STM32, RP2040",
55
"description": "Synthesizer Tools; contains waveform generators etc.",
66
"repository":

library.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name=ML SynthTools
2-
version=2.0.7
2+
version=2.0.9
33
author=Marcel Licence <[email protected]>
44
maintainer=Marcel Licence <[email protected]>
55
sentence=Synthesizer Tools

src/es8388.h

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,14 @@
4949
#ifdef ES8388_ENABLED
5050

5151

52-
void ES8388_Setup();
52+
void ES8388_Setup(void);
5353
void ES8388_SetIn2OoutVOL(uint8_t unused, float vol);
54+
void ES8388_SetDACVOL(float vol);
55+
void ES8388_SetDACVOL(uint8_t unused, float vol);
56+
void ES8388_SetOUT1VOL(float vol);
57+
void ES8388_SetOUT1VOL(uint8_t unused, float vol);
58+
void ES8388_SetOUT2VOL(float vol);
59+
void ES8388_SetOUT2VOL(uint8_t unused, float vol);
5460

5561

5662
#endif // ES8388_ENABLED
@@ -206,7 +212,7 @@ void ES8388_SetADCVOL(uint8_t unused, float vol)
206212
ES8388_WriteReg(0x11, volu8); // RADCVOL
207213
}
208214

209-
void ES8388_SetDACVOL(uint8_t unused, float vol)
215+
void ES8388_SetDACVOL(float vol)
210216
{
211217
#ifdef STATUS_ENABLED
212218
Status_ValueChangedInt("DAC Volume /db", (vol - 1) * 97 + 0.5);
@@ -226,6 +232,11 @@ void ES8388_SetDACVOL(uint8_t unused, float vol)
226232
ES8388_WriteReg(0x1B, volu8); // RDACVOL
227233
}
228234

235+
void ES8388_SetDACVOL(uint8_t unused, float vol)
236+
{
237+
ES8388_SetDACVOL(vol);
238+
}
239+
229240
void ES8388_SetPGAGain(uint8_t unused, float vol)
230241
{
231242
#ifdef STATUS_ENABLED
@@ -349,7 +360,7 @@ void ES8388_SetIn2OoutVOL(uint8_t unused, float vol)
349360
ES8388_WriteReg(0x2A, (volu8 << 3) + var); // RD2RO, RI2RO, RI2ROVOL
350361
}
351362

352-
void ES8388_SetOUT1VOL(uint8_t unused, float vol)
363+
void ES8388_SetOUT1VOL(float vol)
353364
{
354365
#ifdef STATUS_ENABLED
355366
Status_ValueChangedInt("OUT1VOL /db", (vol - 1) * 31 + 0.5);
@@ -368,7 +379,12 @@ void ES8388_SetOUT1VOL(uint8_t unused, float vol)
368379
ES8388_WriteReg(0x2F, volu8); // ROUT1VOL
369380
}
370381

371-
void ES8388_SetOUT2VOL(uint8_t unused, float vol)
382+
void ES8388_SetOUT1VOL(uint8_t unused, float vol)
383+
{
384+
ES8388_SetOUT1VOL(vol);
385+
}
386+
387+
void ES8388_SetOUT2VOL(float vol)
372388
{
373389
#ifdef STATUS_ENABLED
374390
Status_ValueChangedInt("OUT2VOL /db", (vol - 1) * 31 + 0.5);
@@ -387,6 +403,11 @@ void ES8388_SetOUT2VOL(uint8_t unused, float vol)
387403
ES8388_WriteReg(0x31, volu8); // ROUT2VOL
388404
}
389405

406+
void ES8388_SetOUT2VOL(uint8_t unused, float vol)
407+
{
408+
ES8388_SetOUT2VOL(vol);
409+
}
410+
390411
void ES8388_Setup()
391412
{
392413
const uint32_t i2c_freq = 400000;

0 commit comments

Comments
 (0)