Pitchbend range for the sampler?

[KontinuumLab]

I am enjoying your sampler a lot.
As you know, and mostly thanks to your help, I have most things working nicely, including Sampler_PitchBend.
However, given that you use 16 bits for pitchbend, it would be great to be able to expand the range. An octave would be great for my particular use case, and I think for most uses.
Could that be easily implemented?
Thanks!!

[marcel-licence]

Pitchbend support is added now.
I could imagine that it might be useful to set absolut pitch for sounds depends on your needs.

[marcel-licence]

Perfect. I also fixed the breakup of the sound when the pitch bend was changed during playback. In case you are using a wide range it the pitch will be linear means using 2 octaves a value of 50% max might not be one exact octave.
If you are interested in direct sound pitch control let me know. Would be nice for some kind if electronic slide whistle or similar :-)

[KontinuumLab]

Direct pitch control would be awesome, although I'm making some progress with the current implementation.

What I'm working on right now is a recorder, with capacitive "holes". I'm trying to implement a continuous gliding scale across the whole instrument, by reading the partially covered "holes", but with clearly defined pitches when a "hole" combination is fully covered.

So I'm using your Sampler_PitchBend for this. I set the bend range to be 6.5 (13 semitones), as that's the natural range of a 7 hole flute like this. Over 16384 values that works out to 1260 per semitone. Then, from the 16383, I subtract a normalized reading from each key, starting from the top. The more keys I touch, and the more I cover each of them, the lower the note. There's more to it obviously, I'll share more details when it's further along.

Anyway - I'm still developing the algorithm for this, and just now started testing the exact pitches, but now I'm starting to doubt the results I'm getting. Like, maybe a fully pitchbended up note is slightly off from it's fully bended down equivalent from the upper octave, when they should be exact matches. Anyway, like I said, I'm still modifying the algorithm while testing, so there might be some user error involved. Honestly, I'm still trying to figure out the exact consequences of the pitchbend being applied linearly over whatever range I give it, while scales are logarithmic... Do you think it's a valid method?

This algorithm should be calibratable to basically anything, with a carefully designed weight parameter for each key, but direct pitch control would definitely make everything a lot easier 😄

[marcel-licence]

I would suggest that we should use the direct pitch control. On the ESP32 we can get better accuracy. The sampler is optimised to run on devices without float pointing unit. We can calculate the direct pitch and apply it to the played note. That would be nice =)

[KontinuumLab]

I see that you have void Sampler_SetPitch(uint8_t originalPitch, uint32_t sampleRate, int8_t pitchCorrection);in the sampler, but I guess that's for something else, right?

[marcel-licence]

I think Sampler_SetPitch was used to set the correct pitch for example a note to get for example exact 440Hz for an 'a'
I've updated the lib again with 'Sampler_SetAbsolutePitch'

I did some testing, during playback I updated the pitch depending on the param:

 ```

for (uint8_t note = 0; note < 128; note++)
{
switch (param)
{
case 0:
Sampler_SetAbsolutePitch(0, note, 0);
break;
case 1:
Sampler_SetAbsolutePitch(0, note, 2);
break;
case 2:
Sampler_SetAbsolutePitch(0, note, 4);
break;
case 3:
Sampler_SetAbsolutePitch(0, note, 12);
break;
case 4:
Sampler_SetAbsolutePitch(0, note, 24);
break;
case 5:
Sampler_SetAbsolutePitch(0, note, -12);
break;
case 6:
Sampler_SetAbsolutePitch(0, note, -24);
break;
}
}

It would be more efficient to select the current played note. The number is float in semitones. So you should be able to move in between and get the exact pitch. If there is something still off please let me know.
Using 0 plays the sound with the current sample rate, 1 sample per sample