Skip to content

Commit 2d8f6f7

Browse files
committed
Bug 1950455 [wpt PR 50942] - Implement ctx.strokeTextCluster(), a=testonly
Automatic update from web-platform-tests Implement ctx.strokeTextCluster() This CL creates a new method for CanvasRenderingContext2d that strokes a TextCluster object. Its fill counterpart, ctx.fillTextCluster(), was merged in https://crrev.com/c/5854270. This new method came to be from the discussion around the spec for the TextMetrics additions: whatwg/html#11000 The existing tests for fillTextCluster() were renamed to include the method name in the title, since before only "rendering" was mentioned. The new tests are explicitly named using strokeTextCluster(). A line that was duplicated on the tests for fillTextCluster() was also removed. Bug: 341213359 Change-Id: Icd792b56e48f3ea5091e958671c19fcefe67fdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6282180 Commit-Queue: Andres Ricardo Perez <andresrperezchromium.org> Reviewed-by: Fernando Serboncini <fserbchromium.org> Reviewed-by: Stephen Chenney <schenneychromium.org> Cr-Commit-Position: refs/heads/main{#1425171} -- wpt-commits: e515834325719ce9e2a15e2d41bfce49f020db7a wpt-pr: 50942 UltraBlame original commit: c4d5d718989db2d1c940af46af2b61bd0b938b97
1 parent 7d214fa commit 2d8f6f7

File tree

53 files changed

+23278
-761
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+23278
-761
lines changed
+2-10
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,7 @@
7979
.
8080
measure
8181
.
82-
text
83-
-
84-
clusters
85-
-
86-
rendering
82+
fillTextCluster
8783
-
8884
align
8985
.
@@ -101,11 +97,7 @@
10197
.
10298
measure
10399
.
104-
text
105-
-
106-
clusters
107-
-
108-
rendering
100+
fillTextCluster
109101
-
110102
align
111103
.

testing/web-platform/tests/html/canvas/element/text/2d.text.measure.text-clusters-rendering-align.tentative.html testing/web-platform/tests/html/canvas/element/text/2d.text.measure.fillTextCluster-align.tentative.html

+3-15
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,7 @@
8383
.
8484
measure
8585
.
86-
text
87-
-
88-
clusters
89-
-
90-
rendering
86+
fillTextCluster
9187
-
9288
align
9389
.
@@ -110,11 +106,7 @@
110106
.
111107
measure
112108
.
113-
text
114-
-
115-
clusters
116-
-
117-
rendering
109+
fillTextCluster
118110
-
119111
align
120112
.
@@ -132,11 +124,7 @@
132124
.
133125
measure
134126
.
135-
text
136-
-
137-
clusters
138-
-
139-
rendering
127+
fillTextCluster
140128
-
141129
align
142130
.
+2-10
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,7 @@
7979
.
8080
measure
8181
.
82-
text
83-
-
84-
clusters
85-
-
86-
rendering
82+
fillTextCluster
8783
-
8884
baseline
8985
.
@@ -101,11 +97,7 @@
10197
.
10298
measure
10399
.
104-
text
105-
-
106-
clusters
107-
-
108-
rendering
100+
fillTextCluster
109101
-
110102
baseline
111103
.
+3-15
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,7 @@
8383
.
8484
measure
8585
.
86-
text
87-
-
88-
clusters
89-
-
90-
rendering
86+
fillTextCluster
9187
-
9288
baseline
9389
.
@@ -110,11 +106,7 @@
110106
.
111107
measure
112108
.
113-
text
114-
-
115-
clusters
116-
-
117-
rendering
109+
fillTextCluster
118110
-
119111
baseline
120112
.
@@ -132,11 +124,7 @@
132124
.
133125
measure
134126
.
135-
text
136-
-
137-
clusters
138-
-
139-
rendering
127+
fillTextCluster
140128
-
141129
baseline
142130
.
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,7 @@
7979
.
8080
measure
8181
.
82-
text
83-
-
84-
clusters
85-
-
86-
rendering
82+
fillTextCluster
8783
-
8884
drawing
8985
-
@@ -105,11 +101,7 @@
105101
.
106102
measure
107103
.
108-
text
109-
-
110-
clusters
111-
-
112-
rendering
104+
fillTextCluster
113105
-
114106
drawing
115107
-
+3-15
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,7 @@
8383
.
8484
measure
8585
.
86-
text
87-
-
88-
clusters
89-
-
90-
rendering
86+
fillTextCluster
9187
-
9288
drawing
9389
-
@@ -114,11 +110,7 @@
114110
.
115111
measure
116112
.
117-
text
118-
-
119-
clusters
120-
-
121-
rendering
113+
fillTextCluster
122114
-
123115
drawing
124116
-
@@ -140,11 +132,7 @@
140132
.
141133
measure
142134
.
143-
text
144-
-
145-
clusters
146-
-
147-
rendering
135+
fillTextCluster
148136
-
149137
drawing
150138
-
+2-10
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,7 @@
5353
.
5454
measure
5555
.
56-
text
57-
-
58-
clusters
59-
-
60-
rendering
56+
fillTextCluster
6157
-
6258
font
6359
-
@@ -77,11 +73,7 @@
7773
.
7874
measure
7975
.
80-
text
81-
-
82-
clusters
83-
-
84-
rendering
76+
fillTextCluster
8577
-
8678
font
8779
-
+3-15
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,7 @@
5757
.
5858
measure
5959
.
60-
text
61-
-
62-
clusters
63-
-
64-
rendering
60+
fillTextCluster
6561
-
6662
font
6763
-
@@ -86,11 +82,7 @@
8682
.
8783
measure
8884
.
89-
text
90-
-
91-
clusters
92-
-
93-
rendering
85+
fillTextCluster
9486
-
9587
font
9688
-
@@ -110,11 +102,7 @@
110102
.
111103
measure
112104
.
113-
text
114-
-
115-
clusters
116-
-
117-
rendering
105+
fillTextCluster
118106
-
119107
font
120108
-
+2-22
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,7 @@
5353
.
5454
measure
5555
.
56-
text
57-
-
58-
clusters
59-
-
60-
rendering
56+
fillTextCluster
6157
-
6258
options
6359
.
@@ -196,11 +192,7 @@
196192
.
197193
measure
198194
.
199-
text
200-
-
201-
clusters
202-
-
203-
rendering
195+
fillTextCluster
204196
-
205197
options
206198
.
@@ -570,18 +562,6 @@
570562
_assertPixelApprox
571563
(
572564
canvas
573-
5
574-
55
575-
255
576-
0
577-
0
578-
255
579-
2
580-
)
581-
;
582-
_assertPixelApprox
583-
(
584-
canvas
585565
55
586566
55
587567
255

testing/web-platform/tests/html/canvas/element/text/2d.text.measure.text-clusters-range.tentative.html testing/web-platform/tests/html/canvas/element/text/2d.text.measure.fillTextCluster-range.tentative.html

+2-6
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,7 @@
5353
.
5454
measure
5555
.
56-
text
57-
-
58-
clusters
56+
fillTextCluster
5957
-
6058
range
6159
.
@@ -194,9 +192,7 @@
194192
.
195193
measure
196194
.
197-
text
198-
-
199-
clusters
195+
fillTextCluster
200196
-
201197
range
202198
.

0 commit comments

Comments
 (0)