Bug 1918166: Record Ion compilation times in new glean histogram javascript.ion.compile_time. r=tcampbell

Differential Revision: https://phabricator.services.mozilla.com/D229006

UltraBlame original commit: 154887438a23bf41d967bfb6f862f96cf301b5ba

Author: marco-c

js/public/friend/UsageStatistics.h

@@ -530,6 +530,11 @@ FOR_EACH_JS_GLEAN_METRIC
 (
 _
 )
+_
+(
+ION_COMPILE_TIME
+TimeDuration_US
+)
 #
 define
 FOR_EACH_JS_METRIC

js/src/jit/CodeGenerator.h

@@ -1233,6 +1233,34 @@ data
 ;
 #
 endif
+void
+setCompilationTime
+(
+mozilla
+:
+:
+TimeDuration
+duration
+)
+{
+compileTime_
+=
+duration
+;
+}
+mozilla
+:
+:
+TimeDuration
+getCompilationTime
+(
+)
+const
+{
+return
+compileTime_
+;
+}
 private
 :
 void
@@ -2594,6 +2622,19 @@ barriered
 uint32_t
 zoneStubsToReadBarrier_
 ;
+/
+/
+Total
+Ion
+compilation
+time
+.
+mozilla
+:
+:
+TimeDuration
+compileTime_
+;
 #
 ifdef
 FUZZING_JS_FUZZILLI

js/src/jit/Ion.cpp

@@ -2699,6 +2699,44 @@ return
 false
 ;
 }
+/
+/
+Record
+Ion
+compile
+time
+in
+glean
+.
+if
+(
+mozilla
+:
+:
+TimeDuration
+compileTime
+=
+codegen
+-
+>
+getCompilationTime
+(
+)
+)
+{
+cx
+-
+>
+metrics
+(
+)
+.
+ION_COMPILE_TIME
+(
+compileTime
+)
+;
+}
 return
 true
 ;
@@ -10404,6 +10442,22 @@ spewEndFunction
 mir
 )
 ;
+mozilla
+:
+:
+TimeStamp
+compileStartTime
+=
+mozilla
+:
+:
+TimeStamp
+:
+:
+Now
+(
+)
+;
 {
 WarpCompilation
 comp
@@ -10474,13 +10528,43 @@ return
 nullptr
 ;
 }
-return
+CodeGenerator
+*
+codegen
+=
 GenerateCode
 (
 mir
 lir
 )
 ;
+if
+(
+codegen
+)
+{
+codegen
+-
+>
+setCompilationTime
+(
+mozilla
+:
+:
+TimeStamp
+:
+:
+Now
+(
+)
+-
+compileStartTime
+)
+;
+}
+return
+codegen
+;
 }
 static
 AbortReasonOr

js/xpconnect/metrics.yaml

@@ -348,6 +348,88 @@ expires
 never
 javascript
 .
+ion
+:
+compile_time
+:
+type
+:
+timing_distribution
+time_unit
+:
+microsecond
+description
+:
+>
+Time
+in
+microseconds
+of
+an
+Ion
+compilation
+.
+bugs
+:
+-
+https
+:
+/
+/
+bugzilla
+.
+mozilla
+.
+org
+/
+show_bug
+.
+cgi
+?
+id
+=
+1918166
+data_reviews
+:
+-
+https
+:
+/
+/
+bugzilla
+.
+mozilla
+.
+org
+/
+show_bug
+.
+cgi
+?
+id
+=
+1918166
+notification_emails
+:
+-
+dpalmeiro
+mozilla
+.
+com
+-
+perf
+-
+telemetry
+-
+alerts
+mozilla
+.
+com
+expires
+:
+never
+javascript
+.
 gc
 :
 total_time

js/xpconnect/src/XPCJSRuntime.cpp

@@ -19072,6 +19072,33 @@ sample
 ;
 break
 ;
+case
+JSMetric
+:
+:
+ION_COMPILE_TIME
+:
+glean
+:
+:
+javascript_ion
+:
+:
+compile_time
+.
+AccumulateRawDuration
+(
+TimeDuration
+:
+:
+FromMicroseconds
+(
+sample
+)
+)
+;
+break
+;
 default
 :
 /