Skip to content

Commit cefe48d

Browse files
committed
Bug 1917296 - [devtools] Stop propagation of Raw toggle keydown event in Netmonitor Headers panel. r=bomsy,devtools-reviewers.
Assertions are added for all the "Raw" toggle we have in the Request detail panel. Differential Revision: https://phabricator.services.mozilla.com/D222401 UltraBlame original commit: f9a724824507d2cdfea1156407fc8edf3963d941
1 parent 9fad540 commit cefe48d

File tree

5 files changed

+367
-2
lines changed

5 files changed

+367
-2
lines changed

devtools/client/netmonitor/src/components/request-details/HeadersPanel.js

+20
Original file line numberDiff line numberDiff line change
@@ -2760,6 +2760,26 @@ stopPropagation
27602760
)
27612761
;
27622762
}
2763+
onKeyDown
2764+
:
2765+
event
2766+
=
2767+
>
2768+
{
2769+
/
2770+
/
2771+
stop
2772+
the
2773+
header
2774+
keydown
2775+
event
2776+
event
2777+
.
2778+
stopPropagation
2779+
(
2780+
)
2781+
;
2782+
}
27632783
}
27642784
span
27652785
(

devtools/client/netmonitor/test/browser_net_complex-params.js

+43-2
Original file line numberDiff line numberDiff line change
@@ -1230,15 +1230,56 @@ toggle
12301230
"
12311231
)
12321232
;
1233-
clickElement
1233+
/
1234+
/
1235+
Use
1236+
keyboard
1237+
to
1238+
uncheck
1239+
the
1240+
toggle
1241+
so
1242+
we
1243+
test
1244+
Bug
1245+
1917296
1246+
rawDataToggle
1247+
.
1248+
focus
1249+
(
1250+
)
1251+
;
1252+
EventUtils
1253+
.
1254+
synthesizeKey
12341255
(
1256+
"
1257+
VK_SPACE
1258+
"
1259+
{
1260+
}
12351261
rawDataToggle
1236-
monitor
1262+
.
1263+
ownerGlobal
12371264
)
12381265
;
12391266
await
12401267
waitForContent
12411268
;
1269+
ok
1270+
(
1271+
!
1272+
rawDataToggle
1273+
.
1274+
checked
1275+
"
1276+
Raw
1277+
toggle
1278+
is
1279+
unchecked
1280+
"
1281+
)
1282+
;
12421283
}
12431284
async
12441285
function

devtools/client/netmonitor/test/browser_net_headers_sorted.js

+144
Original file line numberDiff line numberDiff line change
@@ -1075,4 +1075,148 @@ sorted
10751075
"
10761076
)
10771077
;
1078+
/
1079+
/
1080+
Use
1081+
keyboard
1082+
to
1083+
uncheck
1084+
the
1085+
toggle
1086+
so
1087+
we
1088+
test
1089+
Bug
1090+
1917296
1091+
for
1092+
(
1093+
const
1094+
rawToggleInput
1095+
of
1096+
document
1097+
.
1098+
querySelectorAll
1099+
(
1100+
"
1101+
.
1102+
devtools
1103+
-
1104+
checkbox
1105+
-
1106+
toggle
1107+
"
1108+
)
1109+
)
1110+
{
1111+
ok
1112+
(
1113+
rawToggleInput
1114+
.
1115+
checked
1116+
"
1117+
Toggle
1118+
is
1119+
checked
1120+
"
1121+
)
1122+
;
1123+
rawToggleInput
1124+
.
1125+
focus
1126+
(
1127+
)
1128+
;
1129+
EventUtils
1130+
.
1131+
synthesizeKey
1132+
(
1133+
"
1134+
VK_SPACE
1135+
"
1136+
{
1137+
}
1138+
rawToggleInput
1139+
.
1140+
ownerGlobal
1141+
)
1142+
;
1143+
}
1144+
/
1145+
/
1146+
Wait
1147+
till
1148+
raw
1149+
headers
1150+
are
1151+
not
1152+
available
1153+
anymore
1154+
.
1155+
await
1156+
waitUntil
1157+
(
1158+
(
1159+
)
1160+
=
1161+
>
1162+
!
1163+
document
1164+
.
1165+
querySelector
1166+
(
1167+
"
1168+
textarea
1169+
.
1170+
raw
1171+
-
1172+
headers
1173+
"
1174+
)
1175+
)
1176+
;
1177+
ok
1178+
(
1179+
true
1180+
"
1181+
Raw
1182+
headers
1183+
are
1184+
hidden
1185+
"
1186+
)
1187+
;
1188+
for
1189+
(
1190+
const
1191+
rawToggleInput
1192+
of
1193+
document
1194+
.
1195+
querySelectorAll
1196+
(
1197+
"
1198+
.
1199+
devtools
1200+
-
1201+
checkbox
1202+
-
1203+
toggle
1204+
"
1205+
)
1206+
)
1207+
{
1208+
ok
1209+
(
1210+
!
1211+
rawToggleInput
1212+
.
1213+
checked
1214+
"
1215+
Toggle
1216+
is
1217+
unchecked
1218+
"
1219+
)
1220+
;
1221+
}
10781222
}

devtools/client/netmonitor/test/browser_net_json_text_mime.js

+80
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,86 @@ testResponseTab
481481
(
482482
)
483483
;
484+
/
485+
/
486+
Uncheck
487+
the
488+
toggle
489+
with
490+
the
491+
keyboard
492+
so
493+
we
494+
test
495+
Bug
496+
1917296
497+
ok
498+
(
499+
rawResponseToggle
500+
.
501+
checked
502+
"
503+
Raw
504+
toggle
505+
is
506+
checked
507+
"
508+
)
509+
;
510+
wait
511+
=
512+
waitForDOM
513+
(
514+
document
515+
"
516+
#
517+
response
518+
-
519+
panel
520+
.
521+
data
522+
-
523+
header
524+
"
525+
)
526+
;
527+
rawResponseToggle
528+
.
529+
focus
530+
(
531+
)
532+
;
533+
EventUtils
534+
.
535+
synthesizeKey
536+
(
537+
"
538+
VK_SPACE
539+
"
540+
{
541+
}
542+
rawResponseToggle
543+
.
544+
ownerGlobal
545+
)
546+
;
547+
await
548+
wait
549+
;
550+
ok
551+
(
552+
!
553+
rawResponseToggle
554+
.
555+
checked
556+
"
557+
Raw
558+
toggle
559+
is
560+
unchecked
561+
"
562+
)
563+
;
484564
await
485565
teardown
486566
(

0 commit comments

Comments
 (0)