Remove redundant OS tool plugins

Author: marcofortina

docs/plugins/generated.md

@@ -7632,71 +7632,6 @@ with:
   timezone: value
 ```
 
-### `os.tool.check`
-
-Check whether one executable exists on the remote PATH.
-
-- Remote session: `true`
-- Dry-run support: `true`
-- Check mode support: `true`
-
-| Parameter | Required | Type | Default | Description |
-|---|---:|---|---|---|
-| `name` | yes | `string` |  | Package, user or group name. |
-| `path` | no | `path` |  | Remote or local path, depending on the plugin. |
-
-Result fields:
-
-- `changed`: Whether the plugin changed the target or controller state.
-- `message`: Human-readable result message.
-- `rc`: Process or command return code when applicable.
-- `stdout`: Captured standard output when applicable.
-- `stderr`: Captured standard error when applicable.
-- `data`: Plugin-specific structured result data.
-- `data.exists`: Whether the remote executable exists.
-- `data.tool`: Checked executable name.
-- `data.path`: Resolved executable path when present.
-
-Example:
-
-```yaml
-use: os.tool.check
-with:
-  name: nginx
-```
-
-### `os.tool.version_check`
-
-Check whether a remote tool version output contains or matches the expected value.
-
-- Remote session: `true`
-- Dry-run support: `true`
-- Check mode support: `true`
-
-| Parameter | Required | Type | Default | Description |
-|---|---:|---|---|---|
-| `name` | yes | `string` |  | Package, user or group name. |
-| `version_arg` | no | `string` | `--version` | Argument used to print a tool version. |
-| `contains` | no | `string` |  | Required substring in stdout or HTTP response body. |
-| `regex` | no | `string` |  | Regular expression expected in command output. |
-
-Result fields:
-
-- `changed`: Whether the plugin changed the target or controller state.
-- `message`: Human-readable result message.
-- `rc`: Process or command return code when applicable.
-- `stdout`: Captured standard output when applicable.
-- `stderr`: Captured standard error when applicable.
-- `data`: Plugin-specific structured result data.
-
-Example:
-
-```yaml
-use: os.tool.version_check
-with:
-  name: nginx
-```
-
 ## security
 
 ### `security.apparmor.complain`

docs/plugins/index.md

@@ -240,8 +240,6 @@ os.time.status
 os.time.timezone.check
 os.time.timezone.get
 os.time.timezone.set
-os.tool.check
-os.tool.version_check
 security.apparmor.complain
 security.apparmor.disable
 security.apparmor.enforce

docs/plugins/security.md

@@ -108,8 +108,6 @@ Use `capabilities requirements` to derive remote tool requirements from the sele
 The explicit capability plugins are:
 
 ```text
-os.tool.check
-os.tool.version_check
 os.capability.check
 automax.plugin.requirements
 ```

src/automax/plugins/capabilities.py

@@ -10,7 +10,7 @@
 from automax.core.capabilities import plugin_tools
 from automax.core.models import ExecutionContext, PluginResult
 from automax.plugins.base import BasePlugin, PluginValidationError
-from automax.plugins.remote_utils import exec_remote, predicate_result_from_remote, quote
+from automax.plugins.remote_utils import exec_remote, quote
 
 
 def _as_list(value: Any) -> list[str]:
@@ -21,70 +21,6 @@ def _as_list(value: Any) -> list[str]:
     return [str(value)]
 
 
-class ToolCheckPlugin(BasePlugin):
-    name = "os.tool.check"
-    description = "Check whether one executable exists on the remote PATH."
-    required_params = ("name",)
-    optional_params = ("path",)
-    opens_remote_session = True
-    supports_check_mode = True
-
-    def diff_preview_reason(self, params: Dict[str, Any], context: ExecutionContext) -> str:
-        return "os.tool.check is a read-only remote dependency check"
-
-    def manual_commands(self, params: Dict[str, Any], context: ExecutionContext) -> list[str]:
-        self.validate(params)
-        path_prefix = f"PATH={quote(params['path'])}:$PATH " if params.get("path") else ""
-        return [f"{path_prefix}command -v {quote(params['name'])}"]
-
-    def execute(self, params: Dict[str, Any], context: ExecutionContext) -> PluginResult:
-        rc, out, err = exec_remote(context, self.manual_commands(params, context)[0])
-        return predicate_result_from_remote(
-            rc=rc,
-            stdout=out,
-            stderr=err,
-            message=f"os.tool.check failed for tool: {params['name']}",
-            data_key="exists",
-            data={"tool": params["name"], "path": out.strip() if rc == 0 else ""},
-        )
-
-
-class ToolVersionAssertPlugin(BasePlugin):
-    name = "os.tool.version_check"
-    description = "Check whether a remote tool version output contains or matches the expected value."
-    required_params = ("name",)
-    optional_params = ("version_arg", "contains", "regex")
-    opens_remote_session = True
-    supports_check_mode = True
-
-    def validate(self, params: Dict[str, Any]) -> None:
-        super().validate(params)
-        if not params.get("contains") and not params.get("regex"):
-            raise PluginValidationError("os.tool.version_check requires contains or regex")
-
-    def diff_preview_reason(self, params: Dict[str, Any], context: ExecutionContext) -> str:
-        return "os.tool.version_check is a read-only remote dependency check"
-
-    def manual_commands(self, params: Dict[str, Any], context: ExecutionContext) -> list[str]:
-        self.validate(params)
-        arg = str(params.get("version_arg", "--version"))
-        command = f"{quote(params['name'])} {arg} 2>&1"
-        if params.get("contains"):
-            return [f"{command} | grep -F -- {quote(params['contains'])}"]
-        return [f"{command} | grep -E -- {quote(params['regex'])}"]
-
-    def execute(self, params: Dict[str, Any], context: ExecutionContext) -> PluginResult:
-        rc, out, err = exec_remote(context, self.manual_commands(params, context)[0])
-        return predicate_result_from_remote(
-            rc=rc,
-            stdout=out,
-            stderr=err,
-            message=f"os.tool.version_check failed for tool: {params['name']}",
-            data_key="matches",
-            data={"tool": params["name"], "version": out.strip() if rc == 0 else ""},
-        )
-
-
 class CapabilityAssertPlugin(BasePlugin):
     name = "os.capability.check"
     description = "Check remote tools, paths and optional shell checks required by a job preflight."

src/automax/plugins/metadata.py

@@ -398,7 +398,6 @@
     "network.http.wait": {"data.status": "HTTP response status code.", "data.body": "Decoded response body."},
     "network.connectivity.port_wait": {"data.host": "Checked host.", "data.port": "Checked TCP port."},
     "network.connectivity.port_check": {"data.host": "Checked host.", "data.port": "Checked TCP/UDP port.", "data.reachable": "Whether the remote target can reach the port."},
-    "os.tool.check": {"data.exists": "Whether the remote executable exists.", "data.tool": "Checked executable name.", "data.path": "Resolved executable path when present."},
     "data.transfer.upload": {"data.src": "Local source path.", "data.dest": "Remote destination path"},
     "data.transfer.download": {"data.src": "Remote source path.", "data.dest": "Local destination path."},
     "data.transfer.rsync": {"data.command": "Executed rsync argument vector."},

src/automax/plugins/registry.py

@@ -93,7 +93,7 @@ def _load_module_file(self, path: Path) -> None:
 
 def build_builtin_registry(extra_plugin_paths: Iterable[str] = ()) -> PluginRegistry:
     """Create a registry with builtin plugins and optional external plugins."""
-    from automax.plugins.capabilities import CapabilityAssertPlugin, PluginRequirementsPlugin, ToolCheckPlugin, ToolVersionAssertPlugin
+    from automax.plugins.capabilities import CapabilityAssertPlugin, PluginRequirementsPlugin
     from automax.plugins.block import (
         BlockFactsPlugin,
         BlockIdentityPlugin,
@@ -530,8 +530,6 @@ def build_builtin_registry(extra_plugin_paths: Iterable[str] = ()) -> PluginRegi
         AlternativesGetPlugin(),
         AlternativesListPlugin(),
         AlternativesCheckPlugin(),
-        ToolCheckPlugin(),
-        ToolVersionAssertPlugin(),
         CapabilityAssertPlugin(),
         PluginRequirementsPlugin(),
         AlternativesSetPlugin(),

tests/test_documentation_and_regressions.py

@@ -1216,8 +1216,6 @@ def test_os_namespace_replaces_legacy_operating_system_plugin_names():
         "os.time.timezone.check",
         "os.time.timezone.get",
         "os.time.timezone.set",
-        "os.tool.check",
-        "os.tool.version_check",
     } <= names
 
     searched = [

tests/test_next_engine.py

@@ -5221,8 +5221,6 @@ def test_capability_and_redaction_plugins_render_safe_previews():
     )
     registry = AutomaxEngine().plugin_registry
 
-    assert registry.get("os.tool.check").manual_commands({"name": "rsync"}, context) == ["command -v rsync"]
-    assert "grep -F" in registry.get("os.tool.version_check").manual_commands({"name": "rsync", "contains": "rsync"}, context)[0]
     assert "command -v setfacl" in registry.get("os.capability.check").manual_commands({"tools": ["setfacl"]}, context)[0]
     assert registry.get("automax.plugin.requirements").execute({"plugin": "data.transfer.rsync"}, context).data["requirements"]["data.transfer.rsync"] == ["rsync"]
 
@@ -5765,7 +5763,6 @@ def test_presence_check_plugins_return_predicates_without_failing_on_absence():
     for plugin_name, params in (
         ("identity.user.check", {"name": "missing-user"}),
         ("identity.group.check", {"name": "missing-group"}),
-        ("os.tool.check", {"name": "missing-tool"}),
     ):
         result = registry.get(plugin_name).execute(params, _remote_context_for_result(1, stderr="not found"))
         assert result.ok is True
@@ -5861,7 +5858,6 @@ def test_os_check_plugins_return_predicates_on_condition_false():
         ("os.env.check", {"name": "DEMO", "value": "1"}, "matches"),
         ("os.package.key.check", {"name": "demo"}, "exists"),
         ("os.package.check", {"name": "curl"}, "matches"),
-        ("os.tool.version_check", {"name": "rsync", "contains": "3."}, "matches"),
         ("os.capability.check", {"tools": ["missing-tool"]}, "matches"),
     ):
         result = registry.get(plugin_name).execute(params, _remote_context_for_result(1, stderr="missing"))