Make device checks return predicate results

Author: marcofortina

docs/plugins/generated.md

@@ -1712,7 +1712,7 @@ with:
 
 ### `device.udev.rule.check`
 
-Assert that a udev rules file exists and optionally matches rendered content.
+Check whether a udev rules file exists and optionally matches rendered content.
 
 - Remote session: `true`
 - Dry-run support: `true`

src/automax/plugins/udev.py

@@ -9,7 +9,7 @@
 
 from automax.core.models import ExecutionContext, PluginResult
 from automax.plugins.base import BasePlugin, PluginValidationError, RenderedFileInstallMixin
-from automax.plugins.remote_utils import CHANGE_MARKER, exec_remote, quote, result_from_remote, sudo_prefix
+from automax.plugins.remote_utils import CHANGE_MARKER, exec_remote, predicate_result_from_remote, quote, result_from_remote, sudo_prefix
 
 
 
@@ -170,7 +170,7 @@ def execute(self, params: Dict[str, Any], context: ExecutionContext) -> PluginRe
 
 class UdevRuleCheckPlugin(BasePlugin):
     name = "device.udev.rule.check"
-    description = "Assert that a udev rules file exists and optionally matches rendered content."
+    description = "Check whether a udev rules file exists and optionally matches rendered content."
     required_params = ("path",)
     optional_params = ("content", "rules", "sudo")
     opens_remote_session = True
@@ -187,4 +187,11 @@ def manual_commands(self, params: Dict[str, Any], context: ExecutionContext) ->
 
     def execute(self, params: Dict[str, Any], context: ExecutionContext) -> PluginResult:
         rc, out, err = exec_remote(context, self.manual_commands(params, context)[0])
-        return result_from_remote(rc=rc, stdout=out, stderr=err, message="device.udev.rule.check failed", data={"path": str(params["path"])})
+        return predicate_result_from_remote(
+            rc=rc,
+            stdout=out,
+            stderr=err,
+            message="device.udev.rule.check failed",
+            data_key="matches" if ("content" in params or "rules" in params) else "exists",
+            data={"path": str(params["path"])},
+        )

tests/test_next_engine.py

@@ -5623,6 +5623,18 @@ def test_presence_check_plugins_return_predicates_without_failing_on_absence():
 
 
 
+
+
+def test_device_udev_rule_check_returns_predicate_on_condition_false():
+    result = AutomaxEngine().plugin_registry.get("device.udev.rule.check").execute(
+        {"path": "/etc/udev/rules.d/99-demo.rules"},
+        _remote_context_for_result(1, stderr="missing"),
+    )
+
+    assert result.ok is True
+    assert result.changed is False
+    assert result.data["exists"] is False
+
 def test_security_and_filesystem_content_checks_return_predicates_on_condition_false():
     registry = AutomaxEngine().plugin_registry