Remove redundant transfer sync wrapper

Author: marcofortina

docs/guides/ssh-smoke.md

@@ -48,7 +48,7 @@ remote user. It covers:
 - `fs.file.line`, `fs.file.replace`, `fs.object.copy`, `fs.object.move`, `fs.symlink.create`, `fs.symlink.remove`
 - `fs.object.find`, `fs.permission.mode`
 - `data.archive.tar.create`, `data.archive.tar.extract`, `data.archive.zip.create`, `data.archive.zip.extract`
-- `data.transfer.upload`, `data.transfer.download`, `data.transfer.sync`
+- `data.transfer.upload`, `data.transfer.download`, `data.transfer.rsync`
 - `system.process.wait`
 - `storage.usage.disk_check`, `network.connectivity.port_check`
 - artifact capture for stdout/stderr/data

docs/plugins/generated.md

@@ -1263,39 +1263,6 @@ with:
   dest: /tmp/dest
 ```
 
-### `data.transfer.sync`
-
-Sync a local directory tree to a remote directory.
-
-- Remote session: `true`
-- Dry-run support: `true`
-- Check mode support: `false`
-
-| Parameter | Required | Type | Default | Description |
-|---|---:|---|---|---|
-| `src` | yes | `path` |  | Source path. |
-| `dest` | yes | `path` |  | Destination path. |
-
-Result fields:
-
-- `changed`: Whether the plugin changed the target or controller state.
-- `message`: Human-readable result message.
-- `rc`: Process or command return code when applicable.
-- `stdout`: Captured standard output when applicable.
-- `stderr`: Captured standard error when applicable.
-- `data`: Plugin-specific structured result data.
-- `data.src`: Local source directory.
-- `data.dest`: Remote destination directory.
-
-Example:
-
-```yaml
-use: data.transfer.sync
-with:
-  src: /tmp/source
-  dest: /tmp/dest
-```
-
 ### `data.transfer.upload`
 
 Upload a local file or directory to a remote target.

docs/plugins/index.md

@@ -53,7 +53,6 @@ data.restore.preview
 data.restore.verify
 data.transfer.download
 data.transfer.rsync
-data.transfer.sync
 data.transfer.upload
 database.mysql.check
 database.mysql.query

docs/plugins/transfer.md

@@ -20,6 +20,8 @@ Uploads a local file or directory to the remote target. Directory upload require
     dest: /tmp/myapp.tar.gz
 ```
 
+For small local directory trees, use `data.transfer.upload` with `recursive: true`. This uses the active SSH/SFTP connection and does not delete remote files that are missing locally. For large or incremental directory trees, use `data.transfer.rsync`.
+
 ## `data.transfer.download`
 
 Downloads a remote file or directory to the controller. Directory download requires `recursive: true`.
@@ -32,21 +34,6 @@ Downloads a remote file or directory to the controller. Directory download requi
     dest: ./artifacts/{{ server.name }}/app.log
 ```
 
-## `data.transfer.sync`
-
-Synchronizes a local tree to a remote destination.
-
-```yaml
-- id: sync_templates
-  use: data.transfer.sync
-  with:
-    src: ./files/
-    dest: /opt/myapp/files/
-```
-
-Use `data.transfer.sync` for small operational trees. It uploads local content to the remote directory and does not currently delete remote files that are missing locally. For very large trees, prefer a specialized artifact or package distribution mechanism.
-
-
 ## Rsync transfers
 
 `data.transfer.rsync` uses the controller-side `rsync` executable and the current

examples/runbooks/runbooks/62-data-transfer.check.yaml

@@ -17,9 +17,6 @@ tasks:
     - id: data_transfer_rsync
       use: data.transfer.rsync
       with: {src: docs, dest: /tmp/dest}
-    - id: data_transfer_sync
-      use: data.transfer.sync
-      with: {src: docs, dest: /tmp/dest}
     - id: data_transfer_upload
       use: data.transfer.upload
       with: {src: README.md, dest: /tmp/dest}

scripts/ssh-smoke.sh

@@ -181,11 +181,12 @@ tasks:
               src: ${TMP_DIR}/payload/dir
               dest: ${WORK_DIR}/uploaded-dir
               recursive: true
-          - id: sync_dir
-            use: data.transfer.sync
+          - id: upload_tree
+            use: data.transfer.upload
             with:
               src: ${TMP_DIR}/payload
               dest: ${WORK_DIR}/synced
+              recursive: true
           - id: download_file
             use: data.transfer.download
             with:

src/automax/plugins/manual_preview.py

@@ -331,7 +331,6 @@ def fallback_manual_commands(plugin_name: str, params: Dict[str, Any], context:
             return [f"scp{_ssh_opts(params)} {_q(str(src))} {_q(str(dest))}"]
         if plugin_name == "data.transfer.upload":
             return [f"scp{_ssh_opts(params)} {_q(str(src))} {_q(str(dest))}"]
-        if plugin_name == "data.transfer.sync":
             return [f"rsync -a {_q(str(src))}/ {_q(str(dest))}/"]
 
     if plugin_name in {"system.cron.entry.add", "system.cron.file"}:

src/automax/plugins/metadata.py

@@ -411,7 +411,6 @@
     "os.package.facts": {"data.packages": "Installed package facts."},
     "system.service.facts": {"data.services": "systemd service facts."},
     "security.sudo.dropin": {"data.path": "Installed sudoers drop-in path."},
-    "data.transfer.sync": {"data.src": "Local source directory.", "data.dest": "Remote destination directory."},
 }
 
 SAMPLE_VALUES: dict[str, Any] = {

src/automax/plugins/registry.py

@@ -448,7 +448,6 @@ def build_builtin_registry(extra_plugin_paths: Iterable[str] = ()) -> PluginRegi
     from automax.plugins.transfer import (
         TransferDownloadPlugin,
         ExtendedTransferRsyncPlugin,
-        TransferSyncPlugin,
         TransferUploadPlugin,
     )
     from automax.plugins.users_extra import (
@@ -716,7 +715,6 @@ def build_builtin_registry(extra_plugin_paths: Iterable[str] = ()) -> PluginRegi
         TransferUploadPlugin(),
         TransferDownloadPlugin(),
         ExtendedTransferRsyncPlugin(),
-        TransferSyncPlugin(),
         FsCdPlugin(),
         FsDirCreatePlugin(),
         FsDirRemovePlugin(),

src/automax/plugins/transfer.py

@@ -240,38 +240,6 @@ def execute(self, params: Dict[str, Any], context: ExecutionContext) -> PluginRe
         return PluginResult.success(changed=True, data={"src": src, "dest": str(dest)})
 
 
-class TransferSyncPlugin(BasePlugin):
-    """Upload a local directory tree to a remote directory."""
-
-    name = "data.transfer.sync"
-    description = "Sync a local directory tree to a remote directory."
-    required_params = ("src", "dest")
-    optional_params = ()
-    opens_remote_session = True
-
-    def validate(self, params: Dict[str, Any]) -> None:
-        super().validate(params)
-        src_value = str(params["src"])
-        if _is_templated_path(src_value):
-            return
-        src = Path(src_value).expanduser()
-        if not src.is_dir():
-            raise PluginValidationError("data.transfer.sync source must be a directory")
-
-    def execute(self, params: Dict[str, Any], context: ExecutionContext) -> PluginResult:
-        self.validate(params)
-        src = Path(str(params["src"])).expanduser()
-        dest = str(params["dest"])
-        sftp = _sftp(context)
-        try:
-            _upload_dir(context, sftp, src, dest)
-        finally:
-            sftp.close()
-        if params.get("checksum"):
-            exec_remote(context, f"sha256sum {quote(dest)} | awk '{{print $1}}' | grep -Fx -- {quote(params['checksum'])}")
-        _remote_apply_attrs(context, dest, params, recursive=src.is_dir())
-        return PluginResult.success(changed=True, data={"src": str(src), "dest": dest})
-
 
 class TransferRsyncPlugin(BasePlugin):
     """Synchronize files using the local rsync executable."""