Commit 13addbc
fix(ci): annotations and advanced-security are mutually exclusive
Two mistakes of mine, both caught by CI rather than locally, both from
running a piece of the chain instead of the chain.
1. The zizmor action refuses to start with both `advanced-security: true`
and `annotations: true`. I switched the first and left the second. Running
zizmor directly does not exercise the action's own option validation, so
the local check could not have caught it -- the action wrapper is part of
the contract and was never run.
`annotations: false` is the right resolution rather than reverting:
inline annotations vanish with the run, a Code Scanning alert persists and
can be triaged. Uploading them is the point of enabling advanced-security.
2. An extraneous `f` prefix on a string literal with no placeholder
(`tests/test_workflow_hardening_gate.py`). Ruff catches it; I had run only
pytest locally, not `ruff check src tests benchmarks`.
Local chain now run as the job runs it: Lint `All checks passed!`,
7 passed, and the gate green on the real tree.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JsDFcKo97HuF5ZLjxa3rRa1 parent 9c2ec22 commit 13addbc
2 files changed
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
59 | 65 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
0 commit comments