-
-
Notifications
You must be signed in to change notification settings - Fork 80
Expand file tree
/
Copy pathlinter.ts
More file actions
297 lines (240 loc) · 8.64 KB
/
linter.ts
File metadata and controls
297 lines (240 loc) · 8.64 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
import { defaultRules } from "./default-rules.js"
import { Location } from "@herb-tools/core"
import { IdentityPrinter } from "@herb-tools/printer"
import { findNodeByLocation } from "./rules/rule-utils.js"
import type { RuleClass, Rule, ParserRule, LexerRule, SourceRule, LintResult, LintOffense, LintContext, AutofixResult } from "./types.js"
import { LinterTodo } from "./linter-todo.js"
import type { HerbBackend } from "@herb-tools/core"
export class Linter {
protected rules: RuleClass[]
protected herb: HerbBackend
protected offenses: LintOffense[]
private linterTodo: LinterTodo | null
/**
* Creates a new Linter instance.
* @param herb - The Herb backend instance for parsing and lexing
* @param rules - Array of rule classes (Parser/AST or Lexer) to use. If not provided, uses default rules.
*/
constructor(herb: HerbBackend, rules?: RuleClass[], LinterTodo?: LinterTodo | null) {
this.herb = herb
this.rules = rules !== undefined ? rules : this.getDefaultRules()
this.offenses = []
this.linterTodo = LinterTodo || null
}
/**
* Returns the default set of rule classes used by the linter.
* @returns Array of rule classes
*/
protected getDefaultRules(): RuleClass[] {
return defaultRules
}
getRuleCount(): number {
return this.rules.length
}
/**
* Type guard to check if a rule is a LexerRule
*/
protected isLexerRule(rule: Rule): rule is LexerRule {
return (rule.constructor as any).type === "lexer"
}
/**
* Type guard to check if a rule is a SourceRule
*/
protected isSourceRule(rule: Rule): rule is SourceRule {
return (rule.constructor as any).type === "source"
}
private filterOffenses(ruleOffenses: LintOffense[], sourceLines: string[], ruleName: string): { kept: LintOffense[], ignored: LintOffense[] } {
const kept: LintOffense[] = [];
const ignored: LintOffense[] = [];
for (const offense of ruleOffenses) {
const line = offense.location.start.line;
if (line > sourceLines.length) {
kept.push(offense);
continue;
}
const lineContent = sourceLines[line - 1];
const disableCommentRegex = /<%#\s+herb:disable\s+(.*)%>/;
const match = lineContent.match(disableCommentRegex);
if (match) {
const rulesRaw = (match && match[1]) || '';
const rules = rulesRaw.split(",").map((rule) => rule.trim());
if (rules.includes(ruleName) || rules.includes("all")) {
ignored.push(offense);
} else {
kept.push(offense);
}
} else {
kept.push(offense);
}
}
return { kept, ignored };
}
/**
* Lint source code using Parser/AST, Lexer, and Source rules.
* @param source - The source code to lint
* @param context - Optional context for linting (e.g., fileName for distinguishing files vs snippets)
*/
lint(source: string, context?: Partial<LintContext>): LintResult {
this.offenses = []
let ignoredCount = 0;
const parseResult = this.herb.parse(source, { track_whitespace: true })
const lexResult = this.herb.lex(source)
const hasParserErrors = parseResult.recursiveErrors().length > 0
const sourceLines = source.split("\n");
for (const RuleClass of this.rules) {
const rule = new RuleClass()
let isEnabled = true
let ruleOffenses: LintOffense[]
if (this.isLexerRule(rule)) {
if (rule.isEnabled) {
isEnabled = rule.isEnabled(lexResult, context)
}
if (isEnabled) {
ruleOffenses = (rule as LexerRule).check(lexResult, context)
} else {
ruleOffenses = []
}
} else if (this.isSourceRule(rule)) {
if (rule.isEnabled) {
isEnabled = rule.isEnabled(source, context)
}
if (isEnabled) {
ruleOffenses = (rule as SourceRule).check(source, context)
} else {
ruleOffenses = []
}
} else {
if (hasParserErrors && rule.name !== "parser-no-errors") {
ruleOffenses = []
continue
}
if (rule.isEnabled) {
isEnabled = rule.isEnabled(parseResult, context)
}
if (isEnabled) {
ruleOffenses = (rule as ParserRule).check(parseResult, context)
} else {
ruleOffenses = []
}
}
const { kept, ignored } = this.filterOffenses(ruleOffenses, sourceLines, rule.name);
ignoredCount += ignored.length;
this.offenses.push(...kept)
}
if (this.linterTodo && context?.fileName) {
const filtered: LintOffense[] = this.linterTodo.filterOffenses(this.offenses, context.fileName)
this.offenses = filtered
}
const errors = this.offenses.filter(offense => offense.severity === "error").length
const warnings = this.offenses.filter(offense => offense.severity === "warning").length
return {
offenses: this.offenses,
errors,
warnings,
ignored: ignoredCount
}
}
/**
* Automatically fix offenses in the source code.
* Uses AST mutation for parser rules and token mutation for lexer rules.
* @param source - The source code to fix
* @param context - Optional context for linting (e.g., fileName)
* @param offensesToFix - Optional array of specific offenses to fix. If not provided, all fixable offenses will be fixed.
* @returns AutofixResult containing the corrected source and lists of fixed/unfixed offenses
*/
autofix(source: string, context?: Partial<LintContext>, offensesToFix?: LintOffense[]): AutofixResult {
const lintResult = offensesToFix ? { offenses: offensesToFix } : this.lint(source, context)
const parserOffenses: LintOffense[] = []
const lexerOffenses: LintOffense[] = []
const sourceOffenses: LintOffense[] = []
for (const offense of lintResult.offenses) {
const RuleClass = this.rules.find(rule => {
const instance = new rule()
return instance.name === offense.rule
})
if (!RuleClass) continue
if ((RuleClass as any).type === "lexer") {
lexerOffenses.push(offense)
} else if ((RuleClass as any).type === "source") {
sourceOffenses.push(offense)
} else {
parserOffenses.push(offense)
}
}
let currentSource = source
const fixed: LintOffense[] = []
const unfixed: LintOffense[] = []
if (parserOffenses.length > 0) {
const parseResult = this.herb.parse(currentSource, { track_whitespace: true })
for (const offense of parserOffenses) {
const RuleClass = this.rules.find(rule => new rule().name === offense.rule)
if (!RuleClass) {
unfixed.push(offense)
continue
}
const rule = new RuleClass() as ParserRule
if (!rule.autofix) {
unfixed.push(offense)
continue
}
if (offense.autofixContext) {
const originalNodeType = offense.autofixContext.node.type
const location: Location = offense.autofixContext.node.location ? Location.from(offense.autofixContext.node.location) : offense.location
const freshNode = findNodeByLocation(
parseResult.value,
location,
(node) => node.type === originalNodeType
)
if (freshNode) {
offense.autofixContext.node = freshNode
} else {
unfixed.push(offense)
continue
}
}
const fixedResult = rule.autofix(offense, parseResult, context)
if (fixedResult) {
fixed.push(offense)
} else {
unfixed.push(offense)
}
}
if (fixed.length > 0) {
const printer = new IdentityPrinter()
currentSource = printer.print(parseResult.value)
}
}
if (sourceOffenses.length > 0) {
const sortedSourceOffenses = sourceOffenses.sort((a, b) => {
if (a.location.start.line !== b.location.start.line) {
return b.location.start.line - a.location.start.line
}
return b.location.start.column - a.location.start.column
})
for (const offense of sortedSourceOffenses) {
const RuleClass = this.rules.find(rule => new rule().name === offense.rule)
if (!RuleClass) {
unfixed.push(offense)
continue
}
const rule = new RuleClass() as SourceRule
if (!rule.autofix) {
unfixed.push(offense)
continue
}
const correctedSource = rule.autofix(offense, currentSource, context)
if (correctedSource) {
currentSource = correctedSource
fixed.push(offense)
} else {
unfixed.push(offense)
}
}
}
return {
source: currentSource,
fixed,
unfixed
}
}
}