Drop --enable-experimental-rbs-comments and let sorbet rely on .rbs files

Author: marcoroth

.github/workflows/build.yml

@@ -56,12 +56,12 @@ jobs:
       - name: Steep
         run: bundle exec steep check
 
-      - name: RBS Inline
-        run: bundle exec rake rbs_inline
-
       - name: Sorbet
         run: bundle exec srb tc
 
+      - name: RBS Inline
+        run: bundle exec rake rbs_inline
+
       - name: clang-tidy version
         run: clang-tidy-21 --version
 

lib/herb/ast/node.rb

@@ -9,12 +9,9 @@ module Herb
   #| }
   module AST
     class Node
-      #: String
-      attr_reader :type
-      #: Location
-      attr_reader :location
-      #: Array[Herb::Errors::Error]
-      attr_reader :errors
+      attr_reader :type #: String
+      attr_reader :location #: Location
+      attr_reader :errors #: Array[Herb::Errors::Error]
 
       #: (String, Location, ?Array[Herb::Errors::Error]) -> void
       def initialize(type, location, errors = [])

lib/herb/lex_result.rb

@@ -3,8 +3,7 @@
 
 module Herb
   class LexResult < Result
-    #: TokenList
-    attr_reader :value
+    attr_reader :value #: TokenList
 
     #: (Array[Herb::Token], String, Array[Herb::Warnings::Warning], Array[Herb::Errors::Error]) -> void
     def initialize(value, source, warnings, errors)

lib/herb/location.rb

@@ -7,10 +7,8 @@ module Herb
   #| end: serialized_position
   #| }
   class Location
-    #: Position
-    attr_reader :start
-    #: Position
-    attr_reader :end
+    attr_reader :start #: Position
+    attr_reader :end #: Position
 
     #: (Position, Position) -> void
     def initialize(start_position, end_position)

lib/herb/position.rb

@@ -4,10 +4,8 @@
 module Herb
   #: type serialized_position = { line: Integer, column: Integer }
   class Position
-    #: Integer
-    attr_reader :line
-    #: Integer
-    attr_reader :column
+    attr_reader :line #: Integer
+    attr_reader :column #: Integer
 
     #: (Integer, Integer) -> void
     def initialize(line, column)

lib/herb/range.rb

@@ -4,10 +4,8 @@
 module Herb
   #: type serialized_range = [Integer, Integer]
   class Range
-    #: Integer
-    attr_reader :from
-    #: Integer
-    attr_reader :to
+    attr_reader :from #: Integer
+    attr_reader :to #: Integer
 
     #: (Integer, Integer) -> void
     def initialize(from, to)

lib/herb/result.rb

@@ -3,12 +3,9 @@
 
 module Herb
   class Result
-    #: String
-    attr_reader :source
-    #: Array[Herb::Warnings::Warning]
-    attr_reader :warnings
-    #: Array[Herb::Errors::Error]
-    attr_reader :errors
+    attr_reader :source #: String
+    attr_reader :warnings #: Array[Herb::Warnings::Warning]
+    attr_reader :errors #: Array[Herb::Errors::Error]
 
     #: (String, Array[Herb::Warnings::Warning], Array[Herb::Errors::Error]) -> void
     def initialize(source, warnings, errors)

lib/herb/warnings.rb

@@ -9,12 +9,9 @@ module Warnings
     #|  message: String
     #| }
     class Warning
-      #: String
-      attr_reader :type
-      #: Location?
-      attr_reader :location
-      #: String
-      attr_reader :message
+      attr_reader :type #: String
+      attr_reader :location #: Location?
+      attr_reader :message #: String
 
       #: (String, Location, String) -> void
       def initialize(type, location, message)