Address Clang Tidy Warnings

Author: marcoroth

src/buffer.c

@@ -1,5 +1,4 @@
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 
 #include "include/buffer.h"

src/include/lexer.h

@@ -6,7 +6,7 @@
 #include "lexer_struct.h"
 #include "token_struct.h"
 
-lexer_T* lexer_init(char* src);
+lexer_T* lexer_init(char* source);
 
 void lexer_skip_whitespace(lexer_T* lexer);
 void lexer_advance(lexer_T* lexer);

src/include/util.h

@@ -1,8 +1,8 @@
 #ifndef ERBX_UTIL_H
 #define ERBX_UTIL_H
 
-int iswhitespace(int character);
-int isnewline(int character);
+int is_whitespace(int character);
+int is_newline(int character);
 
 int count_in_string(const char* string, char character);
 int count_newlines(const char* string);

src/io.c

@@ -4,12 +4,11 @@
 #include <string.h>
 
 char* erbx_read_file(const char* filename) {
-  FILE* fp;
   char* line = NULL;
   size_t len = 0;
   ssize_t read;
 
-  fp = fopen(filename, "rb");
+  FILE* fp = fopen(filename, "rb");
 
   if (fp == NULL) {
     printf("Could not read file '%s'\n", filename);

src/lexer.c

@@ -36,7 +36,7 @@ char lexer_backtrack(lexer_T* lexer, int offset) {
 void lexer_advance(lexer_T* lexer) {
   if (lexer->current_position < lexer->source_length && lexer->current_character != '\0') {
 
-    if (isnewline(lexer->current_character)) {
+    if (is_newline(lexer->current_character)) {
       lexer->current_line += 1;
       lexer->current_column = 1;
     } else {
@@ -79,7 +79,7 @@ token_T* lexer_parse_newline(lexer_T* lexer) {
 token_T* lexer_parse_whitespace(lexer_T* lexer) {
   char* value = calloc(1, sizeof(char));
 
-  while (iswhitespace(lexer->current_character) && lexer->current_character != '\0') {
+  while (is_whitespace(lexer->current_character) && lexer->current_character != '\0') {
     value = realloc(value, (strlen(value) + 2) * sizeof(char));
     strcat(value, (char[]) {lexer->current_character, 0});
     lexer_advance(lexer);
@@ -154,7 +154,7 @@ token_T* lexer_next_token(lexer_T* lexer) {
 
     switch (lexer->state) {
       case STATE_NONE: {
-        if (iswhitespace(lexer->current_character) || isnewline(lexer->current_character)) {
+        if (is_whitespace(lexer->current_character) || is_newline(lexer->current_character)) {
           lexer_skip_whitespace(lexer);
         }
 
@@ -219,7 +219,7 @@ token_T* lexer_next_token(lexer_T* lexer) {
       } break;
 
       case STATE_TAG_ATTRIBUTES: {
-        if (iswhitespace(lexer->current_character) || isnewline(lexer->current_character)) {
+        if (is_whitespace(lexer->current_character) || is_newline(lexer->current_character)) {
           lexer_skip_whitespace(lexer);
         }
 
@@ -248,7 +248,7 @@ token_T* lexer_next_token(lexer_T* lexer) {
       } break;
 
       case STATE_ELEMENT_CHILDREN: {
-        if (iswhitespace(lexer->current_character) || isnewline(lexer->current_character)) {
+        if (is_whitespace(lexer->current_character) || is_newline(lexer->current_character)) {
           lexer_skip_whitespace(lexer);
         }
 
@@ -291,7 +291,7 @@ token_T* lexer_next_token(lexer_T* lexer) {
           return token_init("\0", TOKEN_ATTRIBUTE_VALUE, lexer);
         }
 
-        if (isalpha(lexer->current_character) || iswhitespace(lexer->current_character)) {
+        if (isalpha(lexer->current_character) || is_whitespace(lexer->current_character)) {
           lexer->state = STATE_ATTRIBUTE_VALUE_END;
           return lexer_parse_attribute_value(lexer);
         }
@@ -319,7 +319,7 @@ token_T* lexer_next_token(lexer_T* lexer) {
         return token_init(0, TOKEN_ATTRIBUTE_VALUE, lexer);
       } break;
       default: {
-        if (iswhitespace(lexer->current_character) || isnewline(lexer->current_character)) {
+        if (is_whitespace(lexer->current_character) || is_newline(lexer->current_character)) {
           lexer_skip_whitespace(lexer);
         }
       }

src/parser.c

@@ -4,7 +4,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
 
 size_t parser_sizeof(void) {
   return sizeof(struct PARSER_STRUCT);

src/token.c

@@ -1,7 +1,6 @@
 #include "include/token.h"
 #include "include/lexer.h"
 #include "include/location.h"
-#include "include/macros.h"
 #include "include/token_struct.h"
 #include "include/util.h"
 

src/util.c

@@ -3,11 +3,11 @@
 
 #include "include/util.h"
 
-int iswhitespace(int character) {
+int is_whitespace(int character) {
   return character == ' ' || character == '\t';
 }
 
-int isnewline(int character) {
+int is_newline(int character) {
   return character == 13 || character == 10;
 }