RuboCop: Enable Style/WordArray and Style/SymbolArray with EnforcedStyle: brackets

Author: marcoroth

.rubocop.yml

@@ -29,10 +29,12 @@ Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
 
 Style/WordArray:
-  Enabled: false
+  Enabled: true
+  EnforcedStyle: brackets
 
 Style/SymbolArray:
-  Enabled: false
+  Enabled: true
+  EnforcedStyle: brackets
 
 Style/BlockDelimiters:
   Enabled: false

Rakefile

@@ -22,17 +22,17 @@ end
 begin
   require "rake/extensiontask"
 
-  PLATFORMS = %w[
-    aarch64-linux-gnu
-    aarch64-linux-musl
-    arm-linux-gnu
-    arm-linux-musl
-    arm64-darwin
-    x86_64-darwin
-    x86_64-linux-gnu
-    x86_64-linux-musl
-    x86-linux-gnu
-    x86-linux-musl
+  PLATFORMS = [
+    "aarch64-linux-gnu",
+    "aarch64-linux-musl",
+    "arm-linux-gnu",
+    "arm-linux-musl",
+    "arm64-darwin",
+    "x86_64-darwin",
+    "x86_64-linux-gnu",
+    "x86_64-linux-musl",
+    "x86-linux-gnu",
+    "x86-linux-musl"
   ].freeze
 
   exttask = Rake::ExtensionTask.new do |ext|

ext/herb/extconf.rb

@@ -24,38 +24,38 @@
 
 herb_src_files = Dir.glob("#{$srcdir}/../../src/**/*.c").map { |file| file.delete_prefix("../../../../ext/herb/") }.sort
 
-prism_main_files = %w[
-  diagnostic.c
-  encoding.c
-  node.c
-  options.c
-  pack.c
-  prettyprint.c
-  prism.c
-  regexp.c
-  serialize.c
-  static_literals.c
-  token_type.c
+prism_main_files = [
+  "diagnostic.c",
+  "encoding.c",
+  "node.c",
+  "options.c",
+  "pack.c",
+  "prettyprint.c",
+  "prism.c",
+  "regexp.c",
+  "serialize.c",
+  "static_literals.c",
+  "token_type.c"
 ]
 
-prism_util_files = %w[
-  pm_buffer.c
-  pm_char.c
-  pm_constant_pool.c
-  pm_integer.c
-  pm_list.c
-  pm_memchr.c
-  pm_newline_list.c
-  pm_string.c
-  pm_strncasecmp.c
-  pm_strpbrk.c
+prism_util_files = [
+  "pm_buffer.c",
+  "pm_char.c",
+  "pm_constant_pool.c",
+  "pm_integer.c",
+  "pm_list.c",
+  "pm_memchr.c",
+  "pm_newline_list.c",
+  "pm_string.c",
+  "pm_strncasecmp.c",
+  "pm_strpbrk.c"
 ]
 
-core_src_files = %w[
-  extension.c
-  nodes.c
-  error_helpers.c
-  extension_helpers.c
+core_src_files = [
+  "extension.c",
+  "nodes.c",
+  "error_helpers.c",
+  "extension_helpers.c"
 ]
 
 $srcs = core_src_files + herb_src_files + prism_main_files + prism_util_files

lib/herb/engine/compiler.rb

@@ -71,7 +71,7 @@ def visit_html_element_node(node)
         visit_all(node.body)
         visit(node.close_tag)
 
-        pop_context if %w[script style].include?(tag_name)
+        pop_context if ["script", "style"].include?(tag_name)
 
         @element_stack.pop if tag_name
       end
@@ -91,7 +91,7 @@ def visit_html_conditional_element_node(node)
         visit_all(node.body)
         visit(node.close_conditional)
 
-        pop_context if %w[script style].include?(tag_name)
+        pop_context if ["script", "style"].include?(tag_name)
 
         @element_stack.pop if tag_name
       end

lib/herb/engine/validators/nesting_validator.rb

@@ -31,7 +31,7 @@ def validate_html_nesting(node)
         end
 
         def validate_no_block_elements_in_paragraph(node)
-          block_elements = %w[div section article header footer nav aside p h1 h2 h3 h4 h5 h6 ul ol dl table form]
+          block_elements = ["div", "section", "article", "header", "footer", "nav", "aside", "p", "h1", "h2", "h3", "h4", "h5", "h6", "ul", "ol", "dl", "table", "form"]
 
           node.body.each do |child|
             next unless child.is_a?(Herb::AST::HTMLElementNode)
@@ -58,7 +58,7 @@ def validate_no_nested_anchors(node)
         end
 
         def validate_no_interactive_in_button(node)
-          interactive_elements = %w[a button input select textarea]
+          interactive_elements = ["a", "button", "input", "select", "textarea"]
 
           node.body.each do |child|
             next unless child.is_a?(Herb::AST::HTMLElementNode)